Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0046023

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Cash up

major

always

2021-03-09 10:32

2021-03-15 07:36

Reporter

lbressan

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

high

Resolution

fixed

Fixed in Version

RR21Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

pi

SCM revision

Review Assigned To

Regression level

Production - QA Approved

Regression date

2021-08-04

Regression introduced in release

RR20Q4

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/bf21ded351dca4fb3a7ea1b39f8b943b3a526d34 [^]

Triggers an Emergency Pack

No

Summary

0046023: Duplicate printing after partial cash up printing

Description

Duplicate printing after partial cash up printing.
In the following url is the video where the problem is reproduced:
https://youtu.be/yqgGq2Fncmw [^]

Steps To Reproduce

1- Go to web pos
2 - Print ticket and review that print 1 copy
3- Print cashup partial and review that print 1 copy
4 - Print ticket and review that print 2 copies, it's incorrect
5 - If refresh the page and print ticket, 1 copy is printed

Tags

No tags attached.

46023_mobilecore_21Q1.diff [^] (784 bytes) 2021-03-10 16:20 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js b/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js
index 662a83fb..5fe4701d 100644
--- a/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js
+++ b/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js
@@ -97,6 +97,10 @@
      * @param {SynchronizationEndpoint} endpoint - A synchronization endpoint instance to be registered
      */
     registerEndpoint(endpoint) {
+      const exists = this.endpoints.findIndex(e => e.name === endpoint.name);
+      if (exists !== -1) {
+        this.endpoints.splice(exists, 1);
+      }
       this.endpoints.push(endpoint);
     }

46023_mobilecore_20Q4.diff [^] (784 bytes) 2021-03-10 16:20 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js b/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js
index 548899f5..bba1668b 100644
--- a/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js
+++ b/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js
@@ -85,6 +85,10 @@
      * @param {SynchronizationEndpoint} endpoint - A synchronization endpoint instance to be registered
      */
     registerEndpoint(endpoint) {
+      const exists = this.endpoints.findIndex(e => e.name === endpoint.name);
+      if (exists !== -1) {
+        this.endpoints.splice(exists, 1);
+      }
       this.endpoints.push(endpoint);
     }

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	feature request	0045634		closed	Retail	Reimplement printing infrastructure
depends on	backport	0046060	RR21Q1.1	closed	ranjith_qualiantech_com	Duplicate printing after partial cash up printing
depends on	backport	0046061	RR20Q4.3	closed	ranjith_qualiantech_com	Duplicate printing after partial cash up printing

Notes
(0126655) hgbot (developer) 2021-03-12 14:17	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/186 [^]

(0126683) hgbot (developer) 2021-03-15 07:36	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/186 [^]

(0126684) hgbot (developer) 2021-03-15 07:36	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 9961f8e4534b0b02fbaf20bcd46040b5a9eba809 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2021-03-15T10:30:24+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/9961f8e4534b0b02fbaf20bcd46040b5a9eba809 [^] Fixed ISSUE-46023: SyncBuffer Endpoint should override if already exists for same Endpoint name --- M web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js ---

Issue History
Date Modified	Username	Field	Change
2021-03-09 10:32	lbressan	New Issue
2021-03-09 10:32	lbressan	Assigned To	=> Retail
2021-03-09 10:32	lbressan	Resolution time	=> 1617141600
2021-03-09 10:32	lbressan	Triggers an Emergency Pack	=> No
2021-03-09 10:39	Practics	Issue Monitored: Practics
2021-03-09 11:28	lbressan	Priority	normal => high
2021-03-09 12:18	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2021-03-10 16:20	ranjith_qualiantech_com	File Added: 46023_mobilecore_21Q1.diff
2021-03-10 16:20	ranjith_qualiantech_com	File Added: 46023_mobilecore_20Q4.diff
2021-03-12 06:45	ranjith_qualiantech_com	Relationship added	related to 0045634
2021-03-12 07:58	marvintm	Status	new => scheduled
2021-03-12 08:06	marvintm	Regression level	=> Production - QA Approved
2021-03-12 08:06	marvintm	Regression date	=> 2021-08-04
2021-03-12 08:06	marvintm	Regression introduced in release	=> RR20Q4
2021-03-12 08:06	marvintm	Regression introduced by commit	=> https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/bf21ded351dca4fb3a7ea1b39f8b943b3a526d34 [^]
2021-03-12 14:17	hgbot	Note Added: 0126655
2021-03-15 07:36	hgbot	Resolution	open => fixed
2021-03-15 07:36	hgbot	Status	scheduled => closed
2021-03-15 07:36	hgbot	Note Added: 0126683
2021-03-15 07:36	hgbot	Fixed in Version	=> RR21Q2
2021-03-15 07:36	hgbot	Note Added: 0126684

Copyright © 2000 - 2009 MantisBT Group