Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0045935
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 02. Master data managementmajoralways2021-02-22 20:212021-03-22 07:50
ReporterlbressanView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionPR20Q4.1SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2020-01-21
Regression introduced in releasePR20Q3
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/26f6e9bb9fa009b1f9707ed4e64ba4a7f182497c [^]
Triggers an Emergency PackNo
Summary

0045935: Errors when migrating brands to product characteristics when upgrading to 20Q4.1

DescriptionWhen you want to migrate to the latest version of OB 20Q4.1, the Marks migration module script fails: "ConvertBrandIntoCharacteristic.java". Note that the environment does not have the "org.openbravo.retail.sampledata" module installed. Then the error message is as follows:
"[java] 52337 [main] ERROR org.openbravo.retail.posterminal.modulescript. ConvertBrandIntoCharacteristicData - SQL error in query: INSERT INTO m_characteristic( m_characteristic_id, ad_client_id, ad_org_id, isactive, created, createdby, updated, updatedby, name, description, ad_tree_id, isvariant, isexplodeconf, em_obpos_filteronwebpos, em_obpos_useonwebpos) VALUES (? , ?,'0', 'Y', now(), '100', now(), '100', 'Brand', null, '899D83A7B7E24F57911A91AE82DCA496','N', 'Y', 'Y', 'Y', 'Y') :org.postgresql.util.PSQLException: ERROR: insert or update on table "m_characteristic" violates foreign key "m_product_tree"
[java] Detail: key (ad_tree_id)=(899D83A7B7E24F57911A91AE82DCA496) is not present in table "ad_tree".
java] 52340 [main] ERROR org.openbravo.retail.posterminal.modulescript.ConvertBrandIntoCharacteristic - Errors converting brand into characteristic".

This is because the (ad_tree_id)=899D83A7B7E24F57911A91AE82DCA496) is inserted in the database when installing the module "org.openbravo.retail.sampledata" which is not a mandatory module when installing Retail in an environment.
Also note that if an environment does not have retail when upgrading to the new version of Openbravo, the brand window is no longer available, so you will not be able to add new brands and you will not be able to migrate brands to product characteristics, because the module script belongs to the retail module "org.openbravo.retail.posterminal".
Steps To Reproduce1. Note that you do not have the "org.openbravo.retail.sampledata" module installed.
2. Upgrading an OB environment to the latest version: note that you do not have the "org.openbravo.retail.sampledata" module installed.
3. Try to do the database update and the compile.

Expected behavior:
 a. The brand update module script should be outside of the retail module.

 b. The data used in the module script such as the ad_tree_id should be in a module that is always installed in the environment.
TagsNo tags attached.
Attached Filespng file icon grep.png [^] (34,222 bytes) 2021-02-22 20:21


diff file icon 45935 posterminal.diff [^] (5,083 bytes) 2021-03-17 06:06 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0046111PR21Q1.1 closedranjith_qualiantech_com Openbravo ERP Errors when migrating brands to product characteristics when upgrading to 20Q4.1 
depends on backport 0046112PR20Q4.3 closedranjith_qualiantech_com Openbravo ERP Errors when migrating brands to product characteristics when upgrading to 20Q4.1 
depends on backport 0046113PR20Q3.5 closedranjith_qualiantech_com Openbravo ERP Errors when migrating brands to product characteristics when upgrading to 20Q4.1 
related to defect 0053615 closedRajesh_18 Retail Modules Errors when migrating brands to product characteristics when upgrading to 23Q3 

-  Notes
(0126771)
lbressan (developer)
2021-03-18 14:35

Hi

Any update about this?

Regards
(0126803)
hgbot (developer)
2021-03-22 07:22

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/348 [^]
(0126805)
hgbot (developer)
2021-03-22 07:50

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/348 [^]
(0126806)
hgbot (developer)
2021-03-22 07:50

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 32f515e63812af97dac9b0a6671a5b0cbfa3977b
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-03-22T11:51:35+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/32f515e63812af97dac9b0a6671a5b0cbfa3977b [^]

Fixed ISSUE-45935: Updated Modulescript ConvertBrandIntoCharacteristic
* Update script ConvertBrandIntoCharacteristic to create ad_tree for brand characteristics

---
M build/classes/org/openbravo/retail/posterminal/modulescript/ConvertBrandIntoCharacteristic.class
M build/classes/org/openbravo/retail/posterminal/modulescript/ConvertBrandIntoCharacteristicData.class
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/ConvertBrandIntoCharacteristic.java
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/ConvertBrandIntoCharacteristic_data.xsql
---

- Issue History
Date Modified Username Field Change
2021-02-22 20:21 lbressan New Issue
2021-02-22 20:21 lbressan Assigned To => Triage Finance
2021-02-22 20:21 lbressan File Added: grep.png
2021-02-22 20:21 lbressan Modules => Core
2021-02-22 20:21 lbressan Resolution time => 1615158000
2021-02-22 20:21 lbressan Triggers an Emergency Pack => No
2021-02-23 09:33 dmiguelez Resolution time 1615158000 => 1615762800
2021-02-23 09:33 dmiguelez Description Updated View Revisions
2021-02-23 09:42 Practics Issue Monitored: Practics
2021-02-23 10:34 dmiguelez Assigned To Triage Finance => Retail
2021-03-08 10:11 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2021-03-17 06:06 ranjith_qualiantech_com File Added: 45935 posterminal.diff
2021-03-18 14:35 lbressan Note Added: 0126771
2021-03-22 06:58 marvintm Status new => scheduled
2021-03-22 07:03 marvintm Regression level => Production - Confirmed Stable
2021-03-22 07:03 marvintm Regression date => 2020-01-21
2021-03-22 07:03 marvintm Regression introduced in release => PR20Q3
2021-03-22 07:03 marvintm Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/26f6e9bb9fa009b1f9707ed4e64ba4a7f182497c [^]
2021-03-22 07:22 hgbot Note Added: 0126803
2021-03-22 07:50 hgbot Resolution open => fixed
2021-03-22 07:50 hgbot Status scheduled => closed
2021-03-22 07:50 hgbot Note Added: 0126805
2021-03-22 07:50 hgbot Fixed in Version => RR21Q2
2021-03-22 07:50 hgbot Note Added: 0126806
2023-10-06 22:11 axelmercado Relationship added related to 0053615


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker