0045935: Errors when migrating brands to product characteristics when upgrading to 20Q4.1

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0045935

Openbravo ERP

02. Master data management

public

2021-02-22 20:21

2021-03-22 07:50

Reporter

lbressan

Assigned To

ranjith_qualiantech_com

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

PR20Q4.1

Target Version

Fixed in Version

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Gold

Web browser

Modules

Core

Support ticket

21461

Regression level

Production - Confirmed Stable

Regression date

2020-01-21

Regression introduced in release

PR20Q3

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/26f6e9bb9fa009b1f9707ed4e64ba4a7f182497c [^]

Triggers an Emergency Pack

Summary

0045935: Errors when migrating brands to product characteristics when upgrading to 20Q4.1

Description

When you want to migrate to the latest version of OB 20Q4.1, the Marks migration module script fails: "ConvertBrandIntoCharacteristic.java". Note that the environment does not have the "org.openbravo.retail.sampledata" module installed. Then the error message is as follows:
"[java] 52337 [main] ERROR org.openbravo.retail.posterminal.modulescript. ConvertBrandIntoCharacteristicData - SQL error in query: INSERT INTO m_characteristic( m_characteristic_id, ad_client_id, ad_org_id, isactive, created, createdby, updated, updatedby, name, description, ad_tree_id, isvariant, isexplodeconf, em_obpos_filteronwebpos, em_obpos_useonwebpos) VALUES (? , ?,'0', 'Y', now(), '100', now(), '100', 'Brand', null, '899D83A7B7E24F57911A91AE82DCA496','N', 'Y', 'Y', 'Y', 'Y') :org.postgresql.util.PSQLException: ERROR: insert or update on table "m_characteristic" violates foreign key "m_product_tree"
[java] Detail: key (ad_tree_id)=(899D83A7B7E24F57911A91AE82DCA496) is not present in table "ad_tree".
java] 52340 [main] ERROR org.openbravo.retail.posterminal.modulescript.ConvertBrandIntoCharacteristic - Errors converting brand into characteristic".

This is because the (ad_tree_id)=899D83A7B7E24F57911A91AE82DCA496) is inserted in the database when installing the module "org.openbravo.retail.sampledata" which is not a mandatory module when installing Retail in an environment.
Also note that if an environment does not have retail when upgrading to the new version of Openbravo, the brand window is no longer available, so you will not be able to add new brands and you will not be able to migrate brands to product characteristics, because the module script belongs to the retail module "org.openbravo.retail.posterminal".

Steps To Reproduce

1. Note that you do not have the "org.openbravo.retail.sampledata" module installed.
2. Upgrading an OB environment to the latest version: note that you do not have the "org.openbravo.retail.sampledata" module installed.
3. Try to do the database update and the compile.

Expected behavior:
a. The brand update module script should be outside of the retail module.

b. The data used in the module script such as the ad_tree_id should be in a module that is always installed in the environment.

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

depends on	backport	0046111	PR21Q1.1	closed	ranjith_qualiantech_com	Openbravo ERP	Errors when migrating brands to product characteristics when upgrading to 20Q4.1
depends on	backport	0046112	PR20Q4.3	closed	ranjith_qualiantech_com	Openbravo ERP	Errors when migrating brands to product characteristics when upgrading to 20Q4.1
depends on	backport	0046113	PR20Q3.5	closed	ranjith_qualiantech_com	Openbravo ERP	Errors when migrating brands to product characteristics when upgrading to 20Q4.1
related to	defect	0053615		closed	Rajesh_18	Retail Modules	Errors when migrating brands to product characteristics when upgrading to 23Q3