Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0045935Openbravo ERP02. Master data managementpublic2021-02-22 20:212021-03-22 07:50
lbressan 
ranjith_qualiantech_com 
highmajoralways
closedfixed 
5
PR20Q4.1 
 
Core
Production - Confirmed Stable
2020-01-21
PR20Q3
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/26f6e9bb9fa009b1f9707ed4e64ba4a7f182497c [^]
No
0045935: Errors when migrating brands to product characteristics when upgrading to 20Q4.1
When you want to migrate to the latest version of OB 20Q4.1, the Marks migration module script fails: "ConvertBrandIntoCharacteristic.java". Note that the environment does not have the "org.openbravo.retail.sampledata" module installed. Then the error message is as follows:
"[java] 52337 [main] ERROR org.openbravo.retail.posterminal.modulescript. ConvertBrandIntoCharacteristicData - SQL error in query: INSERT INTO m_characteristic( m_characteristic_id, ad_client_id, ad_org_id, isactive, created, createdby, updated, updatedby, name, description, ad_tree_id, isvariant, isexplodeconf, em_obpos_filteronwebpos, em_obpos_useonwebpos) VALUES (? , ?,'0', 'Y', now(), '100', now(), '100', 'Brand', null, '899D83A7B7E24F57911A91AE82DCA496','N', 'Y', 'Y', 'Y', 'Y') :org.postgresql.util.PSQLException: ERROR: insert or update on table "m_characteristic" violates foreign key "m_product_tree"
[java] Detail: key (ad_tree_id)=(899D83A7B7E24F57911A91AE82DCA496) is not present in table "ad_tree".
java] 52340 [main] ERROR org.openbravo.retail.posterminal.modulescript.ConvertBrandIntoCharacteristic - Errors converting brand into characteristic".

This is because the (ad_tree_id)=899D83A7B7E24F57911A91AE82DCA496) is inserted in the database when installing the module "org.openbravo.retail.sampledata" which is not a mandatory module when installing Retail in an environment.
Also note that if an environment does not have retail when upgrading to the new version of Openbravo, the brand window is no longer available, so you will not be able to add new brands and you will not be able to migrate brands to product characteristics, because the module script belongs to the retail module "org.openbravo.retail.posterminal".
1. Note that you do not have the "org.openbravo.retail.sampledata" module installed.
2. Upgrading an OB environment to the latest version: note that you do not have the "org.openbravo.retail.sampledata" module installed.
3. Try to do the database update and the compile.

Expected behavior:
 a. The brand update module script should be outside of the retail module.

 b. The data used in the module script such as the ad_tree_id should be in a module that is always installed in the environment.
No tags attached.
depends on backport 0046111PR21Q1.1 closed ranjith_qualiantech_com Openbravo ERP Errors when migrating brands to product characteristics when upgrading to 20Q4.1 
depends on backport 0046112PR20Q4.3 closed ranjith_qualiantech_com Openbravo ERP Errors when migrating brands to product characteristics when upgrading to 20Q4.1 
depends on backport 0046113PR20Q3.5 closed ranjith_qualiantech_com Openbravo ERP Errors when migrating brands to product characteristics when upgrading to 20Q4.1 
related to defect 0053615 closed Rajesh_18 Retail Modules Errors when migrating brands to product characteristics when upgrading to 23Q3 
png grep.png (34,222) 2021-02-22 20:21
https://issues.openbravo.com/file_download.php?file_id=15337&type=bug
png

diff 45935 posterminal.diff (5,083) 2021-03-17 06:06
https://issues.openbravo.com/file_download.php?file_id=15436&type=bug
Issue History
2021-02-22 20:21lbressanNew Issue
2021-02-22 20:21lbressanAssigned To => Triage Finance
2021-02-22 20:21lbressanFile Added: grep.png
2021-02-22 20:21lbressanModules => Core
2021-02-22 20:21lbressanResolution time => 1615158000
2021-02-22 20:21lbressanTriggers an Emergency Pack => No
2021-02-23 09:33dmiguelezResolution time1615158000 => 1615762800
2021-02-23 09:33dmiguelezDescription Updatedbug_revision_view_page.php?rev_id=22140#r22140
2021-02-23 09:42PracticsIssue Monitored: Practics
2021-02-23 10:34dmiguelezAssigned ToTriage Finance => Retail
2021-03-08 10:11ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-03-17 06:06ranjith_qualiantech_comFile Added: 45935 posterminal.diff
2021-03-18 14:35lbressanNote Added: 0126771
2021-03-22 06:58marvintmStatusnew => scheduled
2021-03-22 07:03marvintmRegression level => Production - Confirmed Stable
2021-03-22 07:03marvintmRegression date => 2020-01-21
2021-03-22 07:03marvintmRegression introduced in release => PR20Q3
2021-03-22 07:03marvintmRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/26f6e9bb9fa009b1f9707ed4e64ba4a7f182497c [^]
2021-03-22 07:22hgbotNote Added: 0126803
2021-03-22 07:50hgbotResolutionopen => fixed
2021-03-22 07:50hgbotStatusscheduled => closed
2021-03-22 07:50hgbotNote Added: 0126805
2021-03-22 07:50hgbotFixed in Version => RR21Q2
2021-03-22 07:50hgbotNote Added: 0126806
2023-10-06 22:11axelmercadoRelationship addedrelated to 0053615

Notes
(0126771)
lbressan   
2021-03-18 14:35   
Hi

Any update about this?

Regards
(0126803)
hgbot   
2021-03-22 07:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/348 [^]
(0126805)
hgbot   
2021-03-22 07:50   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/348 [^]
(0126806)
hgbot   
2021-03-22 07:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 32f515e63812af97dac9b0a6671a5b0cbfa3977b
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-03-22T11:51:35+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/32f515e63812af97dac9b0a6671a5b0cbfa3977b [^]

Fixed ISSUE-45935: Updated Modulescript ConvertBrandIntoCharacteristic
* Update script ConvertBrandIntoCharacteristic to create ad_tree for brand characteristics

---
M build/classes/org/openbravo/retail/posterminal/modulescript/ConvertBrandIntoCharacteristic.class
M build/classes/org/openbravo/retail/posterminal/modulescript/ConvertBrandIntoCharacteristicData.class
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/ConvertBrandIntoCharacteristic.java
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/ConvertBrandIntoCharacteristic_data.xsql
---