Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045933
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2021-02-22 09:062021-02-22 18:55
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionopenFixed in Version
StatusnewFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045933: local storage obtains appName from OB.MobileApp

DescriptionAs explained in 0045932, OB.MobileApp shouldn't be used in Business Logic code. Local storage prepends application name to all entries, and it is currently being obtained from OB.MobileApp.
Steps To ReproduceSee: ob-localStorage.js [1]

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/82be6aa10e650227ab79c04de90eba66500fce4a/web/org.openbravo.mobile.core/source/utils/ob-localStorage.js#L17 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0045932 newRetail OB.MobileApp is used in Business Logic code 

-  Notes
(0126251)
hgbot (developer)
2021-02-22 09:11

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/167 [^]
(0126252)
hgbot (developer)
2021-02-22 09:59

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 21e1782f9b1af3659d1f7e6689ceaae235c621a9
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-02-22T09:57:51+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/21e1782f9b1af3659d1f7e6689ceaae235c621a9 [^]

fixed ISSUE-45933: local storage obtains appName from OB.MobileApp

Retrieve appName from terminal instead of OB.MobileApp.

Kept OB.MobileApp as fallback in case terminal is not defined.

---
M web/org.openbravo.mobile.core/source/utils/ob-localStorage.js
---
(0126253)
hgbot (developer)
2021-02-22 09:59

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/167 [^]
(0126278)
hgbot (developer)
2021-02-22 18:55

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 972299229cad19ab5456bdd6159be2543692ccf1
Author: Antonio Moreno <anmorenoperez@gmail.com>
Date: 2021-02-22T18:54:20+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/972299229cad19ab5456bdd6159be2543692ccf1 [^]

Related to ISSUE-45933. Rolled back change as it was affecting old POS

---
M web/org.openbravo.mobile.core/source/utils/ob-localStorage.js
---
(0126279)
shuehner (administrator)
2021-02-22 18:55

 Re-open issue as change was backed out (broke classic WebPOS login)

- Issue History
Date Modified Username Field Change
2021-02-22 09:06 alostale New Issue
2021-02-22 09:06 alostale Assigned To => Retail
2021-02-22 09:06 alostale Triggers an Emergency Pack => No
2021-02-22 09:07 alostale Relationship added blocks 0045932
2021-02-22 09:11 hgbot Note Added: 0126251
2021-02-22 09:59 hgbot Resolution open => fixed
2021-02-22 09:59 hgbot Status new => closed
2021-02-22 09:59 hgbot Fixed in Version => RR21Q2
2021-02-22 09:59 hgbot Note Added: 0126252
2021-02-22 09:59 hgbot Note Added: 0126253
2021-02-22 09:59 alostale Assigned To Retail => alostale
2021-02-22 18:55 hgbot Note Added: 0126278
2021-02-22 18:55 shuehner Note Added: 0126279
2021-02-22 18:55 shuehner Status closed => new
2021-02-22 18:55 shuehner Resolution fixed => open
2021-02-22 18:55 shuehner Fixed in Version RR21Q2 =>

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker