Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045933Retail ModulesWeb POSpublic2021-02-22 09:062021-02-22 18:55
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045933: local storage obtains appName from OB.MobileApp
DescriptionAs explained in 0045932, OB.MobileApp shouldn't be used in Business Logic code. Local storage prepends application name to all entries, and it is currently being obtained from OB.MobileApp.
Steps To ReproduceSee: ob-localStorage.js [1]

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/82be6aa10e650227ab79c04de90eba66500fce4a/web/org.openbravo.mobile.core/source/utils/ob-localStorage.js#L17 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0045932 new Retail OB.MobileApp is used in Business Logic code 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-02-22 09:06alostaleNew Issue
2021-02-22 09:06alostaleAssigned To => Retail
2021-02-22 09:06alostaleOBNetwork customer => No
2021-02-22 09:06alostaleTriggers an Emergency Pack => No
2021-02-22 09:07alostaleRelationship addedblocks 0045932
2021-02-22 09:11hgbotMerge Request Status => open
2021-02-22 09:11hgbotNote Added: 0126251
2021-02-22 09:58hgbotMerge Request Statusopen => approved
2021-02-22 09:59hgbotResolutionopen => fixed
2021-02-22 09:59hgbotStatusnew => closed
2021-02-22 09:59hgbotFixed in Version => RR21Q2
2021-02-22 09:59hgbotNote Added: 0126252
2021-02-22 09:59hgbotNote Added: 0126253
2021-02-22 09:59alostaleAssigned ToRetail => alostale
2021-02-22 18:55hgbotNote Added: 0126278
2021-02-22 18:55shuehnerNote Added: 0126279
2021-02-22 18:55shuehnerStatusclosed => new
2021-02-22 18:55shuehnerResolutionfixed => open
2021-02-22 18:55shuehnerFixed in VersionRR21Q2 =>

Notes
(0126251)
hgbot   
2021-02-22 09:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/167 [^]
(0126252)
hgbot   
2021-02-22 09:59   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 21e1782f9b1af3659d1f7e6689ceaae235c621a9
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-02-22T09:57:51+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/21e1782f9b1af3659d1f7e6689ceaae235c621a9 [^]

fixed ISSUE-45933: local storage obtains appName from OB.MobileApp

Retrieve appName from terminal instead of OB.MobileApp.

Kept OB.MobileApp as fallback in case terminal is not defined.

---
M web/org.openbravo.mobile.core/source/utils/ob-localStorage.js
---
(0126253)
hgbot   
2021-02-22 09:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/167 [^]
(0126278)
hgbot   
2021-02-22 18:55   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 972299229cad19ab5456bdd6159be2543692ccf1
Author: Antonio Moreno <anmorenoperez@gmail.com>
Date: 2021-02-22T18:54:20+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/972299229cad19ab5456bdd6159be2543692ccf1 [^]

Related to ISSUE-45933. Rolled back change as it was affecting old POS

---
M web/org.openbravo.mobile.core/source/utils/ob-localStorage.js
---
(0126279)
shuehner   
2021-02-22 18:55   
Re-open issue as change was backed out (broke classic WebPOS login)