Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045699
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2021-01-07 18:192021-01-12 11:37
ReporterucarrionView Statuspublic 
Assigned Torqueralta 
PriorityurgentResolutionfixedFixed in VersionRR21Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionRR19Q3.3SCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045699: There's an issue with the timezones when reprinting invoices

DescriptionThere's an issue with the timezones when reprinting invoices. The reprinted date is always the day before (one hour less 23:00:00)

The request done to the InvoicesHeader comes with the timezone of the server therefore it returns: 2020-01-07 00:00:00 +0000
It you are on a timezone (e.g.- gmt-1) the conversed date in the frot-end is 2020-01-06 23:00:00 -0100
Steps To ReproduceVideo: https://drive.google.com/file/d/1yjz6sMaZxNnPfrhaX84vi2UE1xNt1-Wk/view [^]

As Livebuilds is in UTC, put your laptop in UTC-1.
If you put it in UTC-X you will see that the returned our is 2020-01-07 00:00:00 -X hours

- Put your laptop at least in UTC-1
- Login on livebuilds (the test we've done is on 19Q3)
- Create an invoice
    Add a product
    Put a nominal customer
    Menu -> Invoice this receipt
    Pay
- Load the previously created ticket
- Menu -> Print this Receipt

You will notice the date shown in the popup is wrong

If you close the popup, open the developers tools, go to network tab and open the popup again you will see the request to InvoiceHeader that comes with the timezone.

Bear in mind that the printed date on the Invoice Receipt is wrong too.

Proposed SolutionorderDate from invoice header should not come with timezone as the value store in the database has not.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0125339)
hgbot (developer)
2021-01-08 15:45

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/248 [^]
(0125340)
hgbot (developer)
2021-01-08 17:42

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/248 [^]
(0125341)
hgbot (developer)
2021-01-08 17:42

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: de4eab251a81f2563d0d0b88b83b6beb1f40d500
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-01-07T17:53:21-05:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/de4eab251a81f2563d0d0b88b83b6beb1f40d500 [^]

Fixed BUG-45699: Added timezone offset

---
M web/org.openbravo.retail.posterminal/js/components/modalinvoices.js
---
(0125342)
guilleaer (viewer)
2021-01-11 08:24

 Executing when server are client are in the same timezone is not working.

OB.Utilities.Date.addTimezoneOffset(new Date("2021-01-05T00:00:00+01:00"))
Mon Jan 04 2021 23:00:00 GMT+0100 (Central European Standard Time)
(0125343)
hgbot (developer)
2021-01-11 08:25

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 0f8d037684b2e8b374d73a79eca31c4311ea08b5
Author: Guillermo Alvarez de Eulate <guillermo.alvarez@openbravo.com>
Date: 2021-01-11T07:25:17+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/0f8d037684b2e8b374d73a79eca31c4311ea08b5 [^]

Revert "Fixed BUG-45699: Added timezone offset"

This reverts commit de4eab251a81f2563d0d0b88b83b6beb1f40d500
---
M web/org.openbravo.retail.posterminal/js/components/modalinvoices.js
---
(0125351)
guillermogil (viewer)
2021-01-11 15:32

 Issue reopened as it has added a regression using the same timezone on the server and the frontend
(0125352)
hgbot (developer)
2021-01-11 21:58

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/250 [^]
(0125364)
hgbot (developer)
2021-01-12 11:37

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 3451bd2122a06bd0bcbe21f548a8b6b8ee47e293
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-01-12T10:37:40+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3451bd2122a06bd0bcbe21f548a8b6b8ee47e293 [^]

Fixed BUG-45699: Parsed orderDate value to server date timezone

---
M web/org.openbravo.retail.posterminal/js/components/modalinvoices.js
---
(0125365)
hgbot (developer)
2021-01-12 11:37

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/250 [^]

- Issue History
Date Modified Username Field Change
2021-01-07 18:19 ucarrion New Issue
2021-01-07 18:19 ucarrion Assigned To => Retail
2021-01-07 18:19 ucarrion OBNetwork customer => Gold
2021-01-07 18:19 ucarrion Resolution time => 1612134000
2021-01-07 18:19 ucarrion Triggers an Emergency Pack => No
2021-01-07 18:25 guillermogil Description Updated View Revisions
2021-01-07 23:52 rqueralta Assigned To Retail => rqueralta
2021-01-07 23:53 rqueralta Status new => scheduled
2021-01-08 07:16 guillermogil version => RR19Q3.3
2021-01-08 07:16 guillermogil Description Updated View Revisions
2021-01-08 07:16 guillermogil Steps to Reproduce Updated View Revisions
2021-01-08 07:16 guillermogil Proposed Solution updated
2021-01-08 15:45 hgbot Merge Request Status => open
2021-01-08 15:45 hgbot Note Added: 0125339
2021-01-08 17:42 hgbot Merge Request Status open => approved
2021-01-08 17:42 hgbot Resolution open => fixed
2021-01-08 17:42 hgbot Status scheduled => closed
2021-01-08 17:42 hgbot Note Added: 0125340
2021-01-08 17:42 hgbot Fixed in Version => RR21Q2
2021-01-08 17:42 hgbot Note Added: 0125341
2021-01-11 08:24 guilleaer Note Added: 0125342
2021-01-11 08:24 guilleaer Status closed => new
2021-01-11 08:24 guilleaer Resolution fixed => open
2021-01-11 08:24 guilleaer Fixed in Version RR21Q2 =>
2021-01-11 08:25 hgbot Resolution open => fixed
2021-01-11 08:25 hgbot Status new => closed
2021-01-11 08:25 hgbot Fixed in Version => RR21Q2
2021-01-11 08:25 hgbot Note Added: 0125343
2021-01-11 15:26 guillermogil Status closed => new
2021-01-11 15:26 guillermogil Resolution fixed => open
2021-01-11 15:26 guillermogil Fixed in Version RR21Q2 =>
2021-01-11 15:32 guillermogil Note Added: 0125351
2021-01-11 15:48 guillermogil Steps to Reproduce Updated View Revisions
2021-01-11 21:58 hgbot Note Added: 0125352
2021-01-12 11:37 hgbot Resolution open => fixed
2021-01-12 11:37 hgbot Status new => closed
2021-01-12 11:37 hgbot Fixed in Version => RR21Q2
2021-01-12 11:37 hgbot Note Added: 0125364
2021-01-12 11:37 hgbot Note Added: 0125365

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker