Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045649
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsminoralways2020-12-24 11:492020-12-31 13:36
Reporternicola_uvaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR21Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045649: Promotions are removed from paid ticket when a custom action is register on Ticket model

DescriptionPromotions are removed from paid ticket when a custom action is register on Ticket model.
Below the code to register an action

(function OBRCTDTicketDematModelDefinition() {
  OB.App.StateAPI.Ticket.registerAction(
    'showTicketDematPopup',
    (ticket, payload) => {
      const newTicket = { ...ticket };
      return newTicket;
    }
  );
})();

OB.App.StateAPI.Ticket.showTicketDematPopup.addPreHook(
  (globalState, payload) => {
   let newGlobalState = { ...globalState },
   return newGlobalState;
  }
);
Steps To Reproduce1)In the ERP configure a promotion with discount type "Variable Discount per Total Amount"
2) Register the action as explained in the description field
2) Login in the WEBPOS
3) Add a line to the receipt and apply to the promotions in (1)
4) Pay the ticket
5) Open the ticket paid
6) Invoke the action in the console of the browser using this code
 OB.App.State.Ticket.showTicketDematPopup()
7) the promotions is removed from the ticket
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0125155)
hgbot (developer)
2020-12-30 07:22

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/236 [^]
(0125156)
hgbot (developer)
2020-12-30 07:22

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/merge_requests/5 [^]
(0125229)
hgbot (developer)
2020-12-31 13:36

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 4c958258d9fc043b80f1aab377be5754a2520ac8
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-31T12:36:35+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/4c958258d9fc043b80f1aab377be5754a2520ac8 [^]

Fixed ISSUE-45649: Manual promotions should be generated when opening paid receipt

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/utils/ticketListUtils.js
---
(0125230)
hgbot (developer)
2020-12-31 13:36

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/236 [^]
(0125231)
hgbot (developer)
2020-12-31 13:36

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal [^]
Changeset: b620e43dc1f74953043a13d5c3237cf886b13ba8
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-28T14:29:35+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/commit/b620e43dc1f74953043a13d5c3237cf886b13ba8 [^]

Related to ISSUE-45649: Added identifier for By Total Promotions

---
M web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/manual-by-total-amount-discount.js
M web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/manual-by-total-percentage-discount.js
---
(0125232)
hgbot (developer)
2020-12-31 13:36

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/merge_requests/5 [^]

- Issue History
Date Modified Username Field Change
2020-12-24 11:49 nicola_uva New Issue
2020-12-24 11:49 nicola_uva Assigned To => Retail
2020-12-24 11:49 nicola_uva OBNetwork customer => Gold
2020-12-24 11:49 nicola_uva Resolution time => 1609801200
2020-12-24 11:49 nicola_uva Triggers an Emergency Pack => No
2020-12-24 13:06 nicola_uva Steps to Reproduce Updated View Revisions
2020-12-28 06:20 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2020-12-29 06:24 ranjith_qualiantech_com Status new => scheduled
2020-12-30 07:22 hgbot Merge Request Status => open
2020-12-30 07:22 hgbot Note Added: 0125155
2020-12-30 07:22 hgbot Note Added: 0125156
2020-12-31 13:36 hgbot Merge Request Status open => approved
2020-12-31 13:36 hgbot Resolution open => fixed
2020-12-31 13:36 hgbot Status scheduled => closed
2020-12-31 13:36 hgbot Fixed in Version => RR21Q1
2020-12-31 13:36 hgbot Note Added: 0125229
2020-12-31 13:36 hgbot Note Added: 0125230
2020-12-31 13:36 hgbot Note Added: 0125231
2020-12-31 13:36 hgbot Note Added: 0125232

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker