Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0045617

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

backport

[Retail Modules] Web POS

critical

always

2020-12-15 18:37

2020-12-18 06:46

Reporter

guillermogil

View Status

public

Assigned To

prakashmurugesan88

Priority

immediate

Resolution

fixed

Fixed in Version

RR20Q4.1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

RR20Q4.2

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

RR19Q3.3

SCM revision

Review Assigned To

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0045617: Not possible to click several buttons after an addProduct

Description

Not possible to click several buttons after an addProduct.
There are several exceptions in the code that avoid to finish the addProdct functionality but the ProcessController is never closed.

e.g.-
in _addProduct:

                  if (OB.MobileApp.model.get('inPaymentTab')) {
                    if (args.options && args.options.blockAddProduct) {
                      OB.error(
                        'An add product is executed. At this point, this action is not allowed. Skipping product ' +
                          p.get('_identifier')
                      );
                      if (args && args.attrs && args.attrs.obposEpccode) {
                        OB.UTIL.RfidController.removeEpc(
                          args.attrs.obposEpccode
                        );
                      }
                      return;
                    }
                  }
That returns breaks the flow as it is not executing the finalCallback.
There are several other cases across the code.

The code is still the same on PI although it is on the legacy function. Releases <20Q4 will have this issue in the case exposed.

Steps To Reproduce

Do an addProduct in the payment tab
ProcessController starts
Log is raised: An add product is executed. At this point, this action is not allowed. Skipping product
Process controller is never finished

After that you get the 120s timeout from the ProcessController
Buttons are deactivated forever

Proposed Solution

Return the callback on the _addProduct with the success as false

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

closed

prakashmurugesan88

Not possible to click several buttons after an addProduct

Notes
(0124896) hgbot (developer) 2020-12-17 10:49	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/222 [^]

(0124909) hgbot (developer) 2020-12-18 06:46	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 4cfd34225092a3e4071b743a5abf43662f251200 Author: Prakash M <prakash@qualiantech.com> Date: 2020-12-18T05:46:44+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/4cfd34225092a3e4071b743a5abf43662f251200 [^] Fixed BUG-45617: Fixes process timeout when error raised in addProduct * Added callback with success as false to handle process completion --- M web/org.openbravo.retail.posterminal/js/model/order.js ---

(0124910) hgbot (developer) 2020-12-18 06:46	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/222 [^]

Issue History
Date Modified	Username	Field	Change
2020-12-17 10:38	prakashmurugesan88	Type	defect => backport
2020-12-17 10:38	prakashmurugesan88	Target Version	=> RR20Q4.2
2020-12-17 10:49	hgbot	Note Added: 0124896
2020-12-18 06:46	hgbot	Resolution	open => fixed
2020-12-18 06:46	hgbot	Status	scheduled => closed
2020-12-18 06:46	hgbot	Fixed in Version	=> RR20Q4.1
2020-12-18 06:46	hgbot	Note Added: 0124909
2020-12-18 06:46	hgbot	Note Added: 0124910

Copyright © 2000 - 2009 MantisBT Group