0045525: [SafeBox - Cashup] During processing the cashup an error happen on ProcessCashClose

Description

During the execution of ProcessCashClose.java a hibernate error happen. Below the piece of code failing

    if (jsonCashup.has("currentSafeBox")) {
        String safeBoxSK = jsonCashup.getString("currentSafeBox");
        OBCriteria<OBPOSSafeBox> safeBoxCriteria = OBDal.getInstance()
            .createCriteria(OBPOSSafeBox.class);
        safeBoxCriteria.add(Restrictions.eq(OBPOSSafeBox.PROPERTY_SEARCHKEY, safeBoxSK));

        safeBox = (OBPOSSafeBox) safeBoxCriteria.uniqueResult();
      }

Steps To Reproduce

Create a safebox with search key = 1 for organization A with cash payment method
Create a safebox with search key = 1 for organization B with cash payment method
Connect to POS on organization A
Link the safebox 1 and do a ticket in cash
Remove the safebox from the menu and process

The cashup go in error while importing POS data with the following error:
org.hibernate.NonUniqueResultException: query did not return a unique result: 2

Proposed Solution

Put the unicity on (Organization, searchkey) level
We also need to ensure that safe boxes are created at store level, otherwise more than one safe box may be visible if we only do the constraint change

Tags

No tags attached.

Attached Files

errorlog.txt [^] (1,674 bytes) 2020-11-27 13:42 [Show Content] [Hide Content]

org.hibernate.NonUniqueResultException: query did not return a unique result: 2
	at org.hibernate.query.internal.AbstractProducedQuery.uniqueElement(AbstractProducedQuery.java:1596)
	at org.hibernate.internal.CriteriaImpl.uniqueResult(CriteriaImpl.java:392)
	at org.openbravo.dal.service.OBCriteria.uniqueResult(OBCriteria.java:172)
	at org.openbravo.retail.posterminal.ProcessCashClose.saveRecord(ProcessCashClose.java:106)
	at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:201)
	at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:156)
	at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:88)
	at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:54)
	at org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable.processEntry(CashUpImportEntryProcessor.java:80)
	at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:372)
	at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:293)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

Relationships [ Relation Graph ] [ Dependency Graph ]

caused by

defect

0045157

closed

jorge-garcia

[SafeBox] Same search key can't be used on different Organization

Notes
(0124812) hgbot (developer) 2020-12-14 20:59	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/211 [^]

(0124818) hgbot (developer) 2020-12-15 08:17	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 1a790b02ddf6c29d1ed7d6638f4b7b54969bf9b7 Author: Rafael Queralta <rafaelcuba81@gmail.com> Date: 2020-12-15T07:17:12+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1a790b02ddf6c29d1ed7d6638f4b7b54969bf9b7 [^] Fixed BUG-45525: Added filter by organization to retrieve an unique safe box --- M src/org/openbravo/retail/posterminal/ProcessCashClose.java ---

(0124819) hgbot (developer) 2020-12-15 08:17	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/211 [^]

Issue History
Date Modified	Username	Field	Change
2020-11-27 13:42	nicola_uva	New Issue
2020-11-27 13:42	nicola_uva	Assigned To	=> Retail
2020-11-27 13:42	nicola_uva	File Added: errorlog.txt
2020-11-27 13:42	nicola_uva	Resolution time	=> 1606863600
2020-11-27 13:42	nicola_uva	Triggers an Emergency Pack	=> No
2020-11-27 13:54	javietxe	Issue Monitored: javietxe
2020-11-27 13:55	javietxe	Resolution time	1606863600 => 1608246000
2020-11-27 13:56	javietxe	Regression introduced in release	=> pi
2020-11-27 13:57	javietxe	Relationship added	caused by 0045157
2020-12-09 17:02	rqueralta	Assigned To	Retail => rqueralta
2020-12-14 20:59	hgbot	Note Added: 0124812
2020-12-15 08:17	hgbot	Resolution	open => fixed
2020-12-15 08:17	hgbot	Status	new => closed
2020-12-15 08:17	hgbot	Fixed in Version	=> RR21Q1
2020-12-15 08:17	hgbot	Note Added: 0124818
2020-12-15 08:17	hgbot	Note Added: 0124819