Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0045514 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | major | have not tried | 2020-11-05 15:52 | 2020-11-27 07:25 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR20Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | PR20Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0045514: Cannot run and create.database twice against AWS RDS database: ERROR: must be owner of database openbravo | |||||||
| Description | Using Amazon RDS postgres variant running ant create.database a second time fails with error /opt/OpenbravoERP/src-db/database/build-create.xml:104: org.postgresql.util.PSQLException: ERROR: must be owner of database openbravo Cause is the 'postgres' aka masteruser from RDS with role rds_superuser does not allow 'drop database' if a database not owned by this user. That is different behavior from 'postgres' superuser in standard PostgreSQL which allows doing that. | |||||||
| Steps To Reproduce | Create Amazon RDS environment (i.e. v12) configure Openbravo.properties: - bbdd.url to point to 'endpoint' for RDS instance - user + userPassword i.e. tad/tad (not important) - systemUser = <username of masteruser on RDS creation> - systemPassword = <password of masteruser> ant create.database (first time) ant create.database (2nd time) Observe the permissions error on 2nd run when the 'drop database openbravo' SQL command is executed. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0124631) hgbot (developer) 2020-11-26 13:33 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/247 [^] |
|
(0124640) hgbot (developer) 2020-11-27 07:25 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/247 [^] |
|
(0124641) hgbot (developer) 2020-11-27 07:25 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 83c2b1f5a1c93d9a3f1e6186ce4970a0d29feb3b Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2020-11-26T13:25:05+01:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/83c2b1f5a1c93d9a3f1e6186ce4970a0d29feb3b [^] Fixes ISSUE-45514: Fix repeated create.database error with RDS Amazon RDS (managed postgres) behaves different with regards of permissions for 'DROP DATABASE' run by a user which is not the owner of the database: The 'ant create.database' command does DROP the configured database (if it exists) before creating it again (to allow to run the command repeatedly). That 'DROP DATABASE' is run with the configured bbdd.systemUser which is typically the PostgreSQL superuser. Standard PostgreSQL allows the database superuser (typically called postgres) to drop any database (also if those are owned by different users like 'tad' Amazon RDS has a masteruser (with rds_admin role granted) which is the equivalent of the postgres superuser but which is not allowed to DROP databases not owned by itself (but it is allowed to take over ownership of any databasE) To make that work transparently for the user take over the ownership of the database just before the 'DROP DATABASE' command to avoid that permission error. The 'ALTER DATABASE' command does not have an option 'IF EXISTS' so to not make it fail in the first use of 'ant create.database' where the database does not yet exist check for the database to exist before running the command with an plpgsql DO block. As the database is being DROPped right after the ownership change does not have any permanent side-effect. Do avoid the database owner being change permanently run the ALTER command in the same transaction as the DROP command. That avoid the different owner leaking in case of the DROP failing (i.e. when 1 common user is used to create several databases as it is used ometimes on some developer systems) --- M src-db/database/build-create.xml --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-11-25 18:23 | shuehner | Type | design defect => backport |
| 2020-11-25 18:23 | shuehner | Target Version | PR21Q1 => PR20Q4 |
| 2020-11-26 13:33 | hgbot | Merge Request Status | => open |
| 2020-11-26 13:33 | hgbot | Note Added: 0124631 | |
| 2020-11-27 07:25 | hgbot | Merge Request Status | open => approved |
| 2020-11-27 07:25 | hgbot | Note Added: 0124640 | |
| 2020-11-27 07:25 | hgbot | Resolution | open => fixed |
| 2020-11-27 07:25 | hgbot | Status | scheduled => closed |
| 2020-11-27 07:25 | hgbot | Fixed in Version | => PR20Q4 |
| 2020-11-27 07:25 | hgbot | Note Added: 0124641 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |