Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0045501 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Loyalty Programs for Web POS | major | always | 2020-11-24 19:55 | 2020-12-21 06:52 | |||
| Reporter | collazoandy4 | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0045501: Loyalty subscription is updated if it set as active = false after loaded from backend with a custom code | |||||||
| Description | When a customer is subscribed to a loyalty program and the subscription have a custom status (finalize) that invalidated it (active = false) in the frontend, the customer can subscribe to the same loyalty program again and a new subscription is created in the frontend, when this new subscription is synchronized the one with finalize status is updated to the default program status (new) and the Loyalty Subscription Details popup can show the category value because the updated subscription is not replaced by the one created in the save process and could not be found after search by id | |||||||
| Steps To Reproduce | - Enable the Loyalty Program for YS-11 pos terminal in the backend - Search for Carl Studson business partner and add a new subscription for the created program - Check in backend in Subscription tab that a new record exists and update the subscription status to a different one - Set a breakpoint at the end (before calling the callback) in successCallback function of OBRLP.findSubscriptions function - Open the customer subscription popup and create a new one - Set isactive property as false in the breakpoint (subscriptions[0].isactive = false) - Check you can subscribe the customer to the same loyalty program - Add a new subscription to the business partner and check in backend the subscription is updated to the default loyalty program status and the Loyalty Program Details popup have the category as undefined | |||||||
| Proposed Solution | Return the subscription updated when is synchronized to the backend | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0125012) hgbot (developer) 2020-12-21 05:27 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/14 [^] |
|
(0125013) hgbot (developer) 2020-12-21 06:52 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^] Changeset: 0a8c354ea35b92dfb889f805c5cc2b493086cde9 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2020-12-21T09:57:08+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/0a8c354ea35b92dfb889f805c5cc2b493086cde9 [^] Fixed ISSUE-45501: Added Active property for loyalty subscription * When Subscription saving process in failed, in polling handler, isactive property of subscription should be updated as false * For all the places, only active subscription should be listed --- M src/org/openbravo/retail/loyalty/programs/process/GetSubscriptionInformationPollingHandler.java M web/org.openbravo.retail.loyalty.programs/app/model/masterdata/LoyaltySubscriptionsModel.js M web/org.openbravo.retail.loyalty.programs/js/component/program-selection-popup.js M web/org.openbravo.retail.loyalty.programs/js/component/subscription-icon.js M web/org.openbravo.retail.loyalty.programs/js/hooks/obrlp_postBarcodeAction.js M web/org.openbravo.retail.loyalty.programs/js/utils/obrlputils.js M web/org.openbravo.retail.loyalty.programs/js/view/addpoints-popup.js M web/org.openbravo.retail.loyalty.programs/js/view/customeredit-fields.js M web/org.openbravo.retail.loyalty.programs/js/view/manageLoyalty.js M web/org.openbravo.retail.loyalty.programs/js/view/subscription-create-form.js --- |
|
(0125014) hgbot (developer) 2020-12-21 06:52 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/14 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-11-24 19:55 | collazoandy4 | New Issue | |
| 2020-11-24 19:55 | collazoandy4 | Assigned To | => Retail |
| 2020-11-24 19:55 | collazoandy4 | Resolution time | => 1604790000 |
| 2020-11-24 19:55 | collazoandy4 | Triggers an Emergency Pack | => No |
| 2020-11-25 09:59 | marvintm | Resolution time | 1604790000 => 1607382000 |
| 2020-11-30 07:20 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2020-12-09 07:32 | ranjith_qualiantech_com | Status | new => scheduled |
| 2020-12-21 05:27 | hgbot | Note Added: 0125012 | |
| 2020-12-21 06:52 | hgbot | Resolution | open => fixed |
| 2020-12-21 06:52 | hgbot | Status | scheduled => closed |
| 2020-12-21 06:52 | hgbot | Note Added: 0125013 | |
| 2020-12-21 06:52 | hgbot | Note Added: 0125014 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |