Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0045484 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | minor | always | 2020-11-23 17:01 | 2021-01-15 12:00 | |||
| Reporter | lorenzofidalgo | View Status | public | |||||
| Assigned To | guilleaer | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | guilleaer | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0045484: Focusing products through TAB key creates an inconsistent status in the product lines | |||||||
| Description | When a product line is focused using the TAB key, a swipe left gesture seems to be invoked. The lines stay as "swiped" left (check attached image). | |||||||
| Steps To Reproduce | 0-Login POS as Vallblanca. 1-Add several different products at the current receipt. 2-Press TAB key until the products focused. DEFECT: Realise a swipe left action seems to be performed and the products stay that way even when the TAB key is no longer focusing the products. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  TAB.png [^] (70,373 bytes) 2020-11-23 17:01
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0124716) hgbot (developer) 2020-12-04 15:52 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/179 [^] |
|
(0124717) hgbot (developer) 2020-12-04 15:59 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/128 [^] |
|
(0124779) hgbot (developer) 2020-12-10 17:38 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/179 [^] |
|
(0124780) hgbot (developer) 2020-12-10 17:38 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 02809dab220268921fcd0750308e3e0c6a146259 Author: Angel Eduardo <angel.gonzalez@smfconsulting.com> Date: 2020-12-10T17:29:21+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/02809dab220268921fcd0750308e3e0c6a146259 [^] [Issue 45484] * Adding tabIndex prop to BaseButton and story to verify it. * Adding containerProperties prop to BaseGridLayout in order to allow the developer to inject HTML properties into to the main container. Also checked in the story. * Added onKeyPress handler to middle container on BaseSwipeableLine to emulate the click when the user presses the enter button on the selected line. * Included containerProperties on ConfigurableLayout's BaseGridLayout. --- M web-jspack/org.openbravo.core2/src/components/BaseButton/BaseButton.jsx M web-jspack/org.openbravo.core2/src/components/BaseButton/stories/BaseButton.stories.jsx M web-jspack/org.openbravo.core2/src/components/BaseGridLayout/BaseGridLayout.jsx M web-jspack/org.openbravo.core2/src/components/BaseGridLayout/stories/BaseGridLayout.stories.jsx M web-jspack/org.openbravo.core2/src/components/ConfigSwipeableLine/BaseSwipeableLine.jsx M web-jspack/org.openbravo.core2/src/components/ConfigurableLayout/ConfigurableLayout.jsx --- |
|
(0124781) hgbot (developer) 2020-12-10 17:38 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 951385bda72cc25ea0079b99090e506459b5264b Author: Angel Eduardo <angel.gonzalez@smfconsulting.com> Date: 2020-12-10T17:29:21+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/951385bda72cc25ea0079b99090e506459b5264b [^] [Issue 45484] * Removing unnecessary constant (mainContainerProperties) on BaseGridLayout. * Removing unnecessary optional chaining operator from BaseSwipeableLine. --- M web-jspack/org.openbravo.core2/src/components/BaseGridLayout/BaseGridLayout.jsx M web-jspack/org.openbravo.core2/src/components/ConfigSwipeableLine/BaseSwipeableLine.jsx --- |
|
(0124782) hgbot (developer) 2020-12-10 17:38 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: faa39152468541c260d0813e91fb1173504ff2bf Author: Angel Eduardo <angel.gonzalez@smfconsulting.com> Date: 2020-12-10T17:30:58+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/faa39152468541c260d0813e91fb1173504ff2bf [^] [Issue 45484] * Adding tabIndex prop to BaseButton and story to verify it. * Adding containerProperties prop to BaseGridLayout in order to allow the developer to inject HTML properties into to the main container. Also checked in the story. * Added onKeyPress handler to middle container on BaseSwipeableLine to emulate the click when the user presses the enter button on the selected line. * Included containerProperties on ConfigurableLayout's BaseGridLayout. --- M web-jspack/org.openbravo.core2/src/components/BaseGridLayout/BaseGridLayout.jsx --- |
|
(0124783) hgbot (developer) 2020-12-10 17:38 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: a3be7073696260ed18b6b05db8cc484828eceee6 Author: Angel Eduardo <angel.gonzalez@smfconsulting.com> Date: 2020-12-10T17:32:16+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a3be7073696260ed18b6b05db8cc484828eceee6 [^] [Issue 45484] Adding tabIndex as a property of BaseSwipeableLine and removing containerProperties --- M web-jspack/org.openbravo.core2/src/components/BaseGridLayout/BaseGridLayout.jsx M web-jspack/org.openbravo.core2/src/components/BaseGridLayout/stories/BaseGridLayout.stories.jsx M web-jspack/org.openbravo.core2/src/components/ConfigSwipeableLine/BaseSwipeableLine.jsx M web-jspack/org.openbravo.core2/src/components/ConfigSwipeableLine/ConfigSwipeableLine.jsx --- |
|
(0124784) hgbot (developer) 2020-12-10 17:39 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 82c02b9bb8e8b47511c6f2da94bf603d3449d068 Author: Angel Eduardo <angel.gonzalez@smfconsulting.com> Date: 2020-12-10T17:32:43+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/82c02b9bb8e8b47511c6f2da94bf603d3449d068 [^] [Issue 45484] Removing tabIndex to left component of ticket line swipeable (delete button) and adding it to the middle component directly. --- M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLine.config.json M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLine.swipeable.config.json --- |
|
(0124785) hgbot (developer) 2020-12-10 17:39 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 245c4ccae54d19218100711bb3102e8e3f0a13a5 Author: Angel Eduardo <angel.gonzalez@smfconsulting.com> Date: 2020-12-10T17:32:43+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/245c4ccae54d19218100711bb3102e8e3f0a13a5 [^] [Issue 45484] Removes unnecessary role property from ticket line. --- M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLine.config.json --- |
|
(0124786) hgbot (developer) 2020-12-10 17:39 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 3c28c0309c63807afa7f06de09253c313a2fa976 Author: Angel Eduardo <angel.gonzalez@smfconsulting.com> Date: 2020-12-10T17:32:43+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3c28c0309c63807afa7f06de09253c313a2fa976 [^] [Issue 45484] Remove containerProperties because the swipeable line already has tabIndex on zero --- M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLine.config.json --- |
|
(0124787) hgbot (developer) 2020-12-10 17:39 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/128 [^] |
|
(0124788) hgbot (developer) 2020-12-10 17:39 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 7af33b63d359bcbd7a4fa6d60dbb2d79221eaaa9 Author: Angel Eduardo <angel.gonzalez@smfconsulting.com> Date: 2020-12-10T17:32:43+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7af33b63d359bcbd7a4fa6d60dbb2d79221eaaa9 [^] [Issue 45484] Adding tabIndex to the Swipeable line directly --- M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLine.swipeable.config.json --- |
|
(0124801) hgbot (developer) 2020-12-11 14:52 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: a3be7073696260ed18b6b05db8cc484828eceee6 Author: Angel Eduardo <angel.gonzalez@smfconsulting.com> Date: 2020-12-10T17:32:16+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a3be7073696260ed18b6b05db8cc484828eceee6 [^] [Issue 45484] Adding tabIndex as a property of BaseSwipeableLine and removing containerProperties --- M web-jspack/org.openbravo.core2/src/components/BaseGridLayout/BaseGridLayout.jsx M web-jspack/org.openbravo.core2/src/components/BaseGridLayout/stories/BaseGridLayout.stories.jsx M web-jspack/org.openbravo.core2/src/components/ConfigSwipeableLine/BaseSwipeableLine.jsx M web-jspack/org.openbravo.core2/src/components/ConfigSwipeableLine/ConfigSwipeableLine.jsx --- |
|
(0125481) guilleaer (manager) 2021-01-15 12:00 |
Resolved By new POS team |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-11-23 17:01 | lorenzofidalgo | New Issue | |
| 2020-11-23 17:01 | lorenzofidalgo | Assigned To | => Retail |
| 2020-11-23 17:01 | lorenzofidalgo | File Added: TAB.png | |
| 2020-11-23 17:01 | lorenzofidalgo | Triggers an Emergency Pack | => No |
| 2020-12-04 15:52 | hgbot | Note Added: 0124716 | |
| 2020-12-04 15:59 | hgbot | Note Added: 0124717 | |
| 2020-12-10 17:38 | hgbot | Note Added: 0124779 | |
| 2020-12-10 17:38 | hgbot | Note Added: 0124780 | |
| 2020-12-10 17:38 | hgbot | Note Added: 0124781 | |
| 2020-12-10 17:38 | hgbot | Note Added: 0124782 | |
| 2020-12-10 17:38 | hgbot | Note Added: 0124783 | |
| 2020-12-10 17:39 | hgbot | Note Added: 0124784 | |
| 2020-12-10 17:39 | hgbot | Note Added: 0124785 | |
| 2020-12-10 17:39 | hgbot | Note Added: 0124786 | |
| 2020-12-10 17:39 | hgbot | Note Added: 0124787 | |
| 2020-12-10 17:39 | hgbot | Note Added: 0124788 | |
| 2020-12-11 14:52 | hgbot | Note Added: 0124801 | |
| 2021-01-15 12:00 | guilleaer | Status | new => scheduled |
| 2021-01-15 12:00 | guilleaer | Assigned To | Retail => guilleaer |
| 2021-01-15 12:00 | guilleaer | Note Added: 0125481 | |
| 2021-01-15 12:00 | guilleaer | Status | scheduled => resolved |
| 2021-01-15 12:00 | guilleaer | Resolution | open => fixed |
| 2021-01-15 12:00 | guilleaer | Review Assigned To | => guilleaer |
| 2021-01-15 12:00 | guilleaer | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |