Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0045360 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | have not tried | 2020-11-02 18:30 | 2020-11-16 06:48 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR21Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0045360: Problem on bom taxes calculation if an adjustment is required | |||||||
| Description | When calculating the line BOM taxes, there will be an error if an adjustment has to be done. This line will be executed [1] and it will fail because the OB.DEC.add function requires two arguments. [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js#L112 [^] | |||||||
| Steps To Reproduce | I have not been able to reproduce it in standard retail, but the error is evident enough in line https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js#L112 [^] | |||||||
| Proposed Solution | Just replace bomGroup.amount = OB.DEC.add(bomGroup.amount); with bomGroup.amount = OB.DEC.add(adjustment, bomGroup.amount); | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0124249) hgbot (developer) 2020-11-10 04:11 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/162 [^] |
|
(0124379) hgbot (developer) 2020-11-16 06:48 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 1b50771c2c26a4bcfbbc09bc0a9865c7fab358aa Author: Ranjith S R <ranjith@qualiantech.com> Date: 2020-11-16T05:48:26+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1b50771c2c26a4bcfbbc09bc0a9865c7fab358aa [^] Fixed ISSUE-45360: Adding missing param in BOM Tax amount calculation --- M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js --- |
|
(0124380) hgbot (developer) 2020-11-16 06:48 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/162 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-11-02 18:30 | AugustoMauch | New Issue | |
| 2020-11-02 18:30 | AugustoMauch | Assigned To | => Retail |
| 2020-11-02 18:30 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2020-11-09 06:54 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2020-11-10 04:11 | hgbot | Note Added: 0124249 | |
| 2020-11-11 05:09 | ranjith_qualiantech_com | Status | new => scheduled |
| 2020-11-16 06:48 | hgbot | Resolution | open => fixed |
| 2020-11-16 06:48 | hgbot | Status | scheduled => closed |
| 2020-11-16 06:48 | hgbot | Fixed in Version | => RR21Q1 |
| 2020-11-16 06:48 | hgbot | Note Added: 0124379 | |
| 2020-11-16 06:48 | hgbot | Note Added: 0124380 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |