Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0045324
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POScriticalalways2020-06-30 13:252020-10-30 08:08
ReportermarvintmView Statuspublic 
Assigned Toprakashmurugesan88 
PrioritynormalResolutionfixedFixed in VersionRR20Q3.2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR20Q3.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045324: Updating the "issummarylevel" property of a product category can lead to inconsistent data

DescriptionThe WebPOS loads the product category information by reading from the obretco_product_category table, which is updated using an EventHandler. This table is supposed to contain only non summary categories.

However, if a category is initially defined as non summary level and then it is changed to be summary, the record is not removed from OBRETCO_product_category, and this is not taken into account in the filter in the corresponding masterdata query, so the category ends up being loaded twice.

If the opposite happens, and the category is initially summary and changed to be non summary, then the record is not added, so the category is not loaded in the WebPOS.
Steps To ReproduceCreate a product category as non-summary level.
Verify that it is automatically added to the tab "Filter product categories" from the Assortments.
Change it to be summary.
Realise it is not removed from the Assortment.
Do a full refresh in the WebPOS. Check that the category is loaded twice in the request.
Proposed SolutionEither we change the eventhandler to take this case into account, or we change the masterdata queries to take it, to ensure that categories are always loaded when they need to be, and never twice.

See diff attached for the update on the m_product. it is still needed to create an eventhadler to ensure the case of isSummary from N to Y
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0044515 closedprakashmurugesan88 Updating the "issummarylevel" property of a product category can lead to inconsistent data 

-  Notes
(0123987)
hgbot (developer)
2020-10-29 06:53

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/139 [^]
(0124040)
hgbot (developer)
2020-10-30 08:08

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/139 [^]
(0124041)
hgbot (developer)
2020-10-30 08:08

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 38e477896865fdda6ac7ff7827397e4ba506c626
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-10-29T11:12:46+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/38e477896865fdda6ac7ff7827397e4ba506c626 [^]

Fixed BUG-45324 : Product Category is inserted to assortment even if issummarylevel is true
* This causes inconsistent data in webpos
* Validated issummarylevel='N' before inserting into assortment
* Added event handler to add or remove product category from assortment based on issummarylevel property

---
A src/org/openbravo/retail/posterminal/event/ProductCategoryEventHandler.java
M src/org/openbravo/retail/posterminal/UpdateProductCategoryByAssortmentBackground.java
M src/org/openbravo/retail/posterminal/event/ProductListEventHandler.java
---

- Issue History
Date Modified Username Field Change
2020-10-28 16:59 marvintm Type defect => backport
2020-10-28 16:59 marvintm Target Version => RR20Q3.2
2020-10-29 06:53 hgbot Note Added: 0123987
2020-10-30 08:08 hgbot Resolution open => fixed
2020-10-30 08:08 hgbot Status scheduled => closed
2020-10-30 08:08 hgbot Note Added: 0124040
2020-10-30 08:08 hgbot Fixed in Version => RR20Q3.2
2020-10-30 08:08 hgbot Note Added: 0124041


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker