Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0045217

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] Y. DBSourceManager

minor

have not tried

2020-10-14 08:48

2020-10-23 09:56

Reporter

alostale

View Status

public

Assigned To

alostale

Priority

normal

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0045217: org.openbravo.dbsm.test.model.Functions.invalidFunctionIsIgnored fails in cli

Description

When DBSM org.openbravo.dbsm.test.model.Functions.invalidFunctionIsIgnored() test is executed from cli it fails.

Note it works fine when executed from eclipse.

Steps To Reproduce

1. Execute org.openbravo.dbsm.test.model.Functions.invalidFunctionIsIgnored() from eclipse
  -> It works fine

2. Execute ant run.tests
ERROR:
    [junit] Testcase: invalidFunctionIsIgnored[DB: pg-10] took 0.024 sec
    [junit] FAILED
    [junit]
    [junit] Expected: not an empty collection
    [junit] but: was <[]>
    [junit] junit.framework.AssertionFailedError:
    [junit] Expected: not an empty collection
    [junit] but: was <[]>
    [junit] at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
    [junit] at org.openbravo.dbsm.test.model.Functions.invalidFunctionIsIgnored(Functions.java:105)

Proposed Solution

It might be related to incorrect TestLogAppender configuration when it's run in cli.

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0045216		closed	alostale	dbsm tests have hardcoded super user
related to	feature request	0045222		closed	alostale	execute single dbsm test

Notes
(0123787) hgbot (developer) 2020-10-20 07:44	Merge Request created: https://gitlab.com/openbravo/product/dbsm/-/merge_requests/17 [^]

(0123900) hgbot (developer) 2020-10-23 09:56	Merge request merged: https://gitlab.com/openbravo/product/dbsm/-/merge_requests/17 [^]

(0123901) hgbot (developer) 2020-10-23 09:56	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/dbsm [^] Changeset: 9557f35d0acf3b9bed18963bfb8e961f24de910c Author: Asier Lostalé <asier.lostale@openbravo.com> Date: 2020-10-20T07:35:04+02:00 URL: https://gitlab.com/openbravo/product/dbsm/-/commit/9557f35d0acf3b9bed18963bfb8e961f24de910c [^] fixed BUG-45217: Functions test fails in cli When executing Functions test in cli it failed because the tests make assertions on the log by using the appender defined in src-test/test/log4j2-test.xml. This config file was not in the classpath therefore, the TestLogAppender which is needed the test to properly run was not included. To fix this: 1. log4j2-test.xml is copied to the classpath at compile time 2. Classpath for compilation and runtime has been split. Including in runtime OB classpath parts containing log4j config resulted in those overwriting dbsm test config. As those OB classpath parts are only needed to compile, 2 different classpaths can be used. --- M src-test/build.xml ---

Issue History
Date Modified	Username	Field	Change
2020-10-14 08:48	alostale	New Issue
2020-10-14 08:48	alostale	Assigned To	=> platform
2020-10-14 08:48	alostale	Modules	=> Core
2020-10-14 08:48	alostale	Triggers an Emergency Pack	=> No
2020-10-14 08:48	alostale	Relationship added	related to 0045216
2020-10-14 10:18	alostale	Relationship added	related to 0045222
2020-10-14 13:04	shuehner	Issue Monitored: shuehner
2020-10-20 07:44	hgbot	Note Added: 0123787
2020-10-20 07:44	alostale	Assigned To	platform => alostale
2020-10-23 09:56	hgbot	Note Added: 0123900
2020-10-23 09:56	hgbot	Resolution	open => fixed
2020-10-23 09:56	hgbot	Status	new => closed
2020-10-23 09:56	hgbot	Note Added: 0123901

Copyright © 2000 - 2009 MantisBT Group