Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045203
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Loyalty Programs for Web POSmajoralways2020-10-07 12:142020-10-15 16:35
ReporteraaroncaleroView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR21Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2019-05-03
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/c29a675e002392b0253c7cb3ea24410a95dd0cf2 [^]
Triggers an Emergency PackNo
Summary

0045203: Inconsistent memberId between subscriptions created in WebPOS and Backoffice

DescriptionWhen a subscription is created, it's member ID is defined automatically based on a sequence linked to the Loyalty Program.

When the subscription is created from backoffice, by default the member ID is shown as tentative (between angle brackets) and is finally confirmed when saving the record. Regardless of the length of the number given by the sequence, this number is padded to 10 characters adding zeros to the left (this is done by an event handler monitoring the Save event of subscriptions.

Prior to 19q3 this worked also when creating subscriptions from WebPOS; the member ID was left blank, and then the event handler would take care of retrieving the number from the sequence and padding it accordingly.

In 19q3 the subscription saving process was refactored and some code was added to set the member ID before saving the subscription.
This code is missing the padding adjustment, so subscriptions created from WebPOS are missing the leading zeros.
Steps To ReproduceIn an environment with Loyalty Programs for WebPOS installed and configured:
Log in backend, go to the Subscriptions window and create a new record.
Assing a program, category, status and Business partner and verify that the member ID is shown as e.g. <0000000002>.
Save the record and verify that the member ID is confirmed as 0000000002.

Log in WebPOS
Search for a customer without loyalty subscriptions.
Open the Customer Details window for that customer.
Click on the + button on the Loyalty Program section. The Loyalty Program selector will be shown.
Select the program and click on OK. In the New Loyalty popup fill any mandatory field (by default nothing should be required) and click on Save.
Verify that the Subscription Details popup is opened and the member ID is shown as 3, without the zero-padding.
Proposed SolutionThe SaveSubscriptionManager.java file should add the padding to the member ID when it is assigned, here[1]
A left padding example can be seen in the base org.openbravo.loyalty.programs module, in the SubscriptionEventHandler.java.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/blob/master/src/org/openbravo/retail/loyalty/programs/process/SaveSubscriptionManager.java#L123 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0123688)
hgbot (developer)
2020-10-15 05:23

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/9 [^]
(0123717)
hgbot (developer)
2020-10-15 16:33

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/9 [^]

- Issue History
Date Modified Username Field Change
2020-10-07 12:14 aaroncalero New Issue
2020-10-07 12:14 aaroncalero Assigned To => Retail
2020-10-07 12:14 aaroncalero OBNetwork customer => Gold
2020-10-07 12:14 aaroncalero Resolution time => 1603839600
2020-10-07 12:14 aaroncalero Regression level => Production - Confirmed Stable
2020-10-07 12:14 aaroncalero Regression date => 2019-05-03
2020-10-07 12:14 aaroncalero Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/c29a675e002392b0253c7cb3ea24410a95dd0cf2 [^]
2020-10-07 12:14 aaroncalero Triggers an Emergency Pack => No
2020-10-14 08:27 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2020-10-14 13:14 ranjith_qualiantech_com Status new => scheduled
2020-10-15 05:23 hgbot Merge Request Status => open
2020-10-15 05:23 hgbot Note Added: 0123688
2020-10-15 16:33 hgbot Merge Request Status open => approved
2020-10-15 16:33 hgbot Note Added: 0123717
2020-10-15 16:34 marvintm Status scheduled => resolved
2020-10-15 16:34 marvintm Fixed in Version => RR21Q1
2020-10-15 16:34 marvintm Resolution open => fixed
2020-10-15 16:35 marvintm Review Assigned To => marvintm
2020-10-15 16:35 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker