0045169: Sessions module uses bad logging (printStrackTrace)

Notes
(0123605) alostale (viewer) 2020-10-07 13:59	The problem for the reported case is in sessions module [1]: } catch (ParseException e) { e.printStackTrace(); } On top of simply logging with log4j: * Add some relevant context to know the reason it failed * Even more important: is it ok to just catch and ignore the exception responding success? --- [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/blob/dcd7d06b11da3820b31441a66d7a1b1a3225b41c/src/org/openbravo/retail/sessions/SetBusinessDate.java#L74 [^]

(0132927) hgbot (developer) 2021-11-10 09:40	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/29 [^]

(0132943) hgbot (developer) 2021-11-10 17:10	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^] Changeset: 0509922099e685ebcc57a4888113082c7f49b1fa Author: Justin Patterson <justin.patterson@openbravo.com> Date: 2021-11-10T16:42:56+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/0509922099e685ebcc57a4888113082c7f49b1fa [^] Fixed ISSUE-45169: moved logging to log4j - imported log4j LogManager - instantiated logger - replaced e.printStackTrace with logger.error(e.printMessage()) - added JSON object "result" to store JSONConstants data and return on error --- M src/org/openbravo/retail/sessions/CashUpDetailsDatasource.java M src/org/openbravo/retail/sessions/SetBusinessDate.java ---

(0132944) hgbot (developer) 2021-11-10 17:10	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/29 [^]

Issue History
Date Modified	Username	Field	Change
2020-10-01 15:45	shuehner	New Issue
2020-10-01 15:45	shuehner	Assigned To	=> platform
2020-10-01 15:45	shuehner	OBNetwork customer	=> No
2020-10-01 15:45	shuehner	Modules	=> Core
2020-10-01 15:45	shuehner	Triggers an Emergency Pack	=> No
2020-10-07 13:59	alostale	Note Added: 0123605
2020-10-07 14:01	alostale	Project	Openbravo ERP => Retail Modules
2020-10-07 14:01	alostale	Assigned To	platform => Retail
2020-10-07 14:01	alostale	Category	A. Platform => Sessions
2020-10-07 14:02	alostale	Relationship added	blocks 0036162
2021-11-03 15:07	shuehner	Summary	Some exceptions raised in ImportEntry processing end up being logged in catalina.out (and not using log4j2) => Sessions module uses bad logging (printStrackTrace)
2021-11-03 15:07	shuehner	Description Updated	View Revisions
2021-11-03 15:07	shuehner	Steps to Reproduce Updated	View Revisions
2021-11-03 15:07	shuehner	Proposed Solution updated
2021-11-04 08:17	marvintm	Status	new => scheduled
2021-11-04 08:17	marvintm	Assigned To	Retail => justin_patterson
2021-11-10 09:40	hgbot	Merge Request Status	=> open
2021-11-10 09:40	hgbot	Note Added: 0132927
2021-11-10 15:52	hgbot	Merge Request Status	open => approved
2021-11-10 17:10	hgbot	Resolution	open => fixed
2021-11-10 17:10	hgbot	Status	scheduled => closed
2021-11-10 17:10	hgbot	Note Added: 0132943
2021-11-10 17:10	hgbot	Note Added: 0132944