0045166: Exception is not correctly thrown in createNewShipment function of ShipmentUtils class

Description

Exception is not correctly thrown in createNewShipment function of ShipmentUtils class. It captures the exceptions and it shows the following error message in the Error While Importing POS Data with no detail:

Error in OrderLoader: Error when creating the shipment: org.openbravo.base.exception.OBException: Error in OrderLoader when getting stock for product error

The error message is raised in callProcessGetStock of ShipmentUtils class. The StockUtils.getStock function is called there. And then, StockUtilsData.getStock function is called and it includes a new DalConnectionProvider(true) that does a flush (this is why the exception for other flows can be raised here)

Steps To Reproduce

N/A

Proposed Solution

Check changing the following line:

throw new OBException("Error when creating the shipment: " + e);

with

throw new OBException("Error when creating the shipment: ", e);

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0123625) hgbot (developer) 2020-10-08 16:48	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/126 [^]

(0123631) hgbot (developer) 2020-10-09 07:37	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/126 [^]

(0123632) hgbot (developer) 2020-10-09 07:37	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 6245b38fe799b58217f79d468b42a25c5c74a3c3 Author: Prakash M <prakash@qualiantech.com> Date: 2020-10-08T20:09:20+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6245b38fe799b58217f79d468b42a25c5c74a3c3 [^] Fixed BUG-45166: Fixes error thrown in createNewShipment to display error in detail --- M src/org/openbravo/retail/posterminal/utility/ShipmentUtils.java ---

Issue History
Date Modified	Username	Field	Change
2020-10-01 11:20	ngarcia	New Issue
2020-10-01 11:20	ngarcia	Assigned To	=> Retail
2020-10-01 11:20	ngarcia	Resolution time	=> 1603317600
2020-10-01 11:20	ngarcia	Triggers an Emergency Pack	=> No
2020-10-01 11:25	ngarcia	Issue Monitored: ngarcia
2020-10-01 11:41	ngarcia	Description Updated	View Revisions
2020-10-08 12:35	prakashmurugesan88	Assigned To	Retail => prakashmurugesan88
2020-10-08 15:47	prakashmurugesan88	Status	new => scheduled
2020-10-08 16:48	hgbot	Note Added: 0123625
2020-10-09 07:37	hgbot	Resolution	open => fixed
2020-10-09 07:37	hgbot	Status	scheduled => closed
2020-10-09 07:37	hgbot	Note Added: 0123631
2020-10-09 07:37	hgbot	Fixed in Version	=> RR21Q1
2020-10-09 07:37	hgbot	Note Added: 0123632