Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045165
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2020-09-30 18:362020-10-05 06:59
ReportercbernerView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in VersionPR21Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045165: Popups are inaccessible, behind a mask, after long usage without refreshing or logout/login

DescriptionPopups in any tab will be behind a mask if Openbravo has been used frequently for a period of time without refreshing, or logging out and in again.

It appears that some internal z-index property in smartclient gets overflowed and all popups will be sent behind the mask instead of the front.
Steps To ReproduceA javascript script has been attached to reproduce this issue. Run this script with "Developer tools" open and after logging in.

It will open tabs until the z-index gets overflowed. Then, open any popup, for example: "Sales Order" -> "Book", it should be behind the mask and inaccessible to click.

Alternatively, it can be manually tested by opening tabs and executing:
"console.log(isc.Canvas._BIG_Z_INDEX,isc.Canvas._nextZIndex)" until the second number is bigger than the first number. Then, any popup you open will be overflowed.
Proposed SolutionSet _BIG_Z_INDEX in smartclient.dev module to a bigger number, 10000000 (10 million), instead of 800000, the issue would still be there, but it would take a lot to reproduce, as it also gets reset on login/logout or refresh.
TagsNo tags attached.
Attached Files? file icon repeat-z-index-error.js [^] (685 bytes) 2020-09-30 18:37

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0045089 closedcberner White screen when navigating to Product window from Sales Order window some times 
related to defect 0042178 closedcberner When the "add payment" window is loading and the focus is changed of the window a grey screen appears 

-  Notes
(0123463)
hgbot (developer)
2020-09-30 19:20

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/185 [^]
(0123470)
hgbot (developer)
2020-10-01 07:18

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/185 [^]
(0123471)
hgbot (developer)
2020-10-01 07:18

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 7ccab57eca4b15a29a62186db610f5c3a8d3a481
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-09-30T19:18:49+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/7ccab57eca4b15a29a62186db610f5c3a8d3a481 [^]

Fixes ISSUE-45165: Fix inaccessible Popups(grayed) after long usage without refreshing

Popups sometimes appeared behind a mask instead of in front of
everything else. This was happening because of an overflow on z-index
ranges used by smartclient.

To solve this, one option is to reset those z-index variables, but
that's not ok on a working environment without refreshing or
logout/login of the user. z-index range for smartclient has been
increased, putting all popups more in front, so it doesn't get
overflowed by the next z-index variable.

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js
---
(0123474)
hgbot (developer)
2020-10-01 09:54

 Merge Request created: https://gitlab.com/openbravo/tools/platform/org.openbravo.userinterface.smartclient.dev/-/merge_requests/2 [^]
(0123475)
hgbot (developer)
2020-10-01 10:14

 Merge request merged: https://gitlab.com/openbravo/tools/platform/org.openbravo.userinterface.smartclient.dev/-/merge_requests/2 [^]
(0123476)
hgbot (developer)
2020-10-01 10:14

 Repository: https://gitlab.com/openbravo/tools/platform/org.openbravo.userinterface.smartclient.dev [^]
Changeset: dfe0f34583de38cfc1b2540c048d0f1c93ca645f
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-10-01T09:52:35+02:00
URL: https://gitlab.com/openbravo/tools/platform/org.openbravo.userinterface.smartclient.dev/-/commit/dfe0f34583de38cfc1b2540c048d0f1c93ca645f [^]

Related to ISSUE-45165: Fix inaccessible Popups(grayed) after long usage without refreshing

Popups sometimes appeared behind a mask instead of in front of
everything else. This was happening because of an overflow on z-index
ranges used by smartclient.

To solve this, one option is to reset those z-index variables, but
that's not ok on a working environment without refreshing or
logout/login of the user. z-index range for smartclient has been
increased, putting all popups more in front, so it doesn't get
overflowed by the next z-index variable.

---
M web/org.openbravo.userinterface.smartclient/isomorphic/client/widgets/Canvas.js
M web/org.openbravo.userinterface.smartclient/isomorphic/system/modules-debug/ISC_Core.js
M web/org.openbravo.userinterface.smartclient/isomorphic/system/modules/ISC_Core.js
---

- Issue History
Date Modified Username Field Change
2020-09-30 18:36 cberner New Issue
2020-09-30 18:36 cberner Assigned To => platform
2020-09-30 18:36 cberner Modules => Core
2020-09-30 18:36 cberner Triggers an Emergency Pack => No
2020-09-30 18:37 cberner File Added: repeat-z-index-error.js
2020-09-30 18:38 cberner Assigned To platform => cberner
2020-09-30 18:41 cberner Proposed Solution updated
2020-09-30 19:20 hgbot Note Added: 0123463
2020-10-01 07:16 alostale Relationship added related to 0045089
2020-10-01 07:17 alostale Relationship added related to 0042178
2020-10-01 07:18 hgbot Resolution open => fixed
2020-10-01 07:18 hgbot Status new => closed
2020-10-01 07:18 hgbot Note Added: 0123470
2020-10-01 07:18 hgbot Fixed in Version => PR20Q4
2020-10-01 07:18 hgbot Note Added: 0123471
2020-10-01 09:54 hgbot Note Added: 0123474
2020-10-01 10:14 hgbot Note Added: 0123475
2020-10-01 10:14 hgbot Note Added: 0123476
2020-10-05 06:59 priyam Fixed in Version PR20Q4 => PR21Q1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker