Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045143
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] 09. Financial managementmajoralways2020-09-25 12:202020-10-07 12:06
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in VersionPR21Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045143: Outstanding Amount not updated when closing Sales Order in Oracle

DescriptionWhen a Sales Order is booked and has a prepayment, when the order is closed, the outstanding amount in the Payment Plan is not updated with the negative received amount, which is wrong.
Steps To Reproduce1. Register Sales Order with total amount 100
2. Run Add Details process to register prepayment of 100
3. Close the order. Payment plan info will not be properly updated.
Proposed SolutionIn APRM_GEN_PAYMENTSCHEDULE_ORD.xml, the following query retreives no records due to the situation generated with the stepts to reproduce, which causes an Exception due to Oracle's interpretation of SELECT INTO statements.

--Get fin_payment_scheduledetail not related to payments nor invoices.
SELECT fin_payment_scheduledetail_id, amount
  INTO v_finpaymentscheduledetailid, v_psd_amt
FROM fin_payment_scheduledetail
WHERE fin_payment_schedule_order = v_finpaymentscheduleid
  AND fin_payment_schedule_invoice IS NULL
  AND fin_payment_detail_id IS NULL;

Proposed solution is to add a "try-catch" block around that query.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0045081 closedTriage Omni OMS Credit details appear in Aging report although prepaid order is closed 

-  Notes
(0123378)
inigo_lerga (reporter)
2020-09-25 12:22

 --Test Plan Mantis--

As the F&B International Group Admin role in Backend:
1º- Go to Sales Order window and create a new record with
    'Restaurantes Luna Llena, S.A.' as Business Partner.
2º- Go to Lines Tab and create a new record with 'Cola 0,5L'
    Product and 100 units as Ordered Quantity.
3º- Book the Sales Order.
4º- Press the Add Payment button and verify '95.41' (Expected Payment)
    as Actual Payment.
5º- Close the Sales Order.

# Check in Payment Plan Tab that Outstanding amount is properly updated to
'-95.41' (Negative Received Payment) #
(0123380)
hgbot (developer)
2020-09-25 13:01

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/183 [^]
(0123596)
hgbot (developer)
2020-10-07 12:06

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 0d06423744d2eae704e527630c75392b8eca6f77
Author: inigo_lerga <inigo.lerga@openbravo.com>
Date: 2020-10-07T10:06:02+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/0d06423744d2eae704e527630c75392b8eca6f77 [^]

fixes BUG-45143:Outstanding Amount properly updated

"try-catch" block added around query that raised exception
when no records were retreived.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_ORD.xml
---
(0123597)
hgbot (developer)
2020-10-07 12:06

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/183 [^]

- Issue History
Date Modified Username Field Change
2020-09-25 12:20 inigo_lerga New Issue
2020-09-25 12:20 inigo_lerga Assigned To => inigo_lerga
2020-09-25 12:20 inigo_lerga Modules => Advanced Payables and Receivables Mngmt
2020-09-25 12:20 inigo_lerga Triggers an Emergency Pack => No
2020-09-25 12:20 inigo_lerga Status new => scheduled
2020-09-25 12:22 inigo_lerga Note Added: 0123378
2020-09-25 12:26 inigo_lerga Relationship added related to 0045081
2020-09-25 13:01 hgbot Note Added: 0123380
2020-10-07 12:06 hgbot Resolution open => fixed
2020-10-07 12:06 hgbot Status scheduled => closed
2020-10-07 12:06 hgbot Fixed in Version => PR21Q1
2020-10-07 12:06 hgbot Note Added: 0123596
2020-10-07 12:06 hgbot Note Added: 0123597

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker