Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044802
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Localization Pack: Spain] SPLP 3.0minorhave not tried2020-08-12 16:542020-09-11 08:24
ReportershuehnerView Statuspublic 
Assigned ToMery Anelo 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release
Summary

0044802: org.openbravo.module.finactvalidator.es has 2 old-style callouts not yet refactored to extend SimpleCallout

DescriptionFNACTV_BPBankAccountValidation & FNACTV_BankAccountValidation callouts
are 2 of the few ones left over not not refactored to be SimpleCallout (issue 36067 refactored every supported module except a few one).

Apart of the refactor both callouts seem to still use a feature ("EXECUTE" command) not working for many years as indicated here:

https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java#L1585 [^]

Probably that should be fixed or cleaned up as well when this issue is being worked on
Steps To Reproduceproduct/mods/org.openbravo.module.finactvalidator.es/src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BPBankAccountValidation.java: resultado.append("var respuesta = new Array(");
product/mods/org.openbravo.module.finactvalidator.es/src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BPBankAccountValidation.java: .append("var respuesta = new Array(new Array('EXECUTE', \"initiali>
product/mods/org.openbravo.module.finactvalidator.es/src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BankAccountValidation.java: resultado.append("var respuesta = new Array(");
product/mods/org.openbravo.module.finactvalidator.es/src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BankAccountValidation.java: .append("var respuesta = new Array(new Array('EXECUTE', \"initialize>
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks design defect 0044795 newTriage Omni OMS Openbravo ERP Tracking issue to refactor remaining old callouts to extend SimpleCallout 

-  Notes
(0122097)
shuehner (administrator)
2020-08-17 12:41

 EXECUTE action of callouts is obsolete and does not work for many years. That part of the callout should be reviewed and fixed while working on this also.

Note that this is in codepath trying to support old 2.50 style UI. So probably that could be just removed as no longer required.
(0122892)
Mery Anelo (developer)
2020-09-10 02:18

 Before starting configure both callouts. See the following link: http://wiki.openbravo.com/wiki/Projects:FinAccValidatorSpain [^]

Plan Test:
- Login as F&B Internation Group Admin
- For FNACTV_BPBankAccountValidation callout:
       - Go to Business Partner window
       - Select "Bank Account" tab
       - Put a value in the "Generic Account No." field and see that the messages are correct.

- For FNACTV_BankAccountValidation callout:
       - Go to Financial Account window
       - Create a new account
       - Make sure the account "Type" is "Bank", the "Bank Account Format" is "Use Spain".
       - Fill in the fields in the "Bank Account Format" group and make sure that the callout returns correct warning messages in case the fields are wrong.
(0122925)
hgbot (developer)
2020-09-10 16:18

 Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.module.finactvalidator.es/-/merge_requests/1 [^]
(0122942)
hgbot (developer)
2020-09-11 08:24

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.finactvalidator.es [^]
Changeset: dcf3d01cdc3b51ffd936c52f2000ff85c90138dc
Author: Mery Anelo <mery.anelo@smfconsulting.es>
Date: 2020-09-10T11:00:58-03:00
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.finactvalidator.es/-/commit/dcf3d01cdc3b51ffd936c52f2000ff85c90138dc [^]

Fixed BUG-44802: FNACTV validations to SimpleCallout

FNACTV_BPBankAccountValidation and FNACTV_BankAccountValidation transformed from old-style callout to SimpleCallout.

---
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BPBankAccountValidation.java
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BankAccountValidation.java
---
(0122943)
hgbot (developer)
2020-09-11 08:24

 Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.module.finactvalidator.es/-/merge_requests/1 [^]
(0122944)
hgbot (developer)
2020-09-11 08:24

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.finactvalidator.es [^]
Changeset: 8ed3a3701670037309b0a14fd610afacf7548387
Author: Mery Anelo <mery.anelo@smfconsulting.es>
Date: 2020-09-10T11:04:46-03:00
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.finactvalidator.es/-/commit/8ed3a3701670037309b0a14fd610afacf7548387 [^]

Fixed BUG-44802: FNACTV validations to SimpleCallout

The messages are displayed using obsolete js, the functionality is removed and the one already implemented by SimpleCallouts is used.

---
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BPBankAccountValidation.java
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BankAccountValidation.java
R web/org.openbravo.module.finactvalidator.es/js/fnactv-utilities.js
---
(0122945)
hgbot (developer)
2020-09-11 08:24

 Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.finactvalidator.es [^]
Changeset: 74d10e2c2a66c0a5b106ac6a038d1f7d0d882f4c
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2020-09-11T08:12:05+02:00
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.finactvalidator.es/-/commit/74d10e2c2a66c0a5b106ac6a038d1f7d0d882f4c [^]

Related to ISSUE-44802: Use standard OBMessageUtils.messageBD()

---
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BPBankAccountValidation.java
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BankAccountValidation.java
---
(0122946)
hgbot (developer)
2020-09-11 08:24

 Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.finactvalidator.es [^]
Changeset: ae305345107d58c53a38054dce50037707f8ae5d
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2020-09-11T08:12:20+02:00
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.finactvalidator.es/-/commit/ae305345107d58c53a38054dce50037707f8ae5d [^]

Related to BUG-44802: Refactor to avoid code duplication

Centralized logic to validate Spanish bank format in SpanishBankAccountValidator class.
Created SpanishBankAccountValidatorCallout as a template to implement any Spanish Bank Account Validator Callout. Existing callouts just extend from this one and are in charge of getting the account number from the form.

---
A src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/SpanishBankAccountValidator.java
A src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/SpanishBankAccountValidatorCallout.java
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BPBankAccountValidation.java
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BankAccountValidation.java
---
(0122947)
hgbot (developer)
2020-09-11 08:24

 Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.finactvalidator.es [^]
Changeset: cc9eda3da3bb970afc3eb6d48d61fc34714a95bc
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2020-09-11T08:16:04+02:00
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.finactvalidator.es/-/commit/cc9eda3da3bb970afc3eb6d48d61fc34714a95bc [^]

Related to BUG-44802: Removed unclear constant

---
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/SpanishBankAccountValidatorCallout.java
---

- Issue History
Date Modified Username Field Change
2020-08-12 16:54 shuehner New Issue
2020-08-12 16:54 shuehner Assigned To => Jorge Bravo
2020-08-12 16:54 shuehner Relationship added blocks 0044795
2020-08-17 12:41 shuehner Note Added: 0122097
2020-08-27 15:48 Jorge Bravo Assigned To Jorge Bravo => Mery Anelo
2020-09-10 02:18 Mery Anelo Note Added: 0122892
2020-09-10 02:18 Mery Anelo Status new => scheduled
2020-09-10 16:18 hgbot Note Added: 0122925
2020-09-11 08:24 hgbot Resolution open => fixed
2020-09-11 08:24 hgbot Status scheduled => closed
2020-09-11 08:24 hgbot Note Added: 0122942
2020-09-11 08:24 hgbot Note Added: 0122943
2020-09-11 08:24 hgbot Note Added: 0122944
2020-09-11 08:24 hgbot Note Added: 0122945
2020-09-11 08:24 hgbot Note Added: 0122946
2020-09-11 08:24 hgbot Note Added: 0122947

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker