Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044757
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2020-08-05 14:082020-08-05 14:25
ReporterjarmendarizView Statuspublic 
Assigned Tojarmendariz 
PrioritynormalResolutionfixedFixed in VersionRR20Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned Toalostale
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044757: SynchronizationBuffer unit test is not testing the subject's behavior

DescriptionTest 'when IndexedDB persist fails'.'isReceivingMessages flag is set to false even when persist fails' checks that this.isReceivingMessages is false. This test will always pass because it should check the isReceivingMessages property in SynchronizationBuffer instance.
Steps To Reproduce1- Execute 'isReceivingMessages flag is set to false even when persist fails' test in SynchronizationBuffer.test.js. Chech that it passes.
2- Change the following line in SynchronizationBuffer.js:

  try {
    await OB.App.MessageModelController.put(messages);
  } finally {
  // Comment the following line to force the test to fail
  // this.isReceivingMessages = false;
  }

3- Run again 'isReceivingMessages flag is set to false even when persist fails'. Check that the test still passes even if it's supposed to fail.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0121854)
hgbot (developer)
2020-08-05 14:22

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/44 [^]
(0121855)
hgbot (developer)
2020-08-05 14:25

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/44 [^]
(0121856)
hgbot (developer)
2020-08-05 14:25

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 070ec48f7faa8ca07acd087fe34cfa1d4896b235
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-08-05T14:12:11+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/070ec48f7faa8ca07acd087fe34cfa1d4896b235 [^]

Fixed ISSUE-44757: SynchronizationBuffer test does not test the subject's behavior.

Instead of checking the synchronizationBuffer's property value, it checks for a local flag that
is never set, so it always passes regardless the syncBuffer behavior

---
M web-test/model/synchronization-buffer/SynchronizationBuffer.test.js
---

- Issue History
Date Modified Username Field Change
2020-08-05 14:08 jarmendariz New Issue
2020-08-05 14:08 jarmendariz Assigned To => jarmendariz
2020-08-05 14:08 jarmendariz OBNetwork customer => No
2020-08-05 14:08 jarmendariz Triggers an Emergency Pack => No
2020-08-05 14:09 jarmendariz Review Assigned To => alostale
2020-08-05 14:09 jarmendariz Status new => scheduled
2020-08-05 14:22 hgbot Merge Request Status => open
2020-08-05 14:22 hgbot Note Added: 0121854
2020-08-05 14:25 hgbot Merge Request Status open => approved
2020-08-05 14:25 hgbot Note Added: 0121855
2020-08-05 14:25 hgbot Resolution open => fixed
2020-08-05 14:25 hgbot Status scheduled => closed
2020-08-05 14:25 hgbot Fixed in Version => RR20Q4
2020-08-05 14:25 hgbot Note Added: 0121856

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker