Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0044745

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Discounts and Promotions

major

always

2020-08-03 19:26

2020-08-14 07:44

Reporter

sdossantos

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

high

Resolution

unable to reproduce

Fixed in Version

pi

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

pi

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Gold

Support ticket

16993

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0044745: Discount Become Double when cancel and replace a layaway

Description

When we tried to recall a created layaway and change the item the discount becomes double.
The error was reproduced in the 3.0RR19Q4.4, 3.0RR20Q1.1, 3.0RR20Q1.2 and 3.0RR20Q2 versions

Steps To Reproduce

Specs:
1) Create one receipt with any product, that has one discount configuration in Discount and Promotions window.
2) Pay the receipt created.
3) Open the paid receipt.
4) Cancel and Replace the receipt created.
5) Add one product (same product or different), you will see that discount is duplicated.

Tags

No tags attached.

discontx2-2020-08-03-113945_Nbe6bepY.compressed.mp4 [^] (2,439,859 bytes) 2020-08-03 19:44

44745.patch [^] (722 bytes) 2020-08-13 09:59 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/model/order.js b/web/org.openbravo.retail.posterminal/js/model/order.js
index 60dd7f81d..df8ed3346 100644
--- a/web/org.openbravo.retail.posterminal/js/model/order.js
+++ b/web/org.openbravo.retail.posterminal/js/model/order.js
@@ -6521,6 +6521,12 @@
           me.set('documentNo', newDocNo);
           me.set('posTerminal', OB.MobileApp.model.get('terminal').id);
 
+          me.get('lines').models.forEach(function(l) {
+            l.get('promotions').forEach(function(p) {
+              p.calculatedOnDiscountEngine = true;
+            });
+          });
+
           OB.UTIL.HookManager.executeHooks(
             'OBPOS_PostCancelAndReplace',
             {

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	backport	0044815	RR20Q3.1	closed	ranjith_qualiantech_com	Discount Become Double when cancel and replace a layaway
depends on	backport	0044816	RR20Q2.2	closed	ranjith_qualiantech_com	Discount Become Double when cancel and replace a layaway

Notes
(0122041) marvintm (viewer) 2020-08-14 07:44	It is not reproducible anymore in pi. However, it can be reproduced in previous versions starting 19Q4, so we will backport it to currently maintained releases.

Issue History
Date Modified	Username	Field	Change
2020-08-03 19:26	sdossantos	New Issue
2020-08-03 19:26	sdossantos	Assigned To	=> Retail
2020-08-03 19:26	sdossantos	Triggers an Emergency Pack	=> No
2020-08-03 19:44	sdossantos	File Added: discontx2-2020-08-03-113945_Nbe6bepY.compressed.mp4
2020-08-04 11:16	martinsdan	Issue Monitored: martinsdan
2020-08-06 15:40	shankarb	OBNetwork customer	=> OBPS
2020-08-06 15:40	shankarb	Support ticket	=> 16993
2020-08-06 15:40	shankarb	Resolution time	=> 1598220000
2020-08-07 11:14	maite	OBNetwork customer	OBPS => Gold
2020-08-11 10:04	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2020-08-11 10:05	ranjith_qualiantech_com	Status	new => scheduled
2020-08-13 09:59	ranjith_qualiantech_com	File Added: 44745.patch
2020-08-14 07:43	marvintm	Status	scheduled => acknowledged
2020-08-14 07:43	marvintm	Status	acknowledged => scheduled
2020-08-14 07:44	marvintm	Review Assigned To	=> marvintm
2020-08-14 07:44	marvintm	Note Added: 0122041
2020-08-14 07:44	marvintm	Status	scheduled => closed
2020-08-14 07:44	marvintm	Resolution	open => unable to reproduce
2020-08-14 07:44	marvintm	Fixed in Version	=> pi

Copyright © 2000 - 2009 MantisBT Group