Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0044565
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Nexo Implementationmajoralways2020-07-07 09:262020-08-05 12:37
ReporterjcbourgeoisView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionRR19Q3.3SCM revision 
Review Assigned Toadrianromero
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044565: WebPOS - NEXO provider - After a logout, time needed to login is important

DescriptionAfter a logout, when the cashier logins into WebPOS, the loading time is more important than the first login of the day.
The analysis of requests (via Chrome Dev tools) shows WebPOS is waiting for the response of Nexo (ACI EFT). That response takes around 10s. See screenshot enclosed.

However, we didn't face this long time at first login of the day because WebPOS doesn't wait for that response of Nexo and it's the right behavior to optimize WebPOS loading
Steps To ReproduceVideo for login (first start of WebPOS) : https://drive.google.com/file/d/18iMmjSRF1tdoVHqltwKU5YUiAO2mjEdW/view [^] [^]
=> It's quite quick

Video for logout - login : https://drive.google.com/file/d/1I8nuaPLKbR7S8A_bCS2TG3HXlhWJepcX/view [^] [^]
=> WebPOS is waiting for Nexo (ACI EFT) response
Proposed SolutionIn case of logout / login operation, don't wait for the response of Nexo
TagsPerformance
Attached Filespng file icon screenshot.png [^] (201,481 bytes) 2020-07-07 09:26

- Relationships Relation Graph ] Dependency Graph ]
depends on defect 0043333 closedrqueralta Retail Modules The login hook is not executed when login after a cashup 

-  Notes
(0121780)
adrianromero (manager)
2020-08-04 09:58

The observed behaviour might be a side effect of the login hook used to initialize NEXO and/or other functionality attached to the login hook, that in one case the login process is not waiting for all functionality attached to the login hook to finish and in the other case it does wait.
(0121803)
adrianromero (manager)
2020-08-04 14:09

Due to issue 0043333 depending on the flow implemented in the login hook in sessions module, the rest of the functionality attached to the login hook is executed or not. In order to have a consistent behaviour, all patches in issue 0043333 must be applied.

About the performance of the initialization of NEXO implemented in the login hook. Almost all of the time is took by the device initializing and verifying all the applications installed needed to support all cards: VISA, MASTER, AMERICAN EXPRESS, ... This initialization process is also used to update the firmware of the device if needed. As explained by the provider this initialization can take up to two minutes, and it is required to wait until the end to complete the POS login.
(0121807)
adrianromero (manager)
2020-08-04 14:35

After discussing the topic internally, we are going to explore the possibility to execute the NEXO initialization process asynchronously. This way the initialization process will not block the login to finish but it might be not possible to process NEXO payments until the initialization process is finished.
(0121844)
hgbot (developer)
2020-08-05 12:21

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider/-/merge_requests/1 [^]
(0121845)
hgbot (developer)
2020-08-05 12:24

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider [^]
Changeset: a9fbe75a6c287fb0ada9cf659169d8afaf2b92f4
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 2020-08-05T12:17:25+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider/-/commit/a9fbe75a6c287fb0ada9cf659169d8afaf2b92f4 [^]

Related ISSUE-0044565: WebPOS - NEXO provider - After a logout, time needed to login is important
* Adds to base login and logout hooks the ability to be executed in a deferred way

---
A web/org.openbravo.retail.asyncpayprovider/source/hook/deferredhook.js
M src/org/openbravo/retail/asyncpayprovider/ASYComponentProvider.java
M web/org.openbravo.retail.asyncpayprovider/source/hook/loginhook.js
M web/org.openbravo.retail.asyncpayprovider/source/hook/logouthook.js
---
(0121846)
hgbot (developer)
2020-08-05 12:24

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider/-/merge_requests/1 [^]
(0121848)
hgbot (developer)
2020-08-05 12:37

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.nexoprovider/-/merge_requests/1 [^]
(0121849)
hgbot (developer)
2020-08-05 12:37

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.nexoprovider [^]
Changeset: ba73a0be68fa0a8dde3fdb181e33bc4d49893abd
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 2020-08-05T12:24:09+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.nexoprovider/-/commit/ba73a0be68fa0a8dde3fdb181e33bc4d49893abd [^]

Fixes ISSUE-0044565: WebPOS - NEXO provider - After a logout, time needed to login is important
* Use deferredHook() to not to block the login and logout process

---
M web/org.openbravo.retail.nexoprovider/js/hook/loginhook.js
M web/org.openbravo.retail.nexoprovider/js/hook/logouthook.js
---
(0121850)
hgbot (developer)
2020-08-05 12:37

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.nexoprovider/-/merge_requests/1 [^]

- Issue History
Date Modified Username Field Change
2020-07-07 09:26 jcbourgeois New Issue
2020-07-07 09:26 jcbourgeois Assigned To => Retail
2020-07-07 09:26 jcbourgeois File Added: screenshot.png
2020-07-07 09:26 jcbourgeois Triggers an Emergency Pack => No
2020-07-07 09:27 jcbourgeois Relationship added blocks 0044299
2020-07-18 07:16 guillermogil Resolution time => 1595973600
2020-07-18 07:16 guillermogil Category Web POS Hardware Manager => Nexo Implementation
2020-08-04 09:28 guillermogil Tag Attached: Performance
2020-08-04 09:58 adrianromero Note Added: 0121780
2020-08-04 12:26 adrianromero Relationship added related to 0044600
2020-08-04 13:58 adrianromero Relationship deleted related to 0044600
2020-08-04 13:58 adrianromero Relationship added depends on 0043333
2020-08-04 14:09 adrianromero Review Assigned To => adrianromero
2020-08-04 14:09 adrianromero Note Added: 0121803
2020-08-04 14:09 adrianromero Status new => closed
2020-08-04 14:09 adrianromero Resolution open => fixed
2020-08-04 14:34 adrianromero Note Added: 0121806
2020-08-04 14:34 adrianromero Status closed => new
2020-08-04 14:34 adrianromero Resolution fixed => open
2020-08-04 14:34 adrianromero Note Deleted: 0121806
2020-08-04 14:35 adrianromero Note Added: 0121807
2020-08-05 12:21 hgbot Note Added: 0121844
2020-08-05 12:24 hgbot Note Added: 0121845
2020-08-05 12:24 hgbot Note Added: 0121846
2020-08-05 12:37 hgbot Note Added: 0121848
2020-08-05 12:37 hgbot Resolution open => fixed
2020-08-05 12:37 hgbot Status new => closed
2020-08-05 12:37 hgbot Note Added: 0121849
2020-08-05 12:37 hgbot Note Added: 0121850


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker