Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0044530

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2020-07-01 15:45

2020-07-28 13:15

Reporter

maite

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

urgent

Resolution

fixed

Fixed in Version

RR20Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

adrianromero

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0044530: "Cannot calculate receipt taxes" error raised due to timezone conversion

Description

When a ticket is synchronized its 'originalOrderDate' field is converted to GMT. In a local environment running in GMT+2 this means that a ticket registered today (01/07/2020) has an 'originalOrderDate' set to "2020-06-30T22:00:00.000Z"

This 'originalOrderDate' is used when calculating the return's tax rate. So in case the tax rate used has Valid Date From 01/07/2020 no tax is found and error is raised:

Cannot calculate receipt taxes

Cannot find taxes for partner 'CCC' and address 'AAA'. The line affected will be deleted. Please ensure that there is at least one tax rate and tax rate zone configured for the partner address.

Steps To Reproduce

1. Create new Tax Category
2. Create new Tax Rate similar to "Entregas IVA 21%", setting Valid From 01/07/2020 and previous tax category
3. Modify Avalanche Transceiver product to set previous tax category
4. Log into the POS and create new ticket with Avalanche Transceiver product. Realize that the new tax is used
5. Register Verified Return from the previous ticket and realize that "Cannot calculate receipt taxes" error is raised

Tags

No tags attached.

44530_20Q1.diff [^] (589 bytes) 2020-07-28 13:00 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js b/web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
index c2608ab4b..f605ff0c8 100644
--- a/web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
+++ b/web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
@@ -420,7 +420,7 @@
         sql =
           sql +
           " and c_tax.validFrom <= '" +
-          line.get('originalOrderDate') +
+          new Date(line.get('originalOrderDate')) +
           "'";
       } else {
         sql = sql + ' and c_tax.validFrom <= date()';

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

closed

ranjith_qualiantech_com

Taxes are recalculated in Verified Returns receipts and it should not be done

Notes
(0121533) ranjith_qualiantech_com (developer) 2020-07-20 15:02	Not able to reproduce the issue https://drive.google.com/file/d/1a52Znzm5SWs78MQbP9WBhq30SkDazxXK/view?usp=sharing [^]

(0121548) Leyre (developer) 2020-07-21 12:15	To reproduce the issue: Change the system timezone to GMT+2 and test with a Tax Rate valid from today.

(0121555) ranjith_qualiantech_com (developer) 2020-07-22 04:01	Not able to reproduce with GMT+2 timezone https://drive.google.com/file/d/1Yo1Hmn7wWPklvd_3etHY8lztyFYA8pHl/view?usp=sharing [^]

(0121660) adrianromero (manager) 2020-07-28 13:15	This issue is not reproducible because the new taxes engine does not have this problem with dates. Previous versions: RR20Q2, RR20Q1 can be fixed applying the attached patch 44530_20Q1.diff

Issue History
Date Modified	Username	Field	Change
2020-07-01 15:45	maite	New Issue
2020-07-01 15:45	maite	Assigned To	=> Retail
2020-07-01 15:45	maite	Resolution time	=> 1595368800
2020-07-01 15:45	maite	Triggers an Emergency Pack	=> No
2020-07-01 15:46	maite	Issue Monitored: networkb
2020-07-10 06:34	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2020-07-13 08:19	ranjith_qualiantech_com	Status	new => scheduled
2020-07-15 16:18	ngarcia	Issue Monitored: ngarcia
2020-07-20 07:00	ranjith_qualiantech_com	Relationship added	related to 0039864
2020-07-20 15:02	ranjith_qualiantech_com	Note Added: 0121533
2020-07-20 15:02	ranjith_qualiantech_com	Status	scheduled => feedback
2020-07-20 15:02	ranjith_qualiantech_com	Assigned To	ranjith_qualiantech_com => maite
2020-07-21 12:15	Leyre	Note Added: 0121548
2020-07-21 12:15	Leyre	Assigned To	maite => ranjith_qualiantech_com
2020-07-21 12:15	Leyre	Status	feedback => new
2020-07-22 04:01	ranjith_qualiantech_com	Note Added: 0121555
2020-07-22 13:31	adrianromero	Status	new => feedback
2020-07-28 13:00	ranjith_qualiantech_com	File Added: 44530_20Q1.diff
2020-07-28 13:15	adrianromero	Review Assigned To	=> adrianromero
2020-07-28 13:15	adrianromero	Note Added: 0121660
2020-07-28 13:15	adrianromero	Status	feedback => closed
2020-07-28 13:15	adrianromero	Resolution	open => fixed
2020-07-28 13:15	adrianromero	Fixed in Version	=> RR20Q3

Copyright © 2000 - 2009 MantisBT Group