0044522: When partially using a credit note, the identifier is wrong in the credit note printed with the current balance

Description

When partially using a credit note, the identifier is wrong in the credit note printed with the current balance

It seems a regression caused by the following commit:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/6253856cb082ca767eac789045e06b2174cfc849 [^]

Steps To Reproduce

Start the HWM
Log in in https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=PS-1 [^]

Add a product
Return the line
Pay it with credit note payment method

Check the identifier shown in the printed credit note is the same as the one in the Gift Card Instance window of the backoffice

Create a new ticket
Add a product with a price below the credit note balance
Pay it with the previous credit note
Check a new credit note is printed with a different identifier but it is not available in the backoffice (as the gift card instance has the previous search key)

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0121185) hgbot (developer) 2020-07-01 12:21	Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: 7c168c468da9fb986a9e9d21218dadf6bafa2197 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Wed Jul 01 15:50:47 2020 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/7c168c468da9fb986a9e9d21218dadf6bafa2197 [^] Fixed issue-44522: Credit Note searchkey should be updated based on receipt status * When printing Credit Note, if Credit Note is created, then giftCardId is updated with receipt documentNo If Credit Note is consumed, then giftCardId is updated with Credit Note searchKey --- M web/org.openbravo.retail.giftcards/js/hooks/printGiftCardPrePrintHook.js ---

Issue History
Date Modified	Username	Field	Change
2020-06-30 17:38	ngarcia	New Issue
2020-06-30 17:38	ngarcia	Assigned To	=> Retail
2020-06-30 17:38	ngarcia	Resolution time	=> 1595282400
2020-06-30 17:38	ngarcia	Triggers an Emergency Pack	=> No
2020-06-30 17:38	ngarcia	Issue Monitored: networkb
2020-07-01 07:16	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2020-07-01 07:16	ranjith_qualiantech_com	Status	new => scheduled
2020-07-01 12:21	hgbot	Checkin
2020-07-01 12:21	hgbot	Note Added: 0121185
2020-07-01 12:21	hgbot	Status	scheduled => resolved
2020-07-01 12:21	hgbot	Resolution	open => fixed
2020-07-01 12:21	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/7c168c468da9fb986a9e9d21218dadf6bafa2197 [^]
2020-07-01 12:26	marvintm	Review Assigned To	=> marvintm
2020-07-01 12:26	marvintm	Status	resolved => closed
2020-07-01 12:26	marvintm	Fixed in Version	=> RR20Q3