Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044522Retail ModulesGift cards and gift voucherspublic2020-06-30 17:382020-07-01 12:26
Reporterngarcia 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket16718
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044522: When partially using a credit note, the identifier is wrong in the credit note printed with the current balance
DescriptionWhen partially using a credit note, the identifier is wrong in the credit note printed with the current balance

It seems a regression caused by the following commit:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/6253856cb082ca767eac789045e06b2174cfc849 [^]
Steps To ReproduceStart the HWM
Log in in https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=PS-1 [^]

Add a product
Return the line
Pay it with credit note payment method

Check the identifier shown in the printed credit note is the same as the one in the Gift Card Instance window of the backoffice

Create a new ticket
Add a product with a price below the credit note balance
Pay it with the previous credit note
Check a new credit note is printed with a different identifier but it is not available in the backoffice (as the gift card instance has the previous search key)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-06-30 17:38ngarciaNew Issue
2020-06-30 17:38ngarciaAssigned To => Retail
2020-06-30 17:38ngarciaOBNetwork customer => Gold
2020-06-30 17:38ngarciaSupport ticket => 16718
2020-06-30 17:38ngarciaResolution time => 1595282400
2020-06-30 17:38ngarciaTriggers an Emergency Pack => No
2020-06-30 17:38ngarciaIssue Monitored: networkb
2020-07-01 07:16ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-07-01 07:16ranjith_qualiantech_comStatusnew => scheduled
2020-07-01 12:21hgbotCheckin
2020-07-01 12:21hgbotNote Added: 0121185
2020-07-01 12:21hgbotStatusscheduled => resolved
2020-07-01 12:21hgbotResolutionopen => fixed
2020-07-01 12:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/7c168c468da9fb986a9e9d21218dadf6bafa2197 [^]
2020-07-01 12:26marvintmReview Assigned To => marvintm
2020-07-01 12:26marvintmStatusresolved => closed
2020-07-01 12:26marvintmFixed in Version => RR20Q3

Notes
(0121185)
hgbot   
2020-07-01 12:21   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 7c168c468da9fb986a9e9d21218dadf6bafa2197
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jul 01 15:50:47 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/7c168c468da9fb986a9e9d21218dadf6bafa2197 [^]

Fixed issue-44522: Credit Note searchkey should be updated based on receipt status

* When printing Credit Note,
  if Credit Note is created, then giftCardId is updated with receipt documentNo
  If Credit Note is consumed, then giftCardId is updated with Credit Note searchKey

---
M web/org.openbravo.retail.giftcards/js/hooks/printGiftCardPrePrintHook.js
---