Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0004445
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2008-07-17 16:442009-04-21 11:05
ReporterjordimasView Statuspublic 
Assigned ToAinhoaPagola 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision12161
ProjectionnoneETAnoneTarget Version2.50
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0004445: Report Rpt_Etiquetas should be removed

DescriptionHello,

Report Rpt_Etiquetas is currently the only component in Openbravo ERP that has a dependency with CommPortsOpen and the comm.jar.
Proposed SolutionProposed solution:

· Rpt_Etiquetas should be deprecated (alias removed). Nowadays we use Apache FOP to generate barcodes and labels. If still in use by some client, it should be a custom development for that client.

· Remove also the CommPortsOpen.java class and /lib/comm.jar since are no longer necessary.
TagsClean-up, comsup_sprint4
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0004116pi acknowledgediciordia Removed unused AD elements 

-  Notes
(0008336)
jordimas (reporter)
2008-07-18 17:42

Warned to old potential users (Eugeni) of this report that it would be removed in 2.50.
(0008368)
cromero (reporter)
2008-07-22 12:24

This window should be set as custom code
(0012379)
pheenan (reporter)
2009-01-20 11:04

Can also remove this method from HttpSecureAppServlet

public void advise(HttpServletResponse response, String strTitulo,
            String strTexto) throws IOException {
        advise(response, "INFO", strTitulo, strTexto);
    }

Seems to only be referenced by Rpt_Etiquetas, but would pay to check this.
(0012478)
AinhoaPagola (reporter)
2009-01-21 18:13

ABCbPartner, ABCproduct and RptM_production references Rpt_etiquetas. This reports are also not being used anymore and are being deleted aswell.
(0012482)
AinhoaPagola (reporter)
2009-01-21 18:41

The method Phil pointed is also not used anymore.
(0012512)
svnbot (reporter)
2009-01-22 11:44

Repository: openbravo
Revision: 12138
Author: AinhoaPagola
Date: 2009-01-22 11:44:35 +0100 (Thu, 22 Jan 2009)

Fixes bug 0004445 Clean-up related to Rpt_etiquetas done

---
D trunk/lib/runtime/comm.jar
U trunk/referencedata/sampledata/Accounting_Test.xml
U trunk/referencedata/sampledata/BigBazaar.xml
U trunk/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCbPartner.html
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCbPartner.java
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCbPartner.xml
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCbPartner_data.xsql
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCproduct.html
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCproduct.java
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCproduct.xml
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCproduct_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_reports/GenerateModel347.java
D trunk/src/org/openbravo/erpCommon/ad_reports/RptM_Production.java
D trunk/src/org/openbravo/erpCommon/ad_reports/RptM_Production_data.xsql
D trunk/src/org/openbravo/erpCommon/ad_reports/Rpt_Etiquetas.java
D trunk/src/org/openbravo/erpCommon/ad_reports/Rpt_Etiquetas.srpt
D trunk/src/org/openbravo/erpCommon/ad_reports/Rpt_Etiquetas.xml
D trunk/src/org/openbravo/erpCommon/ad_reports/Rpt_Etiquetas_Config.html
D trunk/src/org/openbravo/erpCommon/ad_reports/Rpt_Etiquetas_Config.xml
D trunk/src/org/openbravo/erpCommon/ad_reports/Rpt_Etiquetas_data.xsql
U trunk/src-core/.classpath
D trunk/src-core/src/org/openbravo/utils/CommPortsOpen.java
U trunk/src-db/database/sourcedata/AD_MENU.xml
U trunk/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
U trunk/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
U trunk/src-db/database/sourcedata/AD_PROCESS.xml
U trunk/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
U trunk/src-db/database/sourcedata/AD_TREENODE.xml
---

https://dev.openbravo.com/websvn/openbravo/?rev=12138&sc=1 [^]
(0012515)
AinhoaPagola (reporter)
2009-01-22 11:52

- The following Reports have been deleted:
        *ABCbpartner
        *ABCproduct
        *Rpt_etiquetas
        *RptM_production
This reports have been deleted from the application and their window and menu entry (if any) has been deleted.The sample data has been updated with this info.

- The following library has been deleted:
       *Comm.jar
The file src-core/.classpath has been updated with this info.

- The following method have been deleted from HttpSecureAppServlet:
       *advise(HttpServletResponse, String, String)

- The following report has been modified:
       *GenerateModel347
It had a mistaken dependence to ADCbpartner.

- The following file has been deleted:
       *CommPortsOpen.java
(0012530)
svnbot (reporter)
2009-01-22 15:47

Repository: openbravo
Revision: 12161
Author: huehner
Date: 2009-01-22 15:47:18 +0100 (Thu, 22 Jan 2009)

Issue 4445
Remove reference to now removed comm.jar

---
U trunk/legal/Licensing.txt
---

https://dev.openbravo.com/websvn/openbravo/?rev=12161&sc=1 [^]

- Issue History
Date Modified Username Field Change
2008-07-17 16:44 jordimas New Issue
2008-07-17 16:44 jordimas Assigned To => cromero
2008-07-17 16:44 jordimas sf_bug_id 0 => 2020673
2008-07-17 16:44 jordimas Issue Monitored: jordimas
2008-07-18 17:42 jordimas Note Added: 0008336
2008-07-22 12:22 cromero Tag Attached: Clean-up
2008-07-22 12:24 cromero Status new => scheduled
2008-07-22 12:24 cromero Note Added: 0008368
2008-07-22 12:24 cromero Assigned To cromero => pheenan
2008-07-22 12:24 cromero fix_in_branch => trunk
2008-07-22 12:24 cromero Relationship added related to 0004116
2008-11-13 22:25 rafaroda Assigned To pheenan => Hennadzi
2008-12-16 13:06 PavelPonomarev Assigned To Hennadzi => rafaroda
2009-01-09 20:10 rafaroda Assigned To rafaroda => AinhoaPagola
2009-01-20 11:04 pheenan Note Added: 0012379
2009-01-21 18:13 AinhoaPagola Note Added: 0012478
2009-01-21 18:41 AinhoaPagola Note Added: 0012482
2009-01-22 11:44 svnbot Checkin
2009-01-22 11:44 svnbot Note Added: 0012512
2009-01-22 11:44 svnbot Status scheduled => resolved
2009-01-22 11:44 svnbot Resolution open => fixed
2009-01-22 11:44 svnbot svn_revision => 12138
2009-01-22 11:52 AinhoaPagola Note Added: 0012515
2009-01-22 15:47 svnbot Checkin
2009-01-22 15:47 svnbot Note Added: 0012530
2009-01-22 15:47 svnbot svn_revision 12138 => 12161
2009-01-23 11:31 AinhoaPagola Tag Attached: comsup_sprint4
2009-04-21 11:05 psarobe Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker