Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004445Openbravo ERPA. Platformpublic2008-07-17 16:442009-04-21 11:05
Reporterjordimas 
Assigned ToAinhoaPagola 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version2.50Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0004445: Report Rpt_Etiquetas should be removed
DescriptionHello,

Report Rpt_Etiquetas is currently the only component in Openbravo ERP that has a dependency with CommPortsOpen and the comm.jar.
Steps To Reproduce
Proposed SolutionProposed solution:

· Rpt_Etiquetas should be deprecated (alias removed). Nowadays we use Apache FOP to generate barcodes and labels. If still in use by some client, it should be a custom development for that client.

· Remove also the CommPortsOpen.java class and /lib/comm.jar since are no longer necessary.
Additional Information
TagsClean-up, comsup_sprint4
Relationships
related to feature request 0004116pi acknowledged iciordia Removed unused AD elements 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-07-17 16:44jordimasNew Issue
2008-07-17 16:44jordimasAssigned To => cromero
2008-07-17 16:44jordimassf_bug_id0 => 2020673
2008-07-17 16:44jordimasIssue Monitored: jordimas
2008-07-18 17:42jordimasNote Added: 0008336
2008-07-22 12:22cromeroTag Attached: Clean-up
2008-07-22 12:24cromeroStatusnew => scheduled
2008-07-22 12:24cromeroNote Added: 0008368
2008-07-22 12:24cromeroAssigned Tocromero => pheenan
2008-07-22 12:24cromerofix_in_branch => trunk
2008-07-22 12:24cromeroRelationship addedrelated to 0004116
2008-11-13 22:25rafarodaAssigned Topheenan => Hennadzi
2008-12-16 13:06PavelPonomarevAssigned ToHennadzi => rafaroda
2009-01-09 20:10rafarodaAssigned Torafaroda => AinhoaPagola
2009-01-20 11:04pheenanNote Added: 0012379
2009-01-21 18:13AinhoaPagolaNote Added: 0012478
2009-01-21 18:41AinhoaPagolaNote Added: 0012482
2009-01-22 11:44svnbotCheckin
2009-01-22 11:44svnbotNote Added: 0012512
2009-01-22 11:44svnbotStatusscheduled => resolved
2009-01-22 11:44svnbotResolutionopen => fixed
2009-01-22 11:44svnbotsvn_revision => 12138
2009-01-22 11:52AinhoaPagolaNote Added: 0012515
2009-01-22 15:47svnbotCheckin
2009-01-22 15:47svnbotNote Added: 0012530
2009-01-22 15:47svnbotsvn_revision12138 => 12161
2009-01-23 11:31AinhoaPagolaTag Attached: comsup_sprint4
2009-04-21 11:05psarobeStatusresolved => closed

Notes
(0008336)
jordimas   
2008-07-18 17:42   
Warned to old potential users (Eugeni) of this report that it would be removed in 2.50.
(0008368)
cromero   
2008-07-22 12:24   
This window should be set as custom code
(0012379)
pheenan   
2009-01-20 11:04   
Can also remove this method from HttpSecureAppServlet

public void advise(HttpServletResponse response, String strTitulo,
            String strTexto) throws IOException {
        advise(response, "INFO", strTitulo, strTexto);
    }

Seems to only be referenced by Rpt_Etiquetas, but would pay to check this.
(0012478)
AinhoaPagola   
2009-01-21 18:13   
ABCbPartner, ABCproduct and RptM_production references Rpt_etiquetas. This reports are also not being used anymore and are being deleted aswell.
(0012482)
AinhoaPagola   
2009-01-21 18:41   
The method Phil pointed is also not used anymore.
(0012512)
svnbot   
2009-01-22 11:44   
Repository: openbravo
Revision: 12138
Author: AinhoaPagola
Date: 2009-01-22 11:44:35 +0100 (Thu, 22 Jan 2009)

Fixes bug 0004445 Clean-up related to Rpt_etiquetas done

---
D trunk/lib/runtime/comm.jar
U trunk/referencedata/sampledata/Accounting_Test.xml
U trunk/referencedata/sampledata/BigBazaar.xml
U trunk/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCbPartner.html
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCbPartner.java
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCbPartner.xml
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCbPartner_data.xsql
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCproduct.html
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCproduct.java
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCproduct.xml
D trunk/src/org/openbravo/erpCommon/ad_reports/ABCproduct_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_reports/GenerateModel347.java
D trunk/src/org/openbravo/erpCommon/ad_reports/RptM_Production.java
D trunk/src/org/openbravo/erpCommon/ad_reports/RptM_Production_data.xsql
D trunk/src/org/openbravo/erpCommon/ad_reports/Rpt_Etiquetas.java
D trunk/src/org/openbravo/erpCommon/ad_reports/Rpt_Etiquetas.srpt
D trunk/src/org/openbravo/erpCommon/ad_reports/Rpt_Etiquetas.xml
D trunk/src/org/openbravo/erpCommon/ad_reports/Rpt_Etiquetas_Config.html
D trunk/src/org/openbravo/erpCommon/ad_reports/Rpt_Etiquetas_Config.xml
D trunk/src/org/openbravo/erpCommon/ad_reports/Rpt_Etiquetas_data.xsql
U trunk/src-core/.classpath
D trunk/src-core/src/org/openbravo/utils/CommPortsOpen.java
U trunk/src-db/database/sourcedata/AD_MENU.xml
U trunk/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
U trunk/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
U trunk/src-db/database/sourcedata/AD_PROCESS.xml
U trunk/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
U trunk/src-db/database/sourcedata/AD_TREENODE.xml
---

https://dev.openbravo.com/websvn/openbravo/?rev=12138&sc=1 [^]
(0012515)
AinhoaPagola   
2009-01-22 11:52   
- The following Reports have been deleted:
        *ABCbpartner
        *ABCproduct
        *Rpt_etiquetas
        *RptM_production
This reports have been deleted from the application and their window and menu entry (if any) has been deleted.The sample data has been updated with this info.

- The following library has been deleted:
       *Comm.jar
The file src-core/.classpath has been updated with this info.

- The following method have been deleted from HttpSecureAppServlet:
       *advise(HttpServletResponse, String, String)

- The following report has been modified:
       *GenerateModel347
It had a mistaken dependence to ADCbpartner.

- The following file has been deleted:
       *CommPortsOpen.java
(0012530)
svnbot   
2009-01-22 15:47   
Repository: openbravo
Revision: 12161
Author: huehner
Date: 2009-01-22 15:47:18 +0100 (Thu, 22 Jan 2009)

Issue 4445
Remove reference to now removed comm.jar

---
U trunk/legal/Licensing.txt
---

https://dev.openbravo.com/websvn/openbravo/?rev=12161&sc=1 [^]