Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044420
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2020-06-18 22:372020-06-26 15:24
ReporterlbressanView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR20Q3
StatusclosedFix in branchFixed in SCM revision233e6552a4b8
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionRR19Q4SCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket16643
Regression level
Regression date
Regression introduced in releaseRR19Q1
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044420: The modification of the lines in the hook OrderLoaderPreProcessHook does not take effect

DescriptionThe hook OrderLoaderPreProcessHook has been implemented, I have made a modification in the attributes of the lines and it does not take effect, because the orderLoader class does a new JSONArray to keep the lines of the order instead of performing aliasing.

the main flow affected is the generation of sales orders from the pos.

We found the issue / commit that introduces the change that affects the behavior of "OrderLoaderPreProcessHook" was:
https://issues.openbravo.com/view.php?id=39352 [^]
commit: 1e81317f98de8f93ade73734f15864d98e11473f
Steps To ReproduceSteps to reproduce on ( standard environment strongly advised)?

1- implement the OrderLoaderPreProcessHook hook
2- make a modification in the attribute-value of the lines
3- see that the change does not appear since they are different objects

see example.png
Proposed Solutionuse aliasing as it was before the above-mentioned commit:

JSONArray orderlines = jsonorder.getJSONArray("lines");
TagsNo tags attached.
Attached Filespng file icon example.png [^] (63,485 bytes) 2020-06-18 22:37

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0121133)
hgbot (developer)
2020-06-26 15:06

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b12af6f18d4d7ebc5cb5e98e16f7d1f1e89491ab
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 26 18:34:08 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b12af6f18d4d7ebc5cb5e98e16f7d1f1e89491ab [^]

Related to issue-44420: JSON lines should not copied in OrderLoader

* JSON lines will be modified in hooks, so lines should not be copied
  because original jso should be saved in errors table if sync process failed

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0121134)
hgbot (developer)
2020-06-26 15:07

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 233e6552a4b8ac178e91c6b6961b034ccd02c51a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 26 18:34:21 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/233e6552a4b8ac178e91c6b6961b034ccd02c51a [^]

Fixed issue-44420: Copy of JSON should be used for DataSynchronizationProcess

* If any error occurs in the DataSynchronizationProcess,
  original json should be saved in errors table

---
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
---

- Issue History
Date Modified Username Field Change
2020-06-18 22:37 lbressan New Issue
2020-06-18 22:37 lbressan Assigned To => Retail
2020-06-18 22:37 lbressan File Added: example.png
2020-06-18 22:37 lbressan OBNetwork customer => OBPS
2020-06-18 22:37 lbressan Support ticket => 16643
2020-06-18 22:37 lbressan Resolution time => 1593640800
2020-06-18 22:37 lbressan Regression introduced in release => RR19Q1
2020-06-18 22:37 lbressan Triggers an Emergency Pack => No
2020-06-18 22:38 lbressan Target Version RR19Q4.4 => pi
2020-06-24 08:14 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2020-06-26 15:06 hgbot Checkin
2020-06-26 15:06 hgbot Note Added: 0121133
2020-06-26 15:07 hgbot Checkin
2020-06-26 15:07 hgbot Note Added: 0121134
2020-06-26 15:07 hgbot Status new => resolved
2020-06-26 15:07 hgbot Resolution open => fixed
2020-06-26 15:07 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/233e6552a4b8ac178e91c6b6961b034ccd02c51a [^]
2020-06-26 15:24 marvintm Review Assigned To => marvintm
2020-06-26 15:24 marvintm Status resolved => closed
2020-06-26 15:24 marvintm Fixed in Version => RR20Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker