0044408: [CRMConnector] After modifying properties through onPropertyValueChange values are not internally reflected

Description

After modifying properties through onPropertyValueChange values are not internally reflected and validations fails

Steps To Reproduce

Using module
org.openbravo.retail.samplebpintegration

include in file org.openbravo.retail.samplebpintegration/js/SampleBPIntegrationProxy.js
the following code

async onPropertyValueChange(businessPartner, property, config) {
+ if (property.apiKey === 'xName' && property.value === 'GAL') {
+ let newBp = businessPartner.clone();
+ return new Promise(function(resolve) {
+ setTimeout(() => {
+ newBp.getPropertyByKey('xLastName').value = '@galopenbravo';
+ newBp.getPropertyByKey('xVIP').value = true;
+ newBp.getPropertyByKey('xAddress').value = 'Main Street London';
+ newBp.getPropertyByKey('xPhone').value = '987456123';
+ newBp.getPropertyByKey('xEmail').value = 'gal@openbravo.com';
+ newBp.getPropertyByKey('xBirthday').value = '1984-11-16';
+ resolve(newBp);
+ }, 1000);
+ });
+ }

Proposed Solution

The object managed by main popup should be updated with the new one

Tags

No tags attached.

Attached Files

issue44408.diff [^] (1,996 bytes) 2020-06-18 10:55 [Show Content] [Hide Content]

diff -r df469ef5e543 web/org.openbravo.retail.posterminal/js/components/externalbusinesspartner_viewedit.js
--- a/web/org.openbravo.retail.posterminal/js/components/externalbusinesspartner_viewedit.js	Wed Jun 17 20:55:34 2020 +0530
+++ b/web/org.openbravo.retail.posterminal/js/components/externalbusinesspartner_viewedit.js	Thu Jun 18 10:55:31 2020 +0200
@@ -259,7 +259,7 @@
     return true;
   },
   change: function(inSender, inEvent) {
-    const execution = OB.UTIL.ProcessController.start(
+    const processExecution = OB.UTIL.ProcessController.start(
       'obpos_extbp_propertychanged'
     );
     this.inherited(arguments);
@@ -276,12 +276,21 @@
       this.bp,
       this.bpProperty
     )
-      .then(() => {})
+      .then(retBp => {
+        if (
+          JSON.stringify(retBp.getPropertiesList()) !==
+          JSON.stringify(this.bp.getPropertiesList())
+        ) {
+          this.bp = retBp;
+          processExecution.reDraw = true;
+          processExecution.newBp = retBp;
+        }
+      })
       .catch(errorObj => {})
       .finally(() => {
         OB.UTIL.ProcessController.finish(
           'obpos_extbp_propertychanged',
-          execution
+          processExecution
         );
       });
     return true;
@@ -377,7 +386,16 @@
       this.bp,
       this.bpProperty
     )
-      .then(() => {})
+      .then(retBp => {
+        if (
+          JSON.stringify(retBp.getPropertiesList()) !==
+          JSON.stringify(this.bp.getPropertiesList())
+        ) {
+          this.bp = retBp;
+          processExecution.reDraw = true;
+          processExecution.newBp = retBp;
+        }
+      })
       .catch(errorObj => {})
       .finally(() => {
         OB.UTIL.ProcessController.finish(
@@ -563,6 +581,7 @@
       processExecution.reDraw
     ) {
       this.drawBp(processExecution.newBp);
+      this.dialog.configDataManager.bp = processExecution.newBp;
     }
     if (
       process.get('searchkey') === 'obpos_extbp_propertychanged' ||

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0120909) hgbot (developer) 2020-06-19 08:42	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 79dc12070a2179bbd990e03bb0dc87253cce7605 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Fri Jun 19 08:41:43 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79dc12070a2179bbd990e03bb0dc87253cce7605 [^] Fixed BUG 44408: When extBP properties are updated from API they are not reflected in sent object --- M web/org.openbravo.retail.posterminal/js/components/externalbusinesspartner_viewedit.js ---

Issue History
Date Modified	Username	Field	Change
2020-06-18 10:54	guilleaer	New Issue
2020-06-18 10:54	guilleaer	Assigned To	=> guilleaer
2020-06-18 10:54	guilleaer	Triggers an Emergency Pack	=> No
2020-06-18 10:55	guilleaer	File Added: issue44408.diff
2020-06-19 08:42	hgbot	Checkin
2020-06-19 08:42	hgbot	Note Added: 0120909
2020-06-19 08:42	hgbot	Status	new => resolved
2020-06-19 08:42	hgbot	Resolution	open => fixed
2020-06-19 08:42	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79dc12070a2179bbd990e03bb0dc87253cce7605 [^]
2020-06-29 08:25	marvintm	Review Assigned To	=> marvintm
2020-06-29 08:25	marvintm	Status	resolved => closed
2020-06-29 08:25	marvintm	Fixed in Version	=> RR20Q3