Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044340
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2020-06-10 18:212020-06-15 08:31
ReporteraferrazView Statuspublic 
Assigned Toaferraz 
PrioritynormalResolutionfixedFixed in VersionRR20Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044340: Use same API in Discount and Tax engine output - Tax engine changes

DescriptionUse same Ticket API in Discount and Tax engine output
Steps To Reproduce*
Proposed SolutionCurrent Tax engine output is as follows:
{
  "header": {
    "id": null,
    "grossAmount": 261.81,
    "netAmount": 216.37,
    "taxes": [
      {
        "base": 216.37,
        "amount": 45.44,
        "tax": {
          "id": "5235D8E99A2749EFA17A5C92A52AEFC6",
          ...
        }
      }
    ]
  },
  "lines": [
    {
      "id": "BBC8BD559F1F6830AF7998A180F8D9DA",
      "grossUnitAmount": 261.81,
      "netUnitAmount": 216.37,
      "grossUnitPrice": 261.81,
      "netUnitPrice": 216.37,
      "qty": 1,
      "tax": "5235D8E99A2749EFA17A5C92A52AEFC6",
      "taxRate": 1.21,
      "taxes": [
        {
          "base": 216.37,
          "amount": 45.44,
          "tax": {
            "id": "5235D8E99A2749EFA17A5C92A52AEFC6",
            ...
          }
        }
      ]
    }
  ]
}

Remove header property so it is similar to Ticket API:
{
  "id": null,
  "grossAmount": 261.81,
  "netAmount": 216.37,
  "taxes": [
    {
      "base": 216.37,
      "amount": 45.44,
      "tax": {
        "id": "5235D8E99A2749EFA17A5C92A52AEFC6",
        ...
      }
    }
  ],
  "lines": [
    {
      "id": "BBC8BD559F1F6830AF7998A180F8D9DA",
      "grossUnitAmount": 261.81,
      "netUnitAmount": 216.37,
      "grossUnitPrice": 261.81,
      "netUnitPrice": 216.37,
      "qty": 1,
      "tax": "5235D8E99A2749EFA17A5C92A52AEFC6",
      "taxRate": 1.21,
      "taxes": [
        {
          "base": 216.37,
          "amount": 45.44,
          "tax": {
            "id": "5235D8E99A2749EFA17A5C92A52AEFC6",
            ...
          }
        }
      ]
    }
  ]
}

Add also taxengine namespace when running the engine from graal/node/webservice:
{
  "ticket": {
    "taxengine": {
      "grossAmount": 261.81,
      "netAmount": 216.37,
      "taxes": [...],
      "lines": [
        {
          "id": "BBC8BD559F1F6830AF7998A180F8D9DA",
          "grossUnitAmount": 261.81,
          "netUnitAmount": 216.37,
          "grossUnitPrice": 261.81,
          "netUnitPrice": 216.37,
          "qty": 1,
          "tax": "5235D8E99A2749EFA17A5C92A52AEFC6",
          "taxRate": 1.21,
          "taxes": [...]
        }
      ]
    }
  }
}
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0044156RR20Q3 closedaferraz Use same Ticket API in Discount and Tax engine - Tax engine changes 
related to defect 0044181RR20Q3 closedaferraz Use same Ticket API in Discount and Tax engine - Discount engine changes 
related to defect 0044339 closedaferraz Use same API in Discount and Tax engine output - Discount engine changes 

-  Notes
(0120809)
hgbot (developer)
2020-06-12 08:44

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bcfcfcbcca40bf1a75eaa0e8f243245d18bddc0a
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 10 18:50:05 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bcfcfcbcca40bf1a75eaa0e8f243245d18bddc0a [^]

Related to ISSUE-44340: Change tax engine result structure

---
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
M web/org.openbravo.retail.posterminal/js/taxesengine/pos/pos-taxes.js
---
(0120814)
hgbot (developer)
2020-06-12 08:55

 Repository: erp/pmods/org.openbravo.taxes
Changeset: fb59f816e3855624debf8a0fcf5c4829746cdb56
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Jun 12 08:53:28 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.taxes/rev/fb59f816e3855624debf8a0fcf5c4829746cdb56 [^]

Related to ISSUE-44340: Change tax engine result structure

---
M src-test/org/openbravo/taxes/test/base/TaxesResult.java
---
(0120815)
hgbot (developer)
2020-06-12 08:57

 Repository: erp/pmods/org.openbravo.taxes
Changeset: ccf25a87da4b91280fef4a8de56757bd709c21e2
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Jun 12 08:54:00 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.taxes/rev/ccf25a87da4b91280fef4a8de56757bd709c21e2 [^]

Related to ISSUE-44340: Add taxengine namespace

---
M src-test/org/openbravo/taxes/test/base/executor/NodeTaxesExecutor.java
M src-test/org/openbravo/taxes/test/base/executor/TaxesCalculator.java
M src/org/openbravo/taxes/engine/graal/GraalTaxesExecutor.java
---

- Issue History
Date Modified Username Field Change
2020-06-10 18:21 aferraz New Issue
2020-06-10 18:21 aferraz Assigned To => aferraz
2020-06-10 18:21 aferraz OBNetwork customer => No
2020-06-10 18:21 aferraz Triggers an Emergency Pack => No
2020-06-10 18:21 aferraz Issue generated from 0044339
2020-06-10 18:21 aferraz Relationship added related to 0044156
2020-06-10 18:21 aferraz Relationship added related to 0044181
2020-06-10 18:22 aferraz Relationship added related to 0044339
2020-06-12 08:44 hgbot Checkin
2020-06-12 08:44 hgbot Note Added: 0120809
2020-06-12 08:47 aferraz Note Added: 0120810
2020-06-12 08:48 aferraz Note Deleted: 0120810
2020-06-12 08:50 aferraz Proposed Solution updated
2020-06-12 08:55 hgbot Checkin
2020-06-12 08:55 hgbot Note Added: 0120814
2020-06-12 08:57 hgbot Checkin
2020-06-12 08:57 hgbot Note Added: 0120815
2020-06-12 09:22 aferraz Proposed Solution updated
2020-06-12 09:53 aferraz Status new => scheduled
2020-06-12 09:53 aferraz Status scheduled => resolved
2020-06-12 09:53 aferraz Fixed in Version => RR20Q3
2020-06-12 09:53 aferraz Resolution open => fixed
2020-06-15 08:31 marvintm Review Assigned To => marvintm
2020-06-15 08:31 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker