Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0044220 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Advanced Warehouse Operations | minor | have not tried | 2020-05-28 11:32 | 2020-06-05 13:26 | |||
| Reporter | inigo_lerga | View Status | public | |||||
| Assigned To | inigo_lerga | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 677aa6517b74 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | dmiguelez | |||||||
| Support ticket | ||||||||
| OBNetwork customer | No | |||||||
| Regression introduced in release | ||||||||
| Summary | 0044220: Apply new HQL Style in TGC_DOR_Receipt.java | |||||||
| Description | TGC_DOR_Receipt.java has HQL queries with: - the HQL is hard to read because of formatting - and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0120392) inigo_lerga (viewer) 2020-05-28 12:04 edited on: 2020-05-28 12:57 |
--Test Plan Mantis HQL-- Beforehand, the environment needs to have AWO modules installed and working. As the AWO-QA Admin - AWO-QA role in Backend: - Go to Distribution Order Issue window and create a new record for Organization US East Coast with "US East Coast" as Warehouse Issue and "US East Coast" as Warehouse Receipt. Go to Lines Tab and create a new Line with "Ale Beer" as Product and 5 units as Operative Quantity. Save and Book the record. Press the Issue button and assign the task to AWO_US_E user. As the AWO_US_E user in AWO Front End: - Confirm the previously created Task in the available Tasks list. As the AWO_US_W user in AWO Front End: - Press the Receive button and paste into the search bar the Searchkey of the Distribution Order Receipt generated in pair with the previously created Distribution Order Issue. Press the find button. #In this moment the modified HQL is executed# |
|
(0120705) hgbot (developer) 2020-06-05 13:25 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders Changeset: 677aa6517b747748a0c81469459fbf362f77e690 Author: Iñigo Lerga <inigo.lerga <at> openbravo.com> Date: Thu May 28 13:00:30 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/677aa6517b747748a0c81469459fbf362f77e690 [^] fixes BUG-44220:Applied new HQL Style --- M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/feHooks/TGC_DOR_Receipt.java --- |
|
(0120706) hgbot (developer) 2020-06-05 13:25 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders Changeset: eed855fc4d3308b55899e6a36c6294cf9773ce57 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Fri Jun 05 13:24:33 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/eed855fc4d3308b55899e6a36c6294cf9773ce57 [^] Related to ISSUE-44220. Extracted logic into it's own method and changed some query formatting to improve redability --- M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/feHooks/TGC_DOR_Receipt.java --- |
|
(0120707) dmiguelez (viewer) 2020-06-05 13:26 |
Code Review + Testing Ok |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-05-28 11:32 | inigo_lerga | New Issue | |
| 2020-05-28 11:32 | inigo_lerga | Assigned To | => inigo_lerga |
| 2020-05-28 11:32 | inigo_lerga | OBNetwork customer | => No |
| 2020-05-28 11:32 | inigo_lerga | Relationship added | related to 0041287 |
| 2020-05-28 11:32 | inigo_lerga | Status | new => scheduled |
| 2020-05-28 12:04 | inigo_lerga | Note Added: 0120392 | |
| 2020-05-28 12:57 | inigo_lerga | Note Edited: 0120392 | View Revisions |
| 2020-06-05 13:25 | hgbot | Checkin | |
| 2020-06-05 13:25 | hgbot | Note Added: 0120705 | |
| 2020-06-05 13:25 | hgbot | Status | scheduled => resolved |
| 2020-06-05 13:25 | hgbot | Resolution | open => fixed |
| 2020-06-05 13:25 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/677aa6517b747748a0c81469459fbf362f77e690 [^] |
| 2020-06-05 13:25 | hgbot | Checkin | |
| 2020-06-05 13:25 | hgbot | Note Added: 0120706 | |
| 2020-06-05 13:26 | dmiguelez | Review Assigned To | => dmiguelez |
| 2020-06-05 13:26 | dmiguelez | Note Added: 0120707 | |
| 2020-06-05 13:26 | dmiguelez | Status | resolved => closed |
| 2022-09-06 17:18 | caristu | Category | Advance Warehouse Operations => Advanced Warehouse Operations |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |