Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0044192 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Advanced Warehouse Operations | minor | have not tried | 2020-05-26 15:37 | 2020-06-05 12:56 | |||
| Reporter | inigo_lerga | View Status | public | |||||
| Assigned To | inigo_lerga | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 6aa669ba7fce | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | dmiguelez | |||||||
| Regression introduced in release | ||||||||
| Summary | 0044192: Apply new HQL Style in TGC_DOI_Pick.java | |||||||
| Description | TGC_DOI_Pick.java has HQL queries with: - the HQL is hard to read because of formatting - and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0120343) inigo_lerga (reporter) 2020-05-27 10:28 |
--Test Plan Mantis HQL-- Beforehand, the environment needs to have AWO modules installed and working. As the AWO-QA Admin - AWO-QA role in Backend: - Go to Distribution Order Issue window and create a new record with "US West Coast" as Warehouse Issue and "US East Coast" as Warehouse Receipt. Go to Lines Tab and create a new Line with "Ale Beer" as Product and 5 units as Operative Quantity. Save and Book the record. As the AWO_US_W user in AWO Front End: - Press the Pick button and paste the previous Distribution Order Search Key in the search bar. Press the Search button. #In this moment the modified HQL is executed# |
|
(0120702) hgbot (developer) 2020-06-05 12:55 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders Changeset: 6aa669ba7fce0ccf3bba83652ba21bca9af63730 Author: Iñigo Lerga <inigo.lerga <at> openbravo.com> Date: Wed May 27 10:32:41 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/6aa669ba7fce0ccf3bba83652ba21bca9af63730 [^] fixes BUG-44192:Applied new HQL Style --- M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/feHooks/TGC_DOI_Pick.java --- |
|
(0120703) hgbot (developer) 2020-06-05 12:55 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders Changeset: f09676118ddd55ae70246657db31bc2a539ea00d Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Fri Jun 05 12:55:23 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/f09676118ddd55ae70246657db31bc2a539ea00d [^] Related to ISSUE-44192. Extracted logic into it's own method and changed some query formatting to improve redability --- M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/feHooks/TGC_DOI_Pick.java --- |
|
(0120704) dmiguelez (developer) 2020-06-05 12:56 |
Code Review + Testing Ok |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-05-26 15:37 | inigo_lerga | New Issue | |
| 2020-05-26 15:37 | inigo_lerga | Assigned To | => inigo_lerga |
| 2020-05-26 15:38 | inigo_lerga | Relationship added | related to 0041287 |
| 2020-05-27 09:19 | inigo_lerga | Status | new => scheduled |
| 2020-05-27 10:28 | inigo_lerga | Note Added: 0120343 | |
| 2020-06-05 12:55 | hgbot | Checkin | |
| 2020-06-05 12:55 | hgbot | Note Added: 0120702 | |
| 2020-06-05 12:55 | hgbot | Status | scheduled => resolved |
| 2020-06-05 12:55 | hgbot | Resolution | open => fixed |
| 2020-06-05 12:55 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/6aa669ba7fce0ccf3bba83652ba21bca9af63730 [^] |
| 2020-06-05 12:55 | hgbot | Checkin | |
| 2020-06-05 12:55 | hgbot | Note Added: 0120703 | |
| 2020-06-05 12:56 | dmiguelez | Review Assigned To | => dmiguelez |
| 2020-06-05 12:56 | dmiguelez | Note Added: 0120704 | |
| 2020-06-05 12:56 | dmiguelez | Status | resolved => closed |
| 2022-09-06 17:18 | caristu | Category | Advance Warehouse Operations => Advanced Warehouse Operations |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |