Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044066
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-14 13:552020-06-01 13:19
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionaa88582180ba
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary

0044066: Apply new HQL Style in ToleranceManagerDAO.java

DescriptionToleranceManagerDAO.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0119938)
inigo_lerga (viewer)
2020-05-15 11:55
edited on: 2020-06-01 13:17

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

For the first hql:
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs is executed#

For the second hql:
As the AWO-QA Admin - AWO-QA role:
  - Go to the Product window and open any of the products with the name like "aWOh010-"
    Enable the Is Quantity Variable Checkbox.
  - Go to Warehouse Definition window and open the
    "US West Coast" Warehouse.
    Go to Tolerances Tab and create a new record with "Picking Sales Order"
    as Inventory Transaction Type. Set 50 as Positive Tolerance and
    the previously modified product as Product. Leave the rest of the fields empty.
    Save the record.
  - Go to Sales Order window and create a new record for US West Coast
    organization. Set "Healthy Food Supermarkets, Co." as Business Partner.
    Go to Lines Tab and create a new record with the previously modified product as the product and
    10 units as Ordered Quantity.
    Book the Sales Order.
    Press the Pick button and set "AWO_US_W" as Assigned field. Press Done.
  - Go to Batch of Tasks window and open the previously generated Batch of Tasks
    from the previous step.
    Go to Task Tab and set 12 as Confirmed Quantity in the only line available.
    Press the Confirm button and enable option "Override User Assignment".
    Press Done.
#In this moment the modified HQL is executed#
(0120486)
hgbot (developer)
2020-06-01 13:18

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: aa88582180ba58ee83bd10709795df2a198bfabe
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 15 12:03:25 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/aa88582180ba58ee83bd10709795df2a198bfabe [^]

fixes BUG-44066:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/ToleranceManagerDAO.java
---
(0120487)
hgbot (developer)
2020-06-01 13:18

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 15ae7c3923253824cf322f0a523a3f0c9f1b02b4
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jun 01 13:18:16 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/15ae7c3923253824cf322f0a523a3f0c9f1b02b4 [^]

Related to ISSUE-44066. Changed formatting of the query to improve redability.
Removed unnecessary variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/ToleranceManagerDAO.java
---
(0120488)
dmiguelez (viewer)
2020-06-01 13:19

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-14 13:55 inigo_lerga New Issue
2020-05-14 13:55 inigo_lerga Assigned To => inigo_lerga
2020-05-14 13:55 inigo_lerga OBNetwork customer => No
2020-05-14 13:55 inigo_lerga Relationship added related to 0041287
2020-05-14 13:55 inigo_lerga Status new => scheduled
2020-05-15 11:55 inigo_lerga Note Added: 0119938
2020-06-01 13:17 dmiguelez Note Edited: 0119938 View Revisions
2020-06-01 13:18 hgbot Checkin
2020-06-01 13:18 hgbot Note Added: 0120486
2020-06-01 13:18 hgbot Status scheduled => resolved
2020-06-01 13:18 hgbot Resolution open => fixed
2020-06-01 13:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/aa88582180ba58ee83bd10709795df2a198bfabe [^]
2020-06-01 13:18 hgbot Checkin
2020-06-01 13:18 hgbot Note Added: 0120487
2020-06-01 13:19 dmiguelez Review Assigned To => dmiguelez
2020-06-01 13:19 dmiguelez Note Added: 0120488
2020-06-01 13:19 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker