Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044029
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-11 16:382020-05-21 13:38
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiondbd199622293
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044029: Apply new HQL Style in BoxGeneratorProcessor.java

DescriptionBoxGeneratorProcessor.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0120085)
inigo_lerga (reporter)
2020-05-20 10:02

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO_US_W user in AWO Front End:
  - Press the Box button and Create New Refence.
    Set any Reference number desired and Big Box
    as Reference Type.
    Press Create & Box.
  - Press the Add button in and search for "SHP301".
    Select Bucanero Beer.
    Set "SHP301" as Bin.
    Press Confirm.
#In this moment two of the modified HQLs are executed#
(0120132)
hgbot (developer)
2020-05-21 13:36

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: dbd19962229326e460318069e441c39d41909a36
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed May 20 09:59:08 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/dbd19962229326e460318069e441c39d41909a36 [^]

fixes BUG-44029:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/processors/BoxGeneratorProcessor.java
---
(0120133)
hgbot (developer)
2020-05-21 13:36

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 933ea22f2a0b328d0c61f849f0b8a1e90cf47545
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu May 21 13:36:46 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/933ea22f2a0b328d0c61f849f0b8a1e90cf47545 [^]

Related to ISSUE-44029. Remove commented code

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/processors/BoxGeneratorProcessor.java
---
(0120134)
dmiguelez (developer)
2020-05-21 13:38

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-11 16:38 inigo_lerga New Issue
2020-05-11 16:38 inigo_lerga Assigned To => inigo_lerga
2020-05-11 16:39 inigo_lerga Relationship added related to 0041287
2020-05-11 16:39 inigo_lerga Status new => scheduled
2020-05-20 10:02 inigo_lerga Note Added: 0120085
2020-05-21 13:36 hgbot Checkin
2020-05-21 13:36 hgbot Note Added: 0120132
2020-05-21 13:36 hgbot Status scheduled => resolved
2020-05-21 13:36 hgbot Resolution open => fixed
2020-05-21 13:36 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/dbd19962229326e460318069e441c39d41909a36 [^]
2020-05-21 13:36 hgbot Checkin
2020-05-21 13:36 hgbot Note Added: 0120133
2020-05-21 13:38 dmiguelez Review Assigned To => dmiguelez
2020-05-21 13:38 dmiguelez Note Added: 0120134
2020-05-21 13:38 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker