0044000: Display Logic does not work for standar loyalty fields

Description

When checking 'displayLogic' for each component, only the new attributes are checked.
the standar attributes are assigned to a variable called 'fields'.
The next links shows where the problem is:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/file/tip/web/org.openbravo.retail.loyalty.programs/js/view/subscription-create-form.js#l199 [^]

Steps To Reproduce

1. Add a display logic for a field, for example: OBRLP.UI.Subscriptions.CreateSubscriptionForm.prototype.fields.find(field => field.name === 'createSubCardNumber').displayLogic = function() {
return false;
};

2. Log in in the POS and try to simply create a loyalty program for a customer.
3. the function doesn't check the field, so the field is always displayed.

Proposed Solution

1. Concatenate the fields :
const fields = this.fields.concat(this.newAttributes);

2. Change the name of the array of the fields for "newAtributes":
https://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/file/tip/web/org.openbravo.retail.loyalty.programs/js/view/subscription-create-form.js#l99 [^]

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0119725) hgbot (developer) 2020-05-11 08:27	Repository: erp/pmods/org.openbravo.retail.loyalty.programs Changeset: 7e29fb688725ac52c8cdb5e5f08cd2ad7ca81334 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon May 11 11:56:51 2020 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/rev/7e29fb688725ac52c8cdb5e5f08cd2ad7ca81334 [^] Related to issue 44000 : Displaylogic should be executed for Loyalty Card fields * Displaylogic should be executed for extra fields ans as well default fields --- M web/org.openbravo.retail.loyalty.programs/js/view/subscription-create-form.js ---

Issue History
Date Modified	Username	Field	Change
2020-05-08 11:15	leyre-iriarte	New Issue
2020-05-08 11:15	leyre-iriarte	Assigned To	=> Retail
2020-05-08 11:15	leyre-iriarte	OBNetwork customer	=> Gold
2020-05-08 11:15	leyre-iriarte	Resolution time	=> 1590098400
2020-05-08 11:15	leyre-iriarte	Triggers an Emergency Pack	=> No
2020-05-08 13:32	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2020-05-11 08:27	hgbot	Checkin
2020-05-11 08:27	hgbot	Note Added: 0119725
2020-05-11 08:29	ranjith_qualiantech_com	Status	new => scheduled
2020-05-12 08:24	ranjith_qualiantech_com	Status	scheduled => resolved
2020-05-12 08:24	ranjith_qualiantech_com	Resolution	open => fixed
2020-05-15 09:35	marvintm	Review Assigned To	=> marvintm
2020-05-15 09:35	marvintm	Status	resolved => closed
2020-05-15 09:35	marvintm	Fixed in Version	=> RR20Q3