Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043952
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] A. Platformminorhave not tried2020-05-05 18:202020-06-26 07:09
ReportershuehnerView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in VersionPR20Q3
StatusclosedFix in branchFixed in SCM revisione8e21dee39c4
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043952: ant create.database on postgresql fails with username containing @ symbol

DescriptionHaving a username containing an @ symbol as value for bbdd.username fails in builds.xml for example during ant create.database

      [sql] Failed to execute: DROP ROLE IF EXISTS tadpi_pgtest@test
      [sql] org.postgresql.util.PSQLException: ERROR: syntax error at or near "@"
      [sql] Position: 35
      [sql] 0 of 1 SQL statements executed successfully

POSTGRE.structure:

POSTGRE.structure.param:
      [sql] Executing commands
      [sql] Failed to execute: CREATE ROLE tadpi_pgtest@test LOGIN PASSWORD 'tad' CREATEDB CREATEROLE VALID UNTIL 'infinity'
      [sql] org.postgresql.util.PSQLException: ERROR: syntax error at or near "@"

Problem is missing quoting around the value inside the build-create.xml file

That is a problem for any user choosing such a username but also when trying to use/test 'Azure Database for PostgreSQL' (aka managed postgres offering in Azure hosting) which forces to use user@dbname as a pattern for the username.
Steps To ReproduceConfigure Openbravo.properties with bddd.username with a value containing @ symbol
run ant create.database
Proposed SolutionAdd necessary quoting for the value in build*.xml
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0015126 closedcberner create.database.database fails with db-name like 'org.openbravo.base.seam' on postgres 

-  Notes
(0119590)
shuehner (administrator)
2020-05-05 18:24

 Note:
For testing the fix apart of testing the described use-case result should be double-checked in an ob-cloud test-instance configure to use "Azure Database for Postgres". OB-Cloud team can provide such an instance when required.
(0120833)
cberner (developer)
2020-06-12 14:33

 Merge Request: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/85 [^]
(0121010)
hgbot (developer)
2020-06-24 09:25

 Repository: erp/devel/pi
Changeset: e8e21dee39c4cc22e0953f6331484915e3e3394a
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Fri Jun 12 14:29:07 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e8e21dee39c4cc22e0953f6331484915e3e3394a [^]

Fixes ISSUE-43952: Fix create.database when db user contains @ char

Database username is now correctly quoted in build-create.xml allowing
names that contain @ and other characters as username. This is important
as Azure instances have as user.name this @ char.

---
M src-db/database/build-create.xml
---

- Issue History
Date Modified Username Field Change
2020-05-05 18:20 shuehner New Issue
2020-05-05 18:20 shuehner Assigned To => platform
2020-05-05 18:20 shuehner Modules => Core
2020-05-05 18:20 shuehner Triggers an Emergency Pack => No
2020-05-05 18:20 shuehner Relationship added related to 0015126
2020-05-05 18:24 shuehner Note Added: 0119590
2020-06-12 14:33 cberner Note Added: 0120833
2020-06-12 14:33 cberner Assigned To platform => cberner
2020-06-16 08:19 cberner Status new => scheduled
2020-06-16 08:19 cberner Review Assigned To => alostale
2020-06-24 09:25 hgbot Checkin
2020-06-24 09:25 hgbot Note Added: 0121010
2020-06-24 09:25 hgbot Status scheduled => resolved
2020-06-24 09:25 hgbot Resolution open => fixed
2020-06-24 09:25 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e8e21dee39c4cc22e0953f6331484915e3e3394a [^]
2020-06-26 07:09 alostale Status resolved => closed
2020-06-26 07:09 alostale Fixed in Version => 3.0PR20Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker