Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0043925 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Discounts and Promotions | minor | have not tried | 2020-05-04 14:59 | 2020-05-22 14:30 | |||
| Reporter | aferraz | View Status | public | |||||
| Assigned To | aferraz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR20Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | RR20Q3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0043925: Move discount and tax engines to app/model/businessLogic folder | |||||||
| Description | Move discount and tax engines to app/model/businessLogic folder | |||||||
| Steps To Reproduce | * | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0119555) hgbot (developer) 2020-05-05 10:55 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: f29f086174f77f986d79c45b2b7372b374ccdc29 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Thu Apr 30 11:34:27 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f29f086174f77f986d79c45b2b7372b374ccdc29 [^] Related to ISSUE-43925: Move tax engine to app/model/businessLogic --- M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java M web/org.openbravo.retail.posterminal/js/taxesengine/pos/pos-taxes.js A web/org.openbravo.retail.posterminal/app/model/businessLogic/taxesengine/engine/rules/priceexcluding-tax.js A web/org.openbravo.retail.posterminal/app/model/businessLogic/taxesengine/engine/rules/priceincluding-tax.js A web/org.openbravo.retail.posterminal/app/model/businessLogic/taxesengine/engine/tax-engine.js A web/org.openbravo.retail.posterminal/app/model/businessLogic/taxesengine/engine/tax-rules.js A web/org.openbravo.retail.posterminal/app/model/businessLogic/taxesengine/interface/tax-posinterface.js R web/org.openbravo.retail.posterminal/app/taxesengine/common/rules/priceexcluding-tax.js R web/org.openbravo.retail.posterminal/app/taxesengine/common/rules/priceincluding-tax.js R web/org.openbravo.retail.posterminal/app/taxesengine/common/tax-engine.js R web/org.openbravo.retail.posterminal/app/taxesengine/common/tax-rules.js --- |
|
(0119556) hgbot (developer) 2020-05-05 10:55 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 3f3268af58ccd252e290029e61495311a40579db Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Thu Apr 30 14:00:21 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3f3268af58ccd252e290029e61495311a40579db [^] Related to ISSUE-43925: Move discount engine to app/model/businessLogic --- M web/org.openbravo.retail.posterminal/js/discountsengine/pos/pos-discounts.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js --- |
|
(0119557) hgbot (developer) 2020-05-05 10:55 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: ba205e2ee748e0ce705b2dab4a4895df8aabdb66 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Thu Apr 30 17:19:19 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ba205e2ee748e0ce705b2dab4a4895df8aabdb66 [^] Related to ISSUE-43925: Move tax engine files to a new component provider --- M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java A src/org/openbravo/retail/posterminal/TaxesEngineAppComponentProvider.java --- |
|
(0119558) hgbot (developer) 2020-05-05 10:55 |
Repository: erp/pmods/org.openbravo.retail.discounts Changeset: bb792dd92a73cb837851a1fa47d7c59560dc0dae Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Thu Apr 30 14:00:28 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/bb792dd92a73cb837851a1fa47d7c59560dc0dae [^] Related to ISSUE-43925: Move discount engine to app/model/businessLogic --- M src/org/openbravo/retail/discounts/DiscountsEngineAppComponentProvider.java A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/discount-engine.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/discount-rules.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/buy-x-gift-y-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/buy-x-pay-y-different-products-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/buy-x-pay-y-same-products-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/fixed-percentage-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/manual-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/pack-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/price-adjustment-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/interface/discount-posinterface.js R web/org.openbravo.retail.discounts/js/discountsengine/common/discount-engine.js R web/org.openbravo.retail.discounts/js/discountsengine/common/discount-rules.js R web/org.openbravo.retail.discounts/js/discountsengine/common/rules/buy-x-gift-y-discount.js R web/org.openbravo.retail.discounts/js/discountsengine/common/rules/buy-x-pay-y-different-products-discount.js R web/org.openbravo.retail.discounts/js/discountsengine/common/rules/buy-x-pay-y-same-products-discount.js R web/org.openbravo.retail.discounts/js/discountsengine/common/rules/fixed-percentage-discount.js R web/org.openbravo.retail.discounts/js/discountsengine/common/rules/manual-promotions-discount.js R web/org.openbravo.retail.discounts/js/discountsengine/common/rules/pack-discount.js R web/org.openbravo.retail.discounts/js/discountsengine/common/rules/price-adjustment-discount.js --- |
|
(0119559) hgbot (developer) 2020-05-05 10:55 |
Repository: erp/pmods/org.openbravo.retail.discounts Changeset: 6428928cd4fe438e1a43737cac20138ece264ab6 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Mon May 04 20:30:57 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/6428928cd4fe438e1a43737cac20138ece264ab6 [^] Related to ISSUE-43925: Fix jslint errors in discount engine --- M src/org/openbravo/retail/discounts/DiscountsEngineAppComponentProvider.java M web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/discount-engine.js M web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/discount-rules.js M web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/buy-x-gift-y-discount.js M web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/buy-x-pay-y-different-products-discount.js M web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/buy-x-pay-y-same-products-discount.js M web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/fixed-percentage-discount.js M web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/pack-discount.js M web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/price-adjustment-discount.js M web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/interface/discount-posinterface.js A web/org.openbravo.retail.discounts/app/.eslintrc.json A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/fixed-manual-amount-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/fixed-manual-percentage-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/manual-amount-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/manual-linefinalprice-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/manual-percentage-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/variable-manual-amount-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/variable-manual-linefinalprice-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/variable-manual-percentage-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/manual-promotions-discount.js --- |
|
(0119560) hgbot (developer) 2020-05-05 10:56 |
Repository: erp/pmods/org.openbravo.taxes Changeset: ead428993fdb76a0d93167447967c993d6c2e2f2 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Mon May 04 19:06:52 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.taxes/rev/ead428993fdb76a0d93167447967c993d6c2e2f2 [^] Related to ISSUE-43925: Move tax engine files to a new component provider --- M src/org/openbravo/taxes/TaxesBackendComponentProvider.java --- |
|
(0119562) hgbot (developer) 2020-05-05 10:57 |
Repository: erp/pmods/org.openbravo.retail.discounts.scaledprice Changeset: b7b44cc215d091c56e2a717695996bd12c28c6eb Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Tue May 05 10:57:41 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.scaledprice/rev/b7b44cc215d091c56e2a717695996bd12c28c6eb [^] Related to ISSUE-43925: Move discount engine to app/model/businessLogic --- M src/org/openbravo/retail/discounts/scaledprice/ScaledPriceDiscountsEngineAppComponentProvider.java M web/org.openbravo.retail.discounts.scaledprice/js/scaledprice-datahook.js A web/org.openbravo.retail.discounts.scaledprice/app/.eslintrc.json A web/org.openbravo.retail.discounts.scaledprice/app/model/businessLogic/discountsengine/engine/rules/scaled-price-discount.js R web/org.openbravo.retail.discounts.scaledprice/js/discountsengine/common/rules/scaled-price-discount.js --- |
|
(0119563) hgbot (developer) 2020-05-05 10:59 |
Repository: erp/pmods/org.openbravo.retail.discounts.combo Changeset: 38eaffaaa3541fca0ad3949e2ecb0ad1bc01e144 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Tue May 05 10:58:47 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/38eaffaaa3541fca0ad3949e2ecb0ad1bc01e144 [^] Related to ISSUE-43925: Move discount engine to app/model/businessLogic --- M src/org/openbravo/retail/discounts/combo/ComboDiscountsEngineAppComponentProvider.java M web/org.openbravo.retail.discounts.combo/source/combo-datahook.js A web/org.openbravo.retail.discounts.combo/app/.eslintrc.json A web/org.openbravo.retail.discounts.combo/app/model/businessLogic/discountsengine/engine/rules/combo-discount.js A web/org.openbravo.retail.discounts.combo/app/model/businessLogic/discountsengine/engine/rules/fixed-combo-discount.js R web/org.openbravo.retail.discounts.combo/js/discountsengine/common/rules/combo-discount.js --- |
|
(0119564) hgbot (developer) 2020-05-05 10:59 |
Repository: erp/pmods/org.openbravo.retail.discount.twofamiliescombo Changeset: 01ad1bd2aadb172517cead9813aea3b36480ddf6 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Tue May 05 10:59:07 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discount.twofamiliescombo/rev/01ad1bd2aadb172517cead9813aea3b36480ddf6 [^] Related to ISSUE-43925: Move discount engine to app/model/businessLogic --- M src/org/openbravo/retail/discount/twofamiliescombo/TwoFamiliesComboDiscountsEngineAppComponentProvider.java A web/org.openbravo.retail.discount.twofamiliescombo/app/.eslintrc.json A web/org.openbravo.retail.discount.twofamiliescombo/app/model/businessLogic/discountsengine/engine/rules/two-families-combo-discount.js R web/org.openbravo.retail.discount.twofamiliescombo/js/discountsengine/common/rules/two-families-combo-discount.js --- |
|
(0119565) hgbot (developer) 2020-05-05 10:59 |
Repository: erp/pmods/org.openbravo.retail.discounts.coupons.otf Changeset: 8780bca33b935968763c72256e89afbd8bb3d727 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Tue May 05 10:59:27 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons.otf/rev/8780bca33b935968763c72256e89afbd8bb3d727 [^] Related to ISSUE-43925: Move discount engine to app/model/businessLogic --- M src/org/openbravo/retail/discounts/coupons/otf/VariableAmountCouponDiscountEngineAppComponentProvider.java A web/org.openbravo.retail.discounts.coupons.otf/app/.eslintrc.json A web/org.openbravo.retail.discounts.coupons.otf/app/model/businessLogic/discountsengine/engine/rules/variable-amount-coupons-discount.js R web/org.openbravo.retail.discounts.coupons.otf/js/discountsengine/common/rules/variable-amount-coupons-discount.js --- |
|
(0119567) hgbot (developer) 2020-05-05 11:01 |
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal Changeset: 95a79c86bcff41cddf04bd0924f53a40415b7485 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Tue May 05 11:00:47 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/95a79c86bcff41cddf04bd0924f53a40415b7485 [^] Related to ISSUE-43925: Move discount engine to app/model/businessLogic --- M src/org/openbravo/retail/discounts/bytotal/ByToTalDiscountsEngineAppComponentProvider.java M web/org.openbravo.retail.discounts.bytotal/js/bytotal-datahook.js A web/org.openbravo.retail.discounts.bytotal/app/.eslintrc.json A web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/by-total-amount-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/by-total-free-item-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/by-total-percentage-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/fixed-manual-by-total-amount-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/fixed-manual-by-total-percentage-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/manual-by-total-amount-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/manual-by-total-percentage-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/variable-manual-by-total-amount-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/variable-manual-by-total-percentage-discount.js R web/org.openbravo.retail.discounts.bytotal/js/discountsengine/common/rules/by-total-amount-discount.js R web/org.openbravo.retail.discounts.bytotal/js/discountsengine/common/rules/by-total-free-item-discount.js R web/org.openbravo.retail.discounts.bytotal/js/discountsengine/common/rules/by-total-percentage-discount.js --- |
|
(0119568) hgbot (developer) 2020-05-05 11:05 |
Repository: erp/pmods/org.openbravo.retail.discounts.bypaymentmethod Changeset: 28bc1c84f2264ae98ee357a511b82ace42ae4294 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Tue May 05 11:05:19 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bypaymentmethod/rev/28bc1c84f2264ae98ee357a511b82ace42ae4294 [^] Related to ISSUE-43925: Move discount engine to app/model/businessLogic --- M web/org.openbravo.retail.discounts.bypaymentmethod/js/paymentmethod-discount.js A web/org.openbravo.retail.discounts.bypaymentmethod/app/.eslintrc.json --- |
|
(0119571) aferraz (viewer) 2020-05-05 11:10 |
Pending to fix no-param-reassign error: https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/annotate/tip/web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/discount-rules.js#l10 [^] https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/annotate/tip/web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/buy-x-pay-y-different-products-discount.js#l10 [^] |
|
(0119589) hgbot (developer) 2020-05-05 18:08 |
Repository: erp/pmods/org.openbravo.retail.discounts Changeset: b77859a73b552738bb4b74b720533b8398cd7b63 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Tue May 05 18:08:31 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/b77859a73b552738bb4b74b720533b8398cd7b63 [^] Related to ISSUE-43925: Fix jslint errors in discount engine --- M web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/discount-rules.js --- |
|
(0119910) hgbot (developer) 2020-05-15 09:52 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 0418ab1ad1d4cd05196cbe2b2ec16863293f8d8b Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 09:41:42 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0418ab1ad1d4cd05196cbe2b2ec16863293f8d8b [^] Related to ISSUE-43925: Rename businessLogic folder as business-logic --- M src/org/openbravo/retail/posterminal/TaxesEngineAppComponentProvider.java A web/org.openbravo.retail.posterminal/app/model/business-logic/taxesengine/engine/rules/priceexcluding-tax.js A web/org.openbravo.retail.posterminal/app/model/business-logic/taxesengine/engine/rules/priceincluding-tax.js A web/org.openbravo.retail.posterminal/app/model/business-logic/taxesengine/engine/tax-engine.js A web/org.openbravo.retail.posterminal/app/model/business-logic/taxesengine/engine/tax-rules.js A web/org.openbravo.retail.posterminal/app/model/business-logic/taxesengine/interface/tax-posinterface.js R web/org.openbravo.retail.posterminal/app/model/businessLogic/taxesengine/engine/rules/priceexcluding-tax.js R web/org.openbravo.retail.posterminal/app/model/businessLogic/taxesengine/engine/rules/priceincluding-tax.js R web/org.openbravo.retail.posterminal/app/model/businessLogic/taxesengine/engine/tax-engine.js R web/org.openbravo.retail.posterminal/app/model/businessLogic/taxesengine/engine/tax-rules.js R web/org.openbravo.retail.posterminal/app/model/businessLogic/taxesengine/interface/tax-posinterface.js --- |
|
(0119912) hgbot (developer) 2020-05-15 09:53 |
Repository: erp/pmods/org.openbravo.retail.discounts Changeset: d63e655dcbb11d7bb0a0bd2a84f41537cddcc407 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 09:53:02 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/d63e655dcbb11d7bb0a0bd2a84f41537cddcc407 [^] Related to ISSUE-43925: Rename businessLogic folder as business-logic --- M src/org/openbravo/retail/discounts/DiscountsEngineAppComponentProvider.java A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/discount-engine.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/discount-rules.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/buy-x-gift-y-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/buy-x-pay-y-different-products-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/buy-x-pay-y-same-products-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/fixed-manual-amount-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/fixed-manual-percentage-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/fixed-percentage-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/manual-amount-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/manual-linefinalprice-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/manual-percentage-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/pack-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/price-adjustment-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/variable-manual-amount-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/variable-manual-linefinalprice-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/variable-manual-percentage-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/interface/discount-posinterface.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/discount-engine.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/discount-rules.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/buy-x-gift-y-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/buy-x-pay-y-different-products-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/buy-x-pay-y-same-products-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/fixed-manual-amount-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/fixed-manual-percentage-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/fixed-percentage-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/manual-amount-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/manual-linefinalprice-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/manual-percentage-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/pack-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/price-adjustment-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/variable-manual-amount-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/variable-manual-linefinalprice-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/engine/rules/variable-manual-percentage-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/businessLogic/discountsengine/interface/discount-posinterface.js --- |
|
(0119913) hgbot (developer) 2020-05-15 09:53 |
Repository: erp/pmods/org.openbravo.retail.discounts.scaledprice Changeset: 8569efcd87ebe05917610b5c6aa69344064e1d14 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 09:53:31 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.scaledprice/rev/8569efcd87ebe05917610b5c6aa69344064e1d14 [^] Related to ISSUE-43925: Rename businessLogic folder as business-logic --- M src/org/openbravo/retail/discounts/scaledprice/ScaledPriceDiscountsEngineAppComponentProvider.java A web/org.openbravo.retail.discounts.scaledprice/app/model/business-logic/discountsengine/engine/rules/scaled-price-discount.js R web/org.openbravo.retail.discounts.scaledprice/app/model/businessLogic/discountsengine/engine/rules/scaled-price-discount.js --- |
|
(0119914) hgbot (developer) 2020-05-15 09:53 |
Repository: erp/pmods/org.openbravo.retail.discounts.combo Changeset: 1a5e34ad750a4c13bdb7396edb5cf1f2d3653774 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 09:53:47 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/1a5e34ad750a4c13bdb7396edb5cf1f2d3653774 [^] Related to ISSUE-43925: Rename businessLogic folder as business-logic --- M src/org/openbravo/retail/discounts/combo/ComboDiscountsEngineAppComponentProvider.java A web/org.openbravo.retail.discounts.combo/app/model/business-logic/discountsengine/engine/rules/combo-discount.js A web/org.openbravo.retail.discounts.combo/app/model/business-logic/discountsengine/engine/rules/fixed-combo-discount.js R web/org.openbravo.retail.discounts.combo/app/model/businessLogic/discountsengine/engine/rules/combo-discount.js R web/org.openbravo.retail.discounts.combo/app/model/businessLogic/discountsengine/engine/rules/fixed-combo-discount.js --- |
|
(0119915) hgbot (developer) 2020-05-15 09:54 |
Repository: erp/pmods/org.openbravo.retail.discount.twofamiliescombo Changeset: 0f440992c11c56f3e77edb73daf8922edda6a4cd Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 09:54:02 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discount.twofamiliescombo/rev/0f440992c11c56f3e77edb73daf8922edda6a4cd [^] Related to ISSUE-43925: Rename businessLogic folder as business-logic --- M src/org/openbravo/retail/discount/twofamiliescombo/TwoFamiliesComboDiscountsEngineAppComponentProvider.java A web/org.openbravo.retail.discount.twofamiliescombo/app/model/business-logic/discountsengine/engine/rules/two-families-combo-discount.js R web/org.openbravo.retail.discount.twofamiliescombo/app/model/businessLogic/discountsengine/engine/rules/two-families-combo-discount.js --- |
|
(0119916) hgbot (developer) 2020-05-15 09:54 |
Repository: erp/pmods/org.openbravo.retail.discounts.coupons.otf Changeset: 2bcdef62c91edd50842926efe48117f77fc2af71 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 09:54:23 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons.otf/rev/2bcdef62c91edd50842926efe48117f77fc2af71 [^] Related to ISSUE-43925: Rename businessLogic folder as business-logic --- M src/org/openbravo/retail/discounts/coupons/otf/VariableAmountCouponDiscountEngineAppComponentProvider.java A web/org.openbravo.retail.discounts.coupons.otf/app/model/business-logic/discountsengine/engine/rules/variable-amount-coupons-discount.js R web/org.openbravo.retail.discounts.coupons.otf/app/model/businessLogic/discountsengine/engine/rules/variable-amount-coupons-discount.js --- |
|
(0119917) hgbot (developer) 2020-05-15 09:54 |
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal Changeset: e104e075c543f10431e929927474c3f75f05c797 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 09:54:36 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/e104e075c543f10431e929927474c3f75f05c797 [^] Related to ISSUE-43925: Rename businessLogic folder as business-logic --- M src/org/openbravo/retail/discounts/bytotal/ByToTalDiscountsEngineAppComponentProvider.java A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/by-total-amount-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/by-total-free-item-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/by-total-percentage-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/fixed-manual-by-total-amount-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/fixed-manual-by-total-percentage-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/manual-by-total-amount-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/manual-by-total-percentage-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/variable-manual-by-total-amount-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/variable-manual-by-total-percentage-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/by-total-amount-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/by-total-free-item-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/by-total-percentage-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/fixed-manual-by-total-amount-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/fixed-manual-by-total-percentage-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/manual-by-total-amount-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/manual-by-total-percentage-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/variable-manual-by-total-amount-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/businessLogic/discountsengine/engine/rules/variable-manual-by-total-percentage-discount.js --- |
|
(0119925) hgbot (developer) 2020-05-15 11:00 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 3f57c32a6de3d7515ecd990c4c9ed574c9cd0058 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 10:47:25 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3f57c32a6de3d7515ecd990c4c9ed574c9cd0058 [^] Related to ISSUE-43925: Rename taxesengine folder as taxes-engine --- M src/org/openbravo/retail/posterminal/TaxesEngineAppComponentProvider.java A web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/rules/priceexcluding-tax.js A web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/rules/priceincluding-tax.js A web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-engine.js A web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js A web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/interface/tax-posinterface.js R web/org.openbravo.retail.posterminal/app/model/business-logic/taxesengine/engine/rules/priceexcluding-tax.js R web/org.openbravo.retail.posterminal/app/model/business-logic/taxesengine/engine/rules/priceincluding-tax.js R web/org.openbravo.retail.posterminal/app/model/business-logic/taxesengine/engine/tax-engine.js R web/org.openbravo.retail.posterminal/app/model/business-logic/taxesengine/engine/tax-rules.js R web/org.openbravo.retail.posterminal/app/model/business-logic/taxesengine/interface/tax-posinterface.js --- |
|
(0119926) hgbot (developer) 2020-05-15 11:00 |
Repository: erp/pmods/org.openbravo.retail.discounts Changeset: b6d234bd3f61dccf00fa41e9e540bf706c1d234d Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 10:42:45 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/b6d234bd3f61dccf00fa41e9e540bf706c1d234d [^] Related to ISSUE-43925: Rename discountsengine folder as discounts-engine --- M src/org/openbravo/retail/discounts/DiscountsEngineAppComponentProvider.java A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-engine.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-rules.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/buy-x-gift-y-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/buy-x-pay-y-different-products-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/buy-x-pay-y-same-products-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/fixed-manual-amount-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/fixed-manual-percentage-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/fixed-percentage-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/manual-amount-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/manual-linefinalprice-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/manual-percentage-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/pack-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/price-adjustment-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/variable-manual-amount-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/variable-manual-linefinalprice-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/variable-manual-percentage-promotions-discount.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/discount-engine.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/discount-rules.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/buy-x-gift-y-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/buy-x-pay-y-different-products-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/buy-x-pay-y-same-products-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/fixed-manual-amount-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/fixed-manual-percentage-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/fixed-percentage-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/manual-amount-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/manual-linefinalprice-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/manual-percentage-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/pack-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/price-adjustment-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/variable-manual-amount-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/variable-manual-linefinalprice-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/engine/rules/variable-manual-percentage-promotions-discount.js R web/org.openbravo.retail.discounts/app/model/business-logic/discountsengine/interface/discount-posinterface.js --- |
|
(0119927) hgbot (developer) 2020-05-15 11:00 |
Repository: erp/pmods/org.openbravo.retail.discounts.scaledprice Changeset: 238b91420e0edfdfaff04863ae243ae05ed69816 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 10:50:41 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.scaledprice/rev/238b91420e0edfdfaff04863ae243ae05ed69816 [^] Related to ISSUE-43925: Rename discountsengine folder as discounts-engine --- M src/org/openbravo/retail/discounts/scaledprice/ScaledPriceDiscountsEngineAppComponentProvider.java A web/org.openbravo.retail.discounts.scaledprice/app/model/business-logic/discounts-engine/engine/rules/scaled-price-discount.js R web/org.openbravo.retail.discounts.scaledprice/app/model/business-logic/discountsengine/engine/rules/scaled-price-discount.js --- |
|
(0119928) hgbot (developer) 2020-05-15 11:00 |
Repository: erp/pmods/org.openbravo.retail.discounts.combo Changeset: 3ba045c33637717802249d056292f8c0f2fffafa Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 10:52:59 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/3ba045c33637717802249d056292f8c0f2fffafa [^] Related to ISSUE-43925: Rename discountsengine folder as discounts-engine --- M src/org/openbravo/retail/discounts/combo/ComboDiscountsEngineAppComponentProvider.java A web/org.openbravo.retail.discounts.combo/app/model/business-logic/discounts-engine/engine/rules/combo-discount.js A web/org.openbravo.retail.discounts.combo/app/model/business-logic/discounts-engine/engine/rules/fixed-combo-discount.js R web/org.openbravo.retail.discounts.combo/app/model/business-logic/discountsengine/engine/rules/combo-discount.js R web/org.openbravo.retail.discounts.combo/app/model/business-logic/discountsengine/engine/rules/fixed-combo-discount.js --- |
|
(0119929) hgbot (developer) 2020-05-15 11:01 |
Repository: erp/pmods/org.openbravo.retail.discount.twofamiliescombo Changeset: 43acfcb6d200ddaa3b70d5f58ab00c2fe8fc4b04 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 10:53:36 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discount.twofamiliescombo/rev/43acfcb6d200ddaa3b70d5f58ab00c2fe8fc4b04 [^] Related to ISSUE-43925: Rename discountsengine folder as discounts-engine --- M src/org/openbravo/retail/discount/twofamiliescombo/TwoFamiliesComboDiscountsEngineAppComponentProvider.java A web/org.openbravo.retail.discount.twofamiliescombo/app/model/business-logic/discounts-engine/engine/rules/two-families-combo-discount.js R web/org.openbravo.retail.discount.twofamiliescombo/app/model/business-logic/discountsengine/engine/rules/two-families-combo-discount.js --- |
|
(0119930) hgbot (developer) 2020-05-15 11:01 |
Repository: erp/pmods/org.openbravo.retail.discounts.coupons.otf Changeset: 0630054714d9a49a6b4d2b0335ec4b0d3d72246e Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 10:54:16 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons.otf/rev/0630054714d9a49a6b4d2b0335ec4b0d3d72246e [^] Related to ISSUE-43925: Rename discountsengine folder as discounts-engine --- M src/org/openbravo/retail/discounts/coupons/otf/VariableAmountCouponDiscountEngineAppComponentProvider.java A web/org.openbravo.retail.discounts.coupons.otf/app/model/business-logic/discounts-engine/engine/rules/variable-amount-coupons-discount.js R web/org.openbravo.retail.discounts.coupons.otf/app/model/business-logic/discountsengine/engine/rules/variable-amount-coupons-discount.js --- |
|
(0119931) hgbot (developer) 2020-05-15 11:01 |
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal Changeset: c3c8be5e08be316e4a74fbce3acaa6c7ba368b14 Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri May 15 10:54:52 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/c3c8be5e08be316e4a74fbce3acaa6c7ba368b14 [^] Related to ISSUE-43925: Rename discountsengine folder as discounts-engine --- M src/org/openbravo/retail/discounts/bytotal/ByToTalDiscountsEngineAppComponentProvider.java A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/by-total-amount-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/by-total-free-item-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/by-total-percentage-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/fixed-manual-by-total-amount-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/fixed-manual-by-total-percentage-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/manual-by-total-amount-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/manual-by-total-percentage-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/variable-manual-by-total-amount-discount.js A web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/variable-manual-by-total-percentage-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/by-total-amount-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/by-total-free-item-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/by-total-percentage-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/fixed-manual-by-total-amount-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/fixed-manual-by-total-percentage-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/manual-by-total-amount-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/manual-by-total-percentage-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/variable-manual-by-total-amount-discount.js R web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discountsengine/engine/rules/variable-manual-by-total-percentage-discount.js --- |
|
(0120185) marvintm (viewer) 2020-05-22 14:30 |
Changes are correct. The "no-param-reassign" cannot be fixed without changing the definition of the main functions in the discount rules API. The functions are currently designed to receive a lines object that must be mutated by the function logic. On hindsight, this was not a correct decision. Instead we should have defined those functions so that the code would return the promotions that need to be added to the lines, or instead a clone of the lines that it receives. However, it is not a problem big enough to warrant an API change, as the lines object it receives is instead a new object that is created by the main discounts engine, so mutating it should not generate any real side effect, or unwanted/unpredictable behaviour, in other places of the code. So we think the best is to keep the rule disabled in those files as of now. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-05-04 14:59 | aferraz | New Issue | |
| 2020-05-04 14:59 | aferraz | Assigned To | => jorge-garcia |
| 2020-05-04 14:59 | aferraz | OBNetwork customer | => No |
| 2020-05-04 14:59 | aferraz | Triggers an Emergency Pack | => No |
| 2020-05-04 18:47 | aferraz | Assigned To | jorge-garcia => aferraz |
| 2020-05-04 18:47 | aferraz | Summary | Fix no-param-reassign jslint error in new discount engine => Move discount and tax engines to app/model/businessLogic folder |
| 2020-05-04 18:47 | aferraz | Description Updated | View Revisions |
| 2020-05-05 10:55 | hgbot | Checkin | |
| 2020-05-05 10:55 | hgbot | Note Added: 0119555 | |
| 2020-05-05 10:55 | hgbot | Checkin | |
| 2020-05-05 10:55 | hgbot | Note Added: 0119556 | |
| 2020-05-05 10:55 | hgbot | Checkin | |
| 2020-05-05 10:55 | hgbot | Note Added: 0119557 | |
| 2020-05-05 10:55 | hgbot | Checkin | |
| 2020-05-05 10:55 | hgbot | Note Added: 0119558 | |
| 2020-05-05 10:55 | hgbot | Checkin | |
| 2020-05-05 10:55 | hgbot | Note Added: 0119559 | |
| 2020-05-05 10:56 | hgbot | Checkin | |
| 2020-05-05 10:56 | hgbot | Note Added: 0119560 | |
| 2020-05-05 10:57 | hgbot | Checkin | |
| 2020-05-05 10:57 | hgbot | Note Added: 0119562 | |
| 2020-05-05 10:59 | hgbot | Checkin | |
| 2020-05-05 10:59 | hgbot | Note Added: 0119563 | |
| 2020-05-05 10:59 | hgbot | Checkin | |
| 2020-05-05 10:59 | hgbot | Note Added: 0119564 | |
| 2020-05-05 10:59 | hgbot | Checkin | |
| 2020-05-05 10:59 | hgbot | Note Added: 0119565 | |
| 2020-05-05 11:01 | hgbot | Checkin | |
| 2020-05-05 11:01 | hgbot | Note Added: 0119567 | |
| 2020-05-05 11:05 | hgbot | Checkin | |
| 2020-05-05 11:05 | hgbot | Note Added: 0119568 | |
| 2020-05-05 11:08 | aferraz | Review Assigned To | => jorge-garcia |
| 2020-05-05 11:10 | aferraz | Note Added: 0119571 | |
| 2020-05-05 18:08 | hgbot | Checkin | |
| 2020-05-05 18:08 | hgbot | Note Added: 0119589 | |
| 2020-05-05 18:29 | aferraz | Status | new => scheduled |
| 2020-05-05 18:29 | aferraz | Status | scheduled => resolved |
| 2020-05-05 18:29 | aferraz | Fixed in Version | => RR20Q3 |
| 2020-05-05 18:29 | aferraz | Resolution | open => fixed |
| 2020-05-15 09:52 | hgbot | Checkin | |
| 2020-05-15 09:52 | hgbot | Note Added: 0119910 | |
| 2020-05-15 09:53 | hgbot | Checkin | |
| 2020-05-15 09:53 | hgbot | Note Added: 0119912 | |
| 2020-05-15 09:53 | hgbot | Checkin | |
| 2020-05-15 09:53 | hgbot | Note Added: 0119913 | |
| 2020-05-15 09:53 | hgbot | Checkin | |
| 2020-05-15 09:53 | hgbot | Note Added: 0119914 | |
| 2020-05-15 09:54 | hgbot | Checkin | |
| 2020-05-15 09:54 | hgbot | Note Added: 0119915 | |
| 2020-05-15 09:54 | hgbot | Checkin | |
| 2020-05-15 09:54 | hgbot | Note Added: 0119916 | |
| 2020-05-15 09:54 | hgbot | Checkin | |
| 2020-05-15 09:54 | hgbot | Note Added: 0119917 | |
| 2020-05-15 11:00 | hgbot | Checkin | |
| 2020-05-15 11:00 | hgbot | Note Added: 0119925 | |
| 2020-05-15 11:00 | hgbot | Checkin | |
| 2020-05-15 11:00 | hgbot | Note Added: 0119926 | |
| 2020-05-15 11:00 | hgbot | Checkin | |
| 2020-05-15 11:00 | hgbot | Note Added: 0119927 | |
| 2020-05-15 11:00 | hgbot | Checkin | |
| 2020-05-15 11:00 | hgbot | Note Added: 0119928 | |
| 2020-05-15 11:01 | hgbot | Checkin | |
| 2020-05-15 11:01 | hgbot | Note Added: 0119929 | |
| 2020-05-15 11:01 | hgbot | Checkin | |
| 2020-05-15 11:01 | hgbot | Note Added: 0119930 | |
| 2020-05-15 11:01 | hgbot | Checkin | |
| 2020-05-15 11:01 | hgbot | Note Added: 0119931 | |
| 2020-05-18 11:15 | marvintm | Status | resolved => new |
| 2020-05-18 11:15 | marvintm | Resolution | fixed => open |
| 2020-05-18 11:15 | marvintm | Fixed in Version | RR20Q3 => |
| 2020-05-18 11:16 | marvintm | Status | new => scheduled |
| 2020-05-18 11:16 | marvintm | Status | scheduled => resolved |
| 2020-05-18 11:16 | marvintm | Fixed in Version | => RR20Q3 |
| 2020-05-18 11:16 | marvintm | Resolution | open => fixed |
| 2020-05-22 14:30 | marvintm | Review Assigned To | jorge-garcia => marvintm |
| 2020-05-22 14:30 | marvintm | Note Added: 0120185 | |
| 2020-05-22 14:30 | marvintm | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |