Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043919
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2020-05-04 08:442020-06-01 14:04
ReporteradrianromeroView Statuspublic 
Assigned Toadrianromero 
PrioritynormalResolutionfixedFixed in VersionRR20Q3
StatusclosedFix in branchFixed in SCM revisionf51bd5a195b0
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression levelProduction - QA Approved
Regression date2019-11-25
Regression introduced in releaseRR20Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/05279e2f2dfeab33547a5761d4ddcff1dda972ae [^]
Triggers an Emergency PackNo
Summary

0043919: If a payment provider has ha payment type null payment processor raises an error

DescriptionIt is an error that can only happen at the application configuration stage when a payment method is configured with a payment provider but the payment type is left empty. In this case the error "Cannot read property 'searchKey' of undefined" appears
Steps To ReproduceIn https://livebuilds.openbravo.com/retail_stable_pgsql_pi/ [^] Go to the the Channel touchpoint type "VBS POS Terminal Type 2" that is the terminal type for the touchpoint "VBS2-1". Here go to the Payment method "Credit Card VISA" and check it has payment provider "Credit Card" and Payment Method Type "VISA". Clear the Payment Method Type field and save.

Login into the terminal https://livebuilds.openbravo.com/retail_stable_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS2-1#retail.pointofsale [^] Add a product and change the price of the product added to have a total of "350.50€" This is needed for the payment processor to validate the payment. Then go to the payment panel, Select "Credit Card" and tap on "Pay Total".

Observe the following error is raised: "Cannot read property 'searchKey' of undefined"
Proposed Solution* Revert the constraint removed in the fix for the issue 42382.
* To help the configuration, add a new callout that selects the default payment method type when the payment provider changes.
* Verify current instances in production to verify there is not any wrong configuration. Payment provider without payment method type.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by defect 0042382 closedranjith_qualiantech_com 'Payment Method Type' field should be able to set as empty when selecting a Payment Group 
related to defect 0044070 closedadrianromero API change: Restored constraint in payment methods in Touchpoint Type for payment groups 

-  Notes
(0120078)
hgbot (developer)
2020-05-20 09:53

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f51bd5a195b0e7783e224df4a37b49de99e04dcd
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed May 06 09:39:36 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f51bd5a195b0e7783e224df4a37b49de99e04dcd [^]

Fixes ISSUE-0043919: If a payment provider has ha payment type null payment processor raises an error
* Callout to select the payment method type after a payment group is selected

---
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
A src/org/openbravo/retail/posterminal/ad_callouts/DefaultPaymentMethodType.java
---
(0120079)
hgbot (developer)
2020-05-20 09:53

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6d40ee2c7919ffbf3a87dbd52c4d1358812ea675
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed May 06 11:25:48 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6d40ee2c7919ffbf3a87dbd52c4d1358812ea675 [^]

Related to ISSUE-0043919: If a payment provider has ha payment type null payment processor raises an error
* Adds order by to callout sentence

---
M src/org/openbravo/retail/posterminal/ad_callouts/DefaultPaymentMethodType.java
---
(0120080)
hgbot (developer)
2020-05-20 09:54

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a8f4fbf72013fca062758df33f1f448488b6fab0
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon May 11 11:17:42 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a8f4fbf72013fca062758df33f1f448488b6fab0 [^]

Related to ISSUE-0043919: If a payment provider has ha payment type null payment processor raises an error
* Adds a build Validation script to check the database complies with the added SQL constraint

---
A build/classes/org/openbravo/retail/posterminal/buildvalidation/I43919ValidatePaymentProviders.class
A build/classes/org/openbravo/retail/posterminal/buildvalidation/I43919ValidatePaymentProvidersData.class
A src-util/buildvalidation/src/org/openbravo/retail/posterminal/buildvalidation/I43919ValidatePaymentProviders.java
A src-util/buildvalidation/src/org/openbravo/retail/posterminal/buildvalidation/I43919ValidatePaymentProviders_data.xsql
---
(0120081)
hgbot (developer)
2020-05-20 09:54

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9f5cd36e675f4e16cc76803f41625b0dbad38f1c
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue May 12 09:22:39 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9f5cd36e675f4e16cc76803f41625b0dbad38f1c [^]

Related to ISSUE-0043919: If a payment provider has ha payment type null payment processor raises an error
* Fixes SQLC in build validation script

---
M build/classes/org/openbravo/retail/posterminal/buildvalidation/I43919ValidatePaymentProvidersData.class
M src-util/buildvalidation/src/org/openbravo/retail/posterminal/buildvalidation/I43919ValidatePaymentProviders_data.xsql
---
(0120082)
hgbot (developer)
2020-05-20 09:54

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a6f6c66bcc81c898fcd20f14a90697b95a763144
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu May 14 10:58:30 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a6f6c66bcc81c898fcd20f14a90697b95a763144 [^]

Related to ISSUE-0043919: If a payment provider has ha payment type null payment processor raises an error
* Fixes java unsafe compilation

---
M build/classes/org/openbravo/retail/posterminal/buildvalidation/I43919ValidatePaymentProviders.class
M src-util/buildvalidation/src/org/openbravo/retail/posterminal/buildvalidation/I43919ValidatePaymentProviders.java
---
(0120083)
hgbot (developer)
2020-05-20 09:54

 Repository: retail/api-checks-retail
Changeset: 25cbb1032a7b4f5e8863160c822ba377a536971d
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu May 14 16:49:32 2020 +0200
URL: http://code.openbravo.com/retail/api-checks-retail/rev/25cbb1032a7b4f5e8863160c822ba377a536971d [^]

Related to ISSUE-0043919: If a payment provider has ha payment type null payment processor raises an error
* Adjusts API

---
M model/modules/org.openbravo.retail.posterminal/src-db/database/model/tables/OBPOS_APP_PAYMENT_TYPE.xml
---

- Issue History
Date Modified Username Field Change
2020-05-04 08:44 adrianromero New Issue
2020-05-04 08:44 adrianromero Assigned To => marvintm
2020-05-04 08:44 adrianromero Regression level => Production - QA Approved
2020-05-04 08:44 adrianromero Regression date => 2019-11-25
2020-05-04 08:44 adrianromero Regression introduced in release => RR20Q1
2020-05-04 08:44 adrianromero Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/05279e2f2dfeab33547a5761d4ddcff1dda972ae [^]
2020-05-04 08:44 adrianromero Triggers an Emergency Pack => No
2020-05-04 08:45 adrianromero Relationship added caused by 0042382
2020-05-04 08:56 adrianromero Steps to Reproduce Updated View Revisions
2020-05-04 08:56 adrianromero Proposed Solution updated
2020-05-04 11:41 adrianromero Proposed Solution updated
2020-05-04 11:42 adrianromero Assigned To marvintm => adrianromero
2020-05-15 08:58 adrianromero Relationship added related to 0044070
2020-05-20 09:53 hgbot Checkin
2020-05-20 09:53 hgbot Note Added: 0120078
2020-05-20 09:53 hgbot Status new => resolved
2020-05-20 09:53 hgbot Resolution open => fixed
2020-05-20 09:53 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f51bd5a195b0e7783e224df4a37b49de99e04dcd [^]
2020-05-20 09:53 hgbot Checkin
2020-05-20 09:53 hgbot Note Added: 0120079
2020-05-20 09:54 hgbot Checkin
2020-05-20 09:54 hgbot Note Added: 0120080
2020-05-20 09:54 hgbot Checkin
2020-05-20 09:54 hgbot Note Added: 0120081
2020-05-20 09:54 hgbot Checkin
2020-05-20 09:54 hgbot Note Added: 0120082
2020-05-20 09:54 hgbot Checkin
2020-05-20 09:54 hgbot Note Added: 0120083
2020-05-20 09:58 adrianromero Review Assigned To => marvintm
2020-06-01 14:04 marvintm Status resolved => closed
2020-06-01 14:04 marvintm Fixed in Version => RR20Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker