0043919: If a payment provider has ha payment type null payment processor raises an error

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0043919

Retail Modules

Web POS

public

2020-05-04 08:44

2020-06-01 14:04

Reporter

adrianromero

Assigned To

adrianromero

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR20Q3

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Production - QA Approved

Regression date

2019-11-25

Regression introduced in release

RR20Q1

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/05279e2f2dfeab33547a5761d4ddcff1dda972ae [^]

Triggers an Emergency Pack

Summary

0043919: If a payment provider has ha payment type null payment processor raises an error

Description

It is an error that can only happen at the application configuration stage when a payment method is configured with a payment provider but the payment type is left empty. In this case the error "Cannot read property 'searchKey' of undefined" appears

Steps To Reproduce

In https://livebuilds.openbravo.com/retail_stable_pgsql_pi/ [^] Go to the the Channel touchpoint type "VBS POS Terminal Type 2" that is the terminal type for the touchpoint "VBS2-1". Here go to the Payment method "Credit Card VISA" and check it has payment provider "Credit Card" and Payment Method Type "VISA". Clear the Payment Method Type field and save.

Login into the terminal https://livebuilds.openbravo.com/retail_stable_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS2-1#retail.pointofsale [^] Add a product and change the price of the product added to have a total of "350.50€" This is needed for the payment processor to validate the payment. Then go to the payment panel, Select "Credit Card" and tap on "Pay Total".

Observe the following error is raised: "Cannot read property 'searchKey' of undefined"

Proposed Solution

* Revert the constraint removed in the fix for the issue 42382.
* To help the configuration, add a new callout that selects the default payment method type when the payment provider changes.
* Verify current instances in production to verify there is not any wrong configuration. Payment provider without payment method type.

Additional Information

Tags

No tags attached.

Relationships

caused by	defect	0042382		closed	ranjith_qualiantech_com	'Payment Method Type' field should be able to set as empty when selecting a Payment Group
related to	defect	0044070		closed	adrianromero	API change: Restored constraint in payment methods in Touchpoint Type for payment groups