Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0043907

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

minor

have not tried

2020-04-30 10:32

2020-05-07 09:23

Reporter

caristu

View Status

public

Assigned To

migueldejuana

Priority

high

Resolution

fixed

Fixed in Version

RR20Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0043907: Error when login into WebPOS having messages pending to synchronize in the state

Description

If we login into WebPOS an there exists messages in the state pending to be synchronized, then the following error is raised when login:

0522af920179e8c1b4896634bd7b7672.js:42453 Uncaught (in promise) TypeError: Cannot read property 'transaction' of null
    at IndexedDBController.getReadWriteTransaction (0522af920179e8c1b4896634bd7b7672.js:42453)
    at IndexedDBController.write (0522af920179e8c1b4896634bd7b7672.js:42317)
    at IndexedDBController.put (0522af920179e8c1b4896634bd7b7672.js:42309)
    at MessageModelController.put (0522af920179e8c1b4896634bd7b7672.js:44054)
    at SynchronizationBuffer.onMessagesChanged (0522af920179e8c1b4896634bd7b7672.js:44180)
    at 0522af920179e8c1b4896634bd7b7672.js:41298

This is because we are trying to save the messages into the synchronization buffer IndexedDB database before it is initialized.

Steps To Reproduce

0) Leave a message pending to be synchronized in the state. For example force an error in the "onMessagesChanged" before executing "OB.App.State.Messages.removeMessages"

1) Login in WebPOS, note that the error mentioned in the Description is raised in the console

Proposed Solution

Ensure that we save the pending messages once the IndexedDB database is ready

Tags

No tags attached.

relatedTo43907.diff [^] (1,017 bytes) 2020-04-30 10:47 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js b/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js
index 14f929d4..139dd684 100644
--- a/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js
+++ b/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js
@@ -112,10 +112,12 @@
       if (messages.length > 0 && !this.isReceivingMessages) {
         this.isReceivingMessages = true;
         const messageIds = messages.map(message => message.id);
-        await OB.App.MessageModelController.put(messages);
-        this.isReceivingMessages = false;
+        try {
+          await OB.App.MessageModelController.put(messages);
+        } finally {
+          this.isReceivingMessages = false;
+        }
         await OB.App.State.Messages.removeMessages({ ids: messageIds });
-
         if (this.isStarted) {
           await this.internalFlush();
         }

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	backport	0043909	RR20Q2	closed	Retail	Error when login into WebPOS having messages pending to synchronize in the state
depends on	backport	0043931	RR20Q2	closed	migueldejuana	Error when login into WebPOS having messages pending to synchronize in the state

Notes
(0119549) hgbot (developer) 2020-05-05 10:21	Repository: erp/pmods/org.openbravo.mobile.core Changeset: 707f200bda830d235ae77f17e3c327552f7dede3 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Tue May 05 10:21:42 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/707f200bda830d235ae77f17e3c327552f7dede3 [^] Fixed issue 0043907: Error when login into WebPOS having messages pending to synchronize in the state - Wait to create Messages listener until the database is created (listener do a write, so it needs to have the database created) - In case doing a put of a message fails, do not block next executions of onMessageChanged --- M web/org.openbravo.mobile.core/app/model/synchronization-buffer/MessageModelController.js M web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js ---

Issue History
Date Modified	Username	Field	Change
2020-04-30 10:32	caristu	New Issue
2020-04-30 10:32	caristu	Assigned To	=> Retail
2020-04-30 10:32	caristu	Triggers an Emergency Pack	=> No
2020-04-30 10:47	caristu	File Added: relatedTo43907.diff
2020-04-30 10:59	caristu	Status	new => scheduled
2020-04-30 16:44	caristu	Proposed Solution updated
2020-05-05 10:21	hgbot	Checkin
2020-05-05 10:21	hgbot	Note Added: 0119549
2020-05-05 10:21	hgbot	Status	scheduled => resolved
2020-05-05 10:21	hgbot	Resolution	open => fixed
2020-05-05 10:21	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/707f200bda830d235ae77f17e3c327552f7dede3 [^]
2020-05-05 10:23	migueldejuana	Assigned To	Retail => migueldejuana
2020-05-05 10:23	migueldejuana	Status	resolved => new
2020-05-05 10:23	migueldejuana	Resolution	fixed => open
2020-05-05 10:25	migueldejuana	Status	new => scheduled
2020-05-05 10:25	migueldejuana	Status	scheduled => resolved
2020-05-05 10:25	migueldejuana	Resolution	open => fixed
2020-05-05 10:25	migueldejuana	Fixed in Version	=> RR20Q3
2020-05-07 09:23	marvintm	Review Assigned To	=> marvintm
2020-05-07 09:23	marvintm	Status	resolved => closed

Copyright © 2000 - 2009 MantisBT Group