Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0043769 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Retail Modules] Web POS | major | always | 2020-04-17 13:17 | 2020-04-24 15:03 | |||
| Reporter | jorge-garcia | View Status | public | |||||
| Assigned To | jorge-garcia | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR20Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | c4825f3c8266 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0043769: Discretionary Promotions in New Discount Engine for WebPOS state | |||||||
| Description | Discretionary promotions are added to the receipt in several ways depending on the discretionary promotion applied (manual promotion, manual by total promotion or coupons). This promotions were added in a proper way by the WebPOS adapter before are calculated by the new discount engine As part of WebPOS state development, we want to avoid the adapter and use a object property in the receipt called "discountsFromUser" every time a discretionary promotions is added/modified/removed. "discountsFromUser" is a plain javascript object with three objects inside: * manualPromotions: plain JS array with manual promotions from retail discounts module. * bytotalManualPromotions: plain JS array with manual promotions from retail by total discounts module. * coupons: plain JS array with manual promotions from retail coupons discounts module. The logic of discretionary promotion calculation must not be changed and the results should be the same as before. | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0119240) hgbot (developer) 2020-04-17 13:47 |
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal Changeset: d1d8cf3395f8bb726a20b9dd0eb22fba85cae28f Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Fri Apr 17 13:22:08 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/d1d8cf3395f8bb726a20b9dd0eb22fba85cae28f [^] Related to BUG-43769: Change manual by total promotions to use discountsFromUser object from receipt --- M web/org.openbravo.retail.discounts.bytotal/js/deleteDiscountExtension.js M web/org.openbravo.retail.discounts.bytotal/js/preApplyDiscountsHook.js --- |
|
(0119241) hgbot (developer) 2020-04-17 13:47 |
Repository: erp/pmods/org.openbravo.retail.discounts.coupons Changeset: f4e367b41b87d1ca351edb1c9b863e462e70b8c2 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Fri Apr 17 13:23:28 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/f4e367b41b87d1ca351edb1c9b863e462e70b8c2 [^] Related to BUG-43769: Change coupons to use discountsFromUser object from receipt --- M web/org.openbravo.retail.discounts.coupons/js/hooks/preordersavehook.js M web/org.openbravo.retail.discounts.coupons/js/utils/utils.js --- |
|
(0119242) hgbot (developer) 2020-04-17 18:13 |
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal Changeset: 028f0681376926549e36c8eb94356ce20225ccb1 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Fri Apr 17 18:12:59 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/028f0681376926549e36c8eb94356ce20225ccb1 [^] Related to BUG-43769: Initialize receipt discountFromUser object in case it does not exists --- M web/org.openbravo.retail.discounts.bytotal/js/preApplyDiscountsHook.js --- |
|
(0119244) hgbot (developer) 2020-04-18 00:07 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: c4825f3c82669db4c1f8701d7500d7f93d9d9df1 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Fri Apr 17 13:30:00 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c4825f3c82669db4c1f8701d7500d7f93d9d9df1 [^] Fixed BUG-43769: Change manual promotions to use discountsFromUser receipt object Logic from WebPOs connector has change and does not do anymore the transformation of discretionary promotions. --- M web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js M web/org.openbravo.retail.posterminal/js/discountsengine/pos/pos-discounts.js M web/org.openbravo.retail.posterminal/js/model/discounts.js M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalDeleteDiscounts.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js --- |
|
(0119245) hgbot (developer) 2020-04-18 00:08 |
Repository: tools/automation/pi-mobile Changeset: e64fec37d158e510325bfabdbf9d5ceac6ff3eca Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Fri Apr 17 13:37:38 2020 +0200 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e64fec37d158e510325bfabdbf9d5ceac6ff3eca [^] Related to BUG-43769: Remove test from Cancel and Replace as it is not valid In a cancel and replace scenario, manual promotions applied should not be recalculated even if the line is changed. --- R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cancelandreplace/CancelAndRplcManualDiscount.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-04-17 13:17 | jorge-garcia | New Issue | |
| 2020-04-17 13:17 | jorge-garcia | Assigned To | => jorge-garcia |
| 2020-04-17 13:17 | jorge-garcia | OBNetwork customer | => No |
| 2020-04-17 13:17 | jorge-garcia | Triggers an Emergency Pack | => No |
| 2020-04-17 13:17 | jorge-garcia | Status | new => scheduled |
| 2020-04-17 13:47 | hgbot | Checkin | |
| 2020-04-17 13:47 | hgbot | Note Added: 0119240 | |
| 2020-04-17 13:47 | hgbot | Checkin | |
| 2020-04-17 13:47 | hgbot | Note Added: 0119241 | |
| 2020-04-17 18:13 | hgbot | Checkin | |
| 2020-04-17 18:13 | hgbot | Note Added: 0119242 | |
| 2020-04-18 00:07 | hgbot | Checkin | |
| 2020-04-18 00:07 | hgbot | Note Added: 0119244 | |
| 2020-04-18 00:07 | hgbot | Status | scheduled => resolved |
| 2020-04-18 00:07 | hgbot | Resolution | open => fixed |
| 2020-04-18 00:07 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c4825f3c82669db4c1f8701d7500d7f93d9d9df1 [^] |
| 2020-04-18 00:08 | hgbot | Checkin | |
| 2020-04-18 00:08 | hgbot | Note Added: 0119245 | |
| 2020-04-24 15:03 | marvintm | Review Assigned To | => marvintm |
| 2020-04-24 15:03 | marvintm | Status | resolved => closed |
| 2020-04-24 15:03 | marvintm | Fixed in Version | => RR20Q3 |
| 2020-05-06 13:41 | alostale | Relationship added | causes 0043961 |
| 2021-07-26 17:58 | adrianromero | Relationship added | causes 0047453 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |