Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043732
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2020-04-14 15:232020-04-30 13:12
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in VersionRR20Q3
StatusclosedFix in branchFixed in SCM revision0c560720a370
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tojarmendariz
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043732: state listener that changes another state gets incorrectly invoked

DescriptionIf a state model listener for model A produces a new state in another model, that listener gets incorrectly invoked again producing a cycle.
Steps To ReproduceSee test: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/14/diffs?commit_id=f7688ac26b68fb501b4a444bdb9c2c9744a487ea [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0119208)
alostale (viewer)
2020-04-16 08:35

 MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/14 [^]
(0119209)
hgbot (developer)
2020-04-16 08:38

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0c560720a3701c00c66994b68f7bac0dc9e1f7b3
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Apr 14 15:30:36 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0c560720a3701c00c66994b68f7bac0dc9e1f7b3 [^]

fixed BUG-43732: listeners changing state are incorrectly invoked

When a state model listener produced a new state in another model, it
was invoked again.

This was caused because current state that is kept within
ListenerManager to compare with current state was refreshed only after
all listeners were executed, if a listener produced a new state, the
base comparision should be the state just before invoking it rather than
the original one.

Now current state gets updated before listener execution so in case it
produces changes, states comparision is correct.

---
M web-test/model/application-state/PersistenceChangeListenerManager.test.js
M web/org.openbravo.mobile.core/app/model/application-state/PersistenceChangeListenerManager.js
---
(0119503)
jarmendariz (viewer)
2020-04-30 13:12

 Reviewed

- Issue History
Date Modified Username Field Change
2020-04-14 15:23 alostale New Issue
2020-04-14 15:23 alostale Assigned To => Retail
2020-04-14 15:23 alostale OBNetwork customer => No
2020-04-14 15:23 alostale Triggers an Emergency Pack => No
2020-04-15 09:18 alostale Steps to Reproduce Updated View Revisions
2020-04-15 15:35 alostale Assigned To Retail => alostale
2020-04-15 15:35 alostale Review Assigned To => jarmendariz
2020-04-16 08:35 alostale Note Added: 0119208
2020-04-16 08:38 hgbot Checkin
2020-04-16 08:38 hgbot Note Added: 0119209
2020-04-16 08:38 hgbot Status new => resolved
2020-04-16 08:38 hgbot Resolution open => fixed
2020-04-16 08:38 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0c560720a3701c00c66994b68f7bac0dc9e1f7b3 [^]
2020-04-30 13:12 jarmendariz Note Added: 0119503
2020-04-30 13:12 jarmendariz Status resolved => closed
2020-04-30 13:12 jarmendariz Fixed in Version => RR20Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker