Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043392
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] 00. Application dictionarymajoralways2020-03-02 21:502021-10-29 10:16
ReporteragonzalezView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in VersionPR22Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0PR19Q3.3SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043392: Change column type of body column for table C_POC_EMAILDEFINITION to CLOB

DescriptionThe column body of the table C_POC_EMAILDEFINITION is currently restricted to 4000 characters at database level, and it's not currently possible to introduce HTML templates of more than 4000 characters.
Steps To Reproduce1. Go to Document Type -> Report Templates -> Email Definition
2. Try to add a E-mail template with a body that contains a length of more than 4000 characters
3. An error will be raised
Proposed SolutionChange the column type of body to CLOB (text in database)
Please check the provided diff file
TagsNo tags attached.
Attached Filespatch file icon c_poc_emaildefinition_columntype.patch [^] (654 bytes) 2020-03-02 21:50 [Show Content]
patch file icon c_poc_email_columntype.patch [^] (614 bytes) 2020-03-03 16:37 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
causes defect 0047945 closedcberner API Change: Changed C_POC_EMAIL* body column types from varchar to CLOB 

-  Notes
(0132670)
hgbot (developer)
2021-10-27 10:21

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/447 [^]
(0132731)
hgbot (developer)
2021-10-29 09:22

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/447 [^]
(0132732)
hgbot (developer)
2021-10-29 09:22

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 3294ebe59ef4f17f1ddcfdf7974481602df09aab
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-10-29T07:21:50+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/3294ebe59ef4f17f1ddcfdf7974481602df09aab [^]

Fixes ISSUE-43392: Change column type of body column for table C_POC_EMAIL* to CLOB

C_POC_EMAIL and C_POC_EMAILDEFINITION column body is updated from
varchar to CLOB. This allows not being limited by the 4000 characters
varchar supported. It also has a side-effect though:
- Oracle requires a table recreation on update.database due to the type
being changed from varchar to clob. Tables will not be recreated in
postgres though, because it changes from varchar to text.

---
M src-db/database/model/tables/C_POC_EMAIL.xml
M src-db/database/model/tables/C_POC_EMAILDEFINITION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0132735)
hgbot (developer)
2021-10-29 09:48

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: e7a3cee73bdd1af641b94077894f8bd0e635eb11
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-10-29T07:48:44+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/e7a3cee73bdd1af641b94077894f8bd0e635eb11 [^]

Revert "Fixes ISSUE-43392: Change column type of body column for table C_POC_EMAIL* to CLOB"

This reverts commit 3294ebe59ef4f17f1ddcfdf7974481602df09aab
---
M src-db/database/model/tables/C_POC_EMAIL.xml
M src-db/database/model/tables/C_POC_EMAILDEFINITION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0132750)
hgbot (developer)
2021-10-29 10:12

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/448 [^]
(0132751)
hgbot (developer)
2021-10-29 10:16

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/448 [^]
(0132752)
hgbot (developer)
2021-10-29 10:16

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 6c9dd745e8f8781fccb5883ef97c7132a9d8dcd4
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-10-29T10:10:14+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/6c9dd745e8f8781fccb5883ef97c7132a9d8dcd4 [^]

Fixes ISSUE-43392: Change column type of body column for table C_POC_EMAIL* to CLOB

C_POC_EMAIL and C_POC_EMAILDEFINITION column body is updated from
varchar to CLOB. This allows not being limited by the 4000 characters
varchar supported. It also has a side-effect though:
- Oracle requires a table recreation on update.database due to the type
being changed from varchar to clob. Tables will not be recreated in
postgres though, because it changes from varchar to text.

---
M src-db/database/model/tables/C_POC_EMAIL.xml
M src-db/database/model/tables/C_POC_EMAILDEFINITION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---

- Issue History
Date Modified Username Field Change
2020-03-02 21:50 agonzalez New Issue
2020-03-02 21:50 agonzalez Assigned To => platform
2020-03-02 21:50 agonzalez File Added: c_poc_emaildefinition_columntype.patch
2020-03-02 21:50 agonzalez Modules => Core
2020-03-02 21:50 agonzalez Triggers an Emergency Pack => No
2020-03-03 16:37 agonzalez File Added: c_poc_email_columntype.patch
2020-03-03 17:59 ucarrion Note Added: 0118305
2021-10-26 14:03 cberner Status new => acknowledged
2021-10-26 14:03 cberner Assigned To platform => cberner
2021-10-26 16:52 guilleaer Status acknowledged => scheduled
2021-10-27 10:21 hgbot Note Added: 0132670
2021-10-27 10:28 cberner Status scheduled => acknowledged
2021-10-27 10:37 cberner Status acknowledged => scheduled
2021-10-27 15:44 AugustoMauch Note Deleted: 0118305
2021-10-28 09:38 cberner Relationship added causes 0047945
2021-10-29 09:22 hgbot Note Added: 0132731
2021-10-29 09:22 hgbot Resolution open => fixed
2021-10-29 09:22 hgbot Status scheduled => closed
2021-10-29 09:22 hgbot Fixed in Version => PR22Q1
2021-10-29 09:22 hgbot Note Added: 0132732
2021-10-29 09:48 hgbot Note Added: 0132735
2021-10-29 10:12 hgbot Note Added: 0132750
2021-10-29 10:16 hgbot Note Added: 0132751
2021-10-29 10:16 hgbot Note Added: 0132752

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker