Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0043292 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | always | 2020-02-21 14:30 | 2020-05-08 14:09 | |||
| Reporter | cberner | View Status | public | |||||
| Assigned To | cberner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR20Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | ff45077d275e | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | alostale | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0043292: Git hooks for jslint and jsformatter don't work on files with both staged and ustaged changes | |||||||
| Description | Git hooks migrated from mercurial for jslint and jsformatter use the current file in the workspace when files are staged instead of the staged file. So if there are files that have both staged changes and unstaged changes, the file checked by the linter will be the one that contains both staged and unstaged changes, instead of only the staged changes. So it will fail to commit if the unstaged changes break the linter. It also fails with git commit --amend, doesn't do any checking in those cases. | |||||||
| Steps To Reproduce | In description | |||||||
| Proposed Solution | When passing the linter/formatter only take into account the staged files, using git show :file should work. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0119350) cberner (viewer) 2020-04-23 10:18 |
Merge Request: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/63 [^] |
|
(0119588) hgbot (developer) 2020-05-05 16:28 |
Repository: erp/devel/pi Changeset: ff45077d275ede2fec6489bcc6e3c12e20a18c15 Author: Cristian Berner <cristian.berner <at> openbravo.com> Date: Mon Apr 20 17:06:53 2020 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/ff45077d275ede2fec6489bcc6e3c12e20a18c15 [^] Fixes ISSUE-43292: Jslint and jsformatter git hooks work on staged changes only --- M .githooks/pre-commit.d/00-jslint M .githooks/pre-commit.d/01-jsformatter M modules/org.openbravo.client.kernel/jsformatter/jsformatter M modules/org.openbravo.client.kernel/jslint/jslint --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-02-21 14:30 | cberner | New Issue | |
| 2020-02-21 14:30 | cberner | Assigned To | => cberner |
| 2020-02-21 14:30 | cberner | OBNetwork customer | => No |
| 2020-02-21 14:30 | cberner | Modules | => Core |
| 2020-02-21 14:30 | cberner | Triggers an Emergency Pack | => No |
| 2020-03-03 15:42 | cberner | Description Updated | View Revisions |
| 2020-04-23 10:18 | cberner | Status | new => scheduled |
| 2020-04-23 10:18 | cberner | Note Added: 0119350 | |
| 2020-05-05 16:28 | hgbot | Checkin | |
| 2020-05-05 16:28 | hgbot | Note Added: 0119588 | |
| 2020-05-05 16:28 | hgbot | Status | scheduled => resolved |
| 2020-05-05 16:28 | hgbot | Resolution | open => fixed |
| 2020-05-05 16:28 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/ff45077d275ede2fec6489bcc6e3c12e20a18c15 [^] |
| 2020-05-08 14:09 | alostale | Review Assigned To | => alostale |
| 2020-05-08 14:09 | alostale | Status | resolved => closed |
| 2020-05-08 14:09 | alostale | Fixed in Version | => 3.0PR20Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |