Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0043105
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-02-04 08:542020-02-07 13:50
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revisioneb0604a6f614
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043105: Apply new HQL Style in LandedCostDistributionByAmount.java

DescriptionLandedCostDistributionByAmount.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedplatform Tracking issue: Convert HQL to apply new style 

-  Notes
(0117448)
inigo_lerga (developer)
2020-02-04 10:04
edited on: 2020-02-04 10:59

Test Plan Mantis HQL queries:
As the F&B International Group Admin role:
    - Go to the Process Request window and select the
      record with "Costing Background process" in the Process
      field. Press the Unschedule Process button and then
      Close button in the popup window.

    - Create a new Process Request in this same window,
      with "F&B International Group" as client and "*" Organization.
      Set the Process to "Costing Background process" and Timing
      "Run Immediately". Save the record.
      
    - Go to the Goods Receipt window and create a new record
      with "Bebidas Alegres, S.L." as Business Partner.
      Go to the Lines Tab and create a new line with "Cerveza Ale 0,5L"
      as Product. Save the record.
      Press the Complete button and OK in the popup window.

    - Go to the Process Request window, select the previously created
      Process request and press the Schedule Process button and then
      Close button in the popup window.

    - Go to the Landed Cost Type window and create a new record. Name it
      TEST. Put "Distribution by Amount" in the Landed Cost Distribution
      Algorithm field and "Capital Social" in the Account field.
      Save the record.

    - Go to the Landed Cost window and create a new record. Leave every
      field as default.
      Go to the Cost Tab and create a new Cost record. Set the previously
      created Landed Cost Type in its field and any desired amount. Make sure
      that the Landed Cost Distribution Algorithm is "Distribution by Amount".
      Go to the Receipt Tab and create a new Receipt record. Set the previously
      created Goods Receipt in th Goods Receipt field, and select the
      "Cerveza Ale 0,5L" line in the Goods Receipt Line.
      Save the record.
      Press the Process button and Done in the popup window.

    #In this moment the modified HQL is executed#

(0117571)
hgbot (developer)
2020-02-07 13:49

Repository: erp/devel/pi
Changeset: eb0604a6f614b9094d409c57d356f58e28ccb69b
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Feb 04 09:50:25 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/eb0604a6f614b9094d409c57d356f58e28ccb69b [^]

fixes BUG-43105:Applied new HQL Style + finals added

---
M src/org/openbravo/costing/LandedCostDistributionByAmount.java
---
(0117572)
hgbot (developer)
2020-02-07 13:49

Repository: erp/devel/pi
Changeset: 4fdc3c57705c964857d8156c0e2d1e23610f0de0
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Feb 07 13:49:11 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4fdc3c57705c964857d8156c0e2d1e23610f0de0 [^]

Related to ISSUE-43105: Code Review changes
* Use ids instead of objects in hql query
* Changed names of variables to better reflect
that they refer to ids

---
M src/org/openbravo/costing/LandedCostDistributionByAmount.java
---
(0117573)
dmiguelez (developer)
2020-02-07 13:50

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-02-04 08:54 inigo_lerga New Issue
2020-02-04 08:54 inigo_lerga Assigned To => inigo_lerga
2020-02-04 08:54 inigo_lerga Modules => Core
2020-02-04 08:54 inigo_lerga Triggers an Emergency Pack => No
2020-02-04 08:55 inigo_lerga Relationship added related to 0041287
2020-02-04 08:55 inigo_lerga Status new => scheduled
2020-02-04 10:04 inigo_lerga Note Added: 0117448
2020-02-04 10:59 inigo_lerga Note Edited: 0117448 View Revisions
2020-02-07 13:49 hgbot Checkin
2020-02-07 13:49 hgbot Note Added: 0117571
2020-02-07 13:49 hgbot Status scheduled => resolved
2020-02-07 13:49 hgbot Resolution open => fixed
2020-02-07 13:49 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/eb0604a6f614b9094d409c57d356f58e28ccb69b [^]
2020-02-07 13:49 hgbot Checkin
2020-02-07 13:49 hgbot Note Added: 0117572
2020-02-07 13:50 dmiguelez Review Assigned To => dmiguelez
2020-02-07 13:50 dmiguelez Note Added: 0117573
2020-02-07 13:50 dmiguelez Status resolved => closed
2020-02-07 13:50 dmiguelez Fixed in Version => 3.0PR20Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker