Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0043098
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-02-03 12:182020-02-28 09:05
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision46d6ad2346ed
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043098: Speed-up delete client (and related junit test) by only loading tables (and not full dbsm model)

DescriptionSystemService.deleteClient needs to disable foreign keys, triggers and some constraints before the client deletion itself.

It currently used getModelFromDatabase(platform, true) to load the whole database model (including functions, triggers, views) & running pl standardization.

As the code needed only needs the table related things it should use getTablesFromDatabase instead skipping the extra items.

That removes around 20-30s of runtime of the delete client (& junit) test.
Steps To Reproduce-
TagsNo tags attached.
Attached Filesdiff file icon 43098.diff [^] (1,263 bytes) 2020-02-05 15:03 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0118195)
hgbot (developer)
2020-02-28 09:04

Repository: erp/devel/pi
Changeset: 46d6ad2346edc55b152504c8ae0a2929549dc106
Author: Stefan Huehner <stefan.huehner <at> openbravo.com>
Date: Fri Feb 28 08:53:55 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/46d6ad2346edc55b152504c8ae0a2929549dc106 [^]

fixes BUG-43098: Speed-up delete client by only loading tables

  SystemService.deleteClient needs to disable foreign keys, triggers and some constraints before the client deletion itself.

  That method was using getModelFromDatabase(platform, true) to load the whole database model (including functions, triggers, views) and also it was running pl standardization.

  As the code needed only table related things it now use the new getTablesFromDatabase() method which just loads the table information skipping the extra items.

  This change removes around 20-30s of runtime of the delete client (& junit) test.

---
M src/org/openbravo/service/system/SystemService.java
---
(0118196)
caristu (developer)
2020-02-28 09:05

Reviewed

- Issue History
Date Modified Username Field Change
2020-02-03 12:18 shuehner New Issue
2020-02-03 12:18 shuehner Assigned To => platform
2020-02-03 12:18 shuehner Modules => Core
2020-02-03 12:18 shuehner Triggers an Emergency Pack => No
2020-02-03 12:20 shuehner Assigned To platform => shuehner
2020-02-05 15:03 shuehner File Added: 43098.diff
2020-02-28 09:04 hgbot Checkin
2020-02-28 09:04 hgbot Note Added: 0118195
2020-02-28 09:04 hgbot Status new => resolved
2020-02-28 09:04 hgbot Resolution open => fixed
2020-02-28 09:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/46d6ad2346edc55b152504c8ae0a2929549dc106 [^]
2020-02-28 09:05 caristu Review Assigned To => caristu
2020-02-28 09:05 caristu Status resolved => closed
2020-02-28 09:05 caristu Fixed in Version => 3.0PR20Q2
2020-02-28 09:05 caristu Note Added: 0118196


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker