Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0043002
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 04. Warehouse managementmajoralways2020-01-24 10:482020-04-06 15:51
ReporterngarciaView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityimmediateResolutionfixedFixed in Version3.0PR20Q1
StatusclosedFix in branchFixed in SCM revisione4ecc6432800
ProjectionnoneETAnoneTarget Version3.0PR20Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression levelPackaging and release
Regression date2019-12-05
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/4f441ebb434f0b6fe5f1cb81583246b4f5223814 [^]
Triggers an Emergency PackNo
Summary

0043002: Validating a new costing rule is trying to create physical inventories in organizations where transactions are not allowed

DescriptionValidating a new costing rule is trying to create physical inventories in organizations where transactions are not allowed
Steps To ReproduceOn F&B client.

1. Create a new organization (name: Org A) child of F&B España, S.A of type Organization.
2. Create a new organization (name: Generic) child of "Org A" of type Generic.
3. Create a new warehouse (name: Test WH) on "Org A" organization
3. Create a new Product (name: Test) of type item and stocked.
4. Create a physical inventory to initialize the stock of the product "Test" on the warehouse "Test WH" set a cost of 10 EUR before processing the inventory.
5. Ensure that the costing background process is executed and that the transaction of the physical inventory is calculated.
6. Go to Costing RUles window and create a new costing rule for F&B España, S.A
7. Try to validate it and check the following error message is shown:

The header document belongs to an organization where transactions are not allowed
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0042398 closedcollazoandy4 When validating a new costing rule, physical inventories should be created in the warehouse's organization 
blocks defect 0042994 closedAtulOpenbravo Validating a new costing rule is trying to create physical inventories in organizations where transactions are not allowed 

-  Notes
(0117243)
AtulOpenbravo (developer)
2020-01-27 03:48

Test Plan

- Login as F&B International Group Admin role.
- Using Initial Organization Setup, create a new organization (name: Org A) child of F&B España, S.A of type Organization, set Include Accounting File or Accounting Reference Data = No.
- Navigate to Organization window, set above Organization summary flag = Yes and set it as ready.
- Similarly create a new organization (name: Generic) child of "Org A" of type Generic, set this organization as ready.
- Log out and Log in.
- Create a new warehouse (name: Test WH) on "Org A" organization
- Create a new Product (name: Test) of type item and stocked.
- Create a physical inventory to initialize the stock of the product "Test" on the warehouse "Test WH" set a cost of 10 EUR before processing the inventory.
- Ensure that the costing background process is executed and that the transaction of the physical inventory is calculated.
- Go to Costing Rules window and create a new costing rule for F&B España, S.A
- Try to validate it and realize that process is successful.
(0117354)
hgbot (developer)
2020-01-30 11:07

Repository: erp/backports/3.0PR20Q1
Changeset: 1951eaae5f71ac4ccee6e4f2d1f7e2be4f7b91c1
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Jan 28 12:18:34 2020 +0530
URL: http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/1951eaae5f71ac4ccee6e4f2d1f7e2be4f7b91c1 [^]

Fixes BUG-0043002: Validating a new costing rule is trying to
create physical inventories in organizations where transactions
are not allowed

**Use Organization from the Parent list of Warehouse Organization
whose organization type has transaction allowed flag set as Yes,
if no such organization is found, the use Organization from the
Inventory Line
* Used final modifier to variables and parameters
* Defined separated methods to improve redability

---
M src/org/openbravo/costing/CostingRuleProcess.java
M src/org/openbravo/costing/CostingUtils.java
M src/org/openbravo/costing/InventoryAmountUpdateProcess.java
---
(0117355)
hgbot (developer)
2020-01-30 11:07

Repository: erp/backports/3.0PR20Q1
Changeset: 2c103163ef99712bef44c8179be2a0ad344dd136
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jan 30 09:58:01 2020 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/2c103163ef99712bef44c8179be2a0ad344dd136 [^]

Related to BUG-43002: Code Review changes. Added documentation to public method

---
M src/org/openbravo/costing/CostingUtils.java
---
(0117358)
dmiguelez (developer)
2020-01-30 11:08

Code Review + Testing Ok
(0118959)
hgbot (developer)
2020-04-06 11:52

Repository: erp/devel/pi
Changeset: e4ecc64328002cd6fcbe28e6f10dbc1c15fef844
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Jan 28 12:18:34 2020 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/e4ecc64328002cd6fcbe28e6f10dbc1c15fef844 [^]

Fixes BUG-0043002: Validating a new costing rule is trying to
create physical inventories in organizations where transactions
are not allowed

**Use Organization from the Parent list of Warehouse Organization
whose organization type has transaction allowed flag set as Yes,
if no such organization is found, the use Organization from the
Inventory Line
* Used final modifier to variables and parameters
* Defined separated methods to improve redability

---
M src/org/openbravo/costing/CostingRuleProcess.java
M src/org/openbravo/costing/CostingUtils.java
M src/org/openbravo/costing/InventoryAmountUpdateProcess.java
---
(0118998)
cberner (developer)
2020-04-06 15:51

closed: wrongly reopened

- Issue History
Date Modified Username Field Change
2020-01-24 13:41 AtulOpenbravo Type defect => backport
2020-01-24 13:41 AtulOpenbravo Target Version => 3.0PR20Q1
2020-01-24 13:45 AtulOpenbravo Regression date => 2019-12-05
2020-01-24 13:45 AtulOpenbravo Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/4f441ebb434f0b6fe5f1cb81583246b4f5223814 [^]
2020-01-24 13:46 AtulOpenbravo Assigned To Triage Finance => AtulOpenbravo
2020-01-27 03:48 AtulOpenbravo Note Added: 0117243
2020-01-28 09:31 AtulOpenbravo Regression level => Packaging and release
2020-01-28 09:31 AtulOpenbravo Regression introduced in release => main
2020-01-30 10:16 dmiguelez Regression level Packaging and release =>
2020-01-30 10:16 dmiguelez Regression date 2019-12-05 =>
2020-01-30 10:16 dmiguelez Regression introduced in release main =>
2020-01-30 10:16 dmiguelez Regression introduced by commit https://code.openbravo.com/erp/devel/pi/rev/4f441ebb434f0b6fe5f1cb81583246b4f5223814 [^] =>
2020-01-30 10:16 dmiguelez Relationship added related to 0042398
2020-01-30 10:23 dmiguelez Regression level => Packaging and release
2020-01-30 10:23 dmiguelez Regression date => 2019-12-05
2020-01-30 10:23 dmiguelez Regression introduced in release => main
2020-01-30 10:23 dmiguelez Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/4f441ebb434f0b6fe5f1cb81583246b4f5223814 [^]
2020-01-30 11:07 hgbot Checkin
2020-01-30 11:07 hgbot Note Added: 0117354
2020-01-30 11:07 hgbot Status scheduled => resolved
2020-01-30 11:07 hgbot Resolution open => fixed
2020-01-30 11:07 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/1951eaae5f71ac4ccee6e4f2d1f7e2be4f7b91c1 [^]
2020-01-30 11:07 hgbot Checkin
2020-01-30 11:07 hgbot Note Added: 0117355
2020-01-30 11:08 dmiguelez Review Assigned To => dmiguelez
2020-01-30 11:08 dmiguelez Note Added: 0117358
2020-01-30 11:08 dmiguelez Status resolved => closed
2020-01-30 11:08 dmiguelez Fixed in Version => 3.0PR20Q1
2020-04-06 11:52 hgbot Checkin
2020-04-06 11:52 hgbot Note Added: 0118959
2020-04-06 11:52 hgbot Status closed => resolved
2020-04-06 11:52 hgbot Fixed in SCM revision http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/1951eaae5f71ac4ccee6e4f2d1f7e2be4f7b91c1 [^] => http://code.openbravo.com/erp/devel/pi/rev/e4ecc64328002cd6fcbe28e6f10dbc1c15fef844 [^]
2020-04-06 15:51 cberner Note Added: 0118998
2020-04-06 15:51 cberner Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker