Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0042915
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-01-16 16:512020-01-22 18:36
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revisionaab954878646
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042915: Tree selector cannot be used in a parameter window that is opened from the menu

DescriptionWhen a parameter window contains a grid parameter that has a tree selector, it will only not work if the parameter window is opened directly from the menu. The window will not open and an error will be logged in the debugger.
Steps To Reproduce- Install the attached module
- Login, use any non-system role
- Open the Test Tree PW window. The parameter window will not open and the following error will appear in the console:

Uncaught TypeError: Cannot read property 'filterEditorProperties' of null
    at _2.copyFunctionsFromGrid (90889d3cbdfeb1f33d577faa47a07219.js:31047)
    at _2.copyFunctionsFromViewGrid (90889d3cbdfeb1f33d577faa47a07219.js:31040)
    at _2.init (90889d3cbdfeb1f33d577faa47a07219.js:31021)
    at _2.isc_Class_completeCreation [as completeCreation] (ISC_Combined.js:287)
    at Object.isc_c_Class_create (ISC_Combined.js:182)
    at _2.initWidget (90889d3cbdfeb1f33d577faa47a07219.js:30994)
    at _2.isc_Canvas_init [as init] (ISC_Combined.js:1657)
    at _2.isc_Class_createAutoChild [as createAutoChild] (ISC_Combined.js:327)
    at _2.isc_Class_addAutoChild [as addAutoChild] (ISC_Combined.js:317)
    at _2.init (90889d3cbdfeb1f33d577faa47a07219.js:31321)
TagsNo tags attached.
Attached Fileszip file icon org.openbravo.testtreeinpw.zip [^] (14,651 bytes) 2020-01-16 16:55

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0042916 closedAugustoMauch Selectors do not work properly in parameter windows if there are translations installed 

-  Notes
(0117052)
hgbot (developer)
2020-01-20 10:10

 Repository: erp/devel/pi
Changeset: aab9548786465469c69435c88dd0b9f028d56ca1
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Jan 16 17:24:21 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/aab9548786465469c69435c88dd0b9f028d56ca1 [^]

Fixes BUG-42915: Tree selectors can be used in menu parameter windows

The problem was that the code in OBTreeItemPopupFilterWindow.copyFunctionsFromGrid was assuming that the
grid where the selector has placed had a view that also had a viewGrid. This is not the case in grids that
are parameters in parameter windows that are open directly from the menu.

What the function does is to copy from functions from OBViewGrid to OBTreeItemPopupFilterWindow. For this
it does not need any real instance of viewGrid, any instance works. Because there is no real instance
available in this type of parameter windows, the issue has been fixed by creating a dummy one like this:

        if (grid == null) {
          grid = isc.OBViewGrid.create({ fields: [], view: {} });
        }

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree-filter.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0117179)
caristu (viewer)
2020-01-22 18:36

 Reviewed + tested OK: https://gitlab.com/openbravo/product/openbravo/merge_requests/34/ [^]

- Issue History
Date Modified Username Field Change
2020-01-16 16:51 AugustoMauch New Issue
2020-01-16 16:51 AugustoMauch Assigned To => AugustoMauch
2020-01-16 16:51 AugustoMauch OBNetwork customer => No
2020-01-16 16:51 AugustoMauch Modules => Core
2020-01-16 16:51 AugustoMauch Triggers an Emergency Pack => No
2020-01-16 16:55 AugustoMauch File Added: org.openbravo.testtreeinpw.zip
2020-01-16 16:56 AugustoMauch Description Updated View Revisions
2020-01-16 17:04 AugustoMauch Relationship added blocks 0042916
2020-01-20 10:10 hgbot Checkin
2020-01-20 10:10 hgbot Note Added: 0117052
2020-01-20 10:10 hgbot Status new => resolved
2020-01-20 10:10 hgbot Resolution open => fixed
2020-01-20 10:10 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/aab9548786465469c69435c88dd0b9f028d56ca1 [^]
2020-01-22 18:36 caristu Review Assigned To => caristu
2020-01-22 18:36 caristu Note Added: 0117179
2020-01-22 18:36 caristu Status resolved => closed
2020-01-22 18:36 caristu Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker